Bugfixes and cleanup

Author: Ville Vilpas

README.md

@@ -1,13 +1,17 @@
 # ESPNexUpload
-ESP8266 library for uploading .tft file to Nextion display using SPIFFS. 
+ESP8266 library for uploading .tft file to Nextion display using SPIFFS and SoftwareSerial. Currently it isn't possible to use HardwareSerial.
 
 ## Usage
-See example. Library expects that given file path is found at ESP8266 flash memory(SPIFFS). Included example provides webserver with file upload to SPIFFS.
+See example. Library expects that given file path is found at ESP8266 flash memory(SPIFFS). Included example provides webserver with file upload to SPIFFS. Sometimes upload doesnt work -> try to power cycle display.
 
-## BUGS
-- Doesn't work with esp8266 2.4.0 version. Use 2.3.0 until fixed.
+## Note on baudrates
+- Nextion <-> ESP8266 communication seems to be quite fault prone. 
+- With ESP8266 arduino core v2.4.0: Doesn't work with 115200 baudrate. 
+57600 seems to work fine. 
+- With ESP8266 arduino core v2.3.0: 115200 works fine. 
 
 ## Releases
+- v0.2.0 - Removed unnecessary delays. Works now with latest ESP8266 arduinocore (see notes)
 - v0.1.1 - Updated to comply with Arduino Library manager
 - v0.1.0 - Working with basic functionality. 
 

library.properties

@@ -1,5 +1,5 @@
 name=ESPNexUpload
-version=0.1.1
+version=0.2.0
 author=Ville Vilpas <[email protected]>
 maintainer=Ville Vilpas <[email protected]>
 sentence=Uploading UI file to Nextion display using ESP8266 SPIFFS

src/ESPNexUpload.cpp

@@ -6,7 +6,7 @@
  * Modified to work with ESP8266 and SoftwareSerial
  * @author Ville Vilpas ([email protected])
  * @date   2018/2/3
- * @version 0.1.1
+ * @version 0.2.0
  *
  * Original version (a part of https://github.com/itead/ITEADLIB_Arduino_Nextion)
  * @author  Chen Zengpeng (email:<[email protected]>)
@@ -32,7 +32,7 @@
 #include <FS.h>
 #include <SoftwareSerial.h>
 
-#define DEBUG_SERIAL_ENABLE
+//#define DEBUG_SERIAL_ENABLE
 
 #ifdef DEBUG_SERIAL_ENABLE
 #define dbSerialPrint(a)    Serial.print(a)
@@ -91,6 +91,7 @@ bool ESPNexUpload::upload(String &statusMessage)
 
 uint16_t ESPNexUpload::_getBaudrate(void)
 {
+    _baudrate = 0;
     uint32_t baudrate_array[7] = {115200,19200,9600,57600,38400,4800,2400};
     for(uint8_t i = 0; i < 7; i++)
     {
@@ -188,18 +189,14 @@ bool ESPNexUpload::_setDownloadBaudrate(uint32_t baudrate)
     String filesize_str = String(_undownloadByte,10);
     String baudrate_str = String(baudrate);
     cmd = "whmi-wri " + filesize_str + "," + baudrate_str + ",0";
-    
-    dbSerialPrintln(cmd);
 
     this->sendCommand("");
     this->sendCommand(cmd.c_str());
-    delay(50);
-    nexSerial->begin(baudrate);
-
-    dbSerialPrintln("Baudrate changed");
-    delay(50);
 
-    this->recvRetString(string,500);  
+    dbSerialPrintln("Changing baudrate...");
+    nexSerial->begin(baudrate);
+    
+    this->recvRetString(string);
 
     if(string.indexOf(0x05) != -1)
     { 

src/ESPNexUpload.h

@@ -6,7 +6,7 @@
  * Modified to work with ESP8266 and SoftwareSerial
  * @author Ville Vilpas ([email protected])
  * @date   2018/2/3
- * @version 0.1.1
+ * @version 0.2.0
  *
  * Original version (a part of https://github.com/itead/ITEADLIB_Arduino_Nextion)
  * @author  Chen Zengpeng (email:<[email protected]>)
@@ -130,12 +130,12 @@ class ESPNexUpload
      * @return the length of string buffer.
      *
      */   
-    uint16_t recvRetString(String &string, uint32_t timeout = 100,bool recv_flag = false);
+    uint16_t recvRetString(String &string, uint32_t timeout = 500,bool recv_flag = false);
 
 private: /* data */ 
     uint32_t _baudrate; /*nextion serail baudrate*/
     const char *_file_name; /*nextion tft file name*/
-    File _myFile; /*nextion ftf file*/
+    File _myFile; /*nextion tft file*/
     uint32_t _undownloadByte; /*undownload byte of tft file*/
     uint32_t _download_baudrate; /*download baudrate*/
     SoftwareSerial *nexSerial;