Skip to content

Consider Package Source Mapping sources for services in NuGet.PackageManagement.VisualStudio #12783

Open
@donnie-msft

Description

@donnie-msft

NuGet Product(s) Affected

Visual Studio Package Management UI

Current Behavior

PM UI uses feeds which directly query sources for package metadata.
This effectively bypasses Package Source Mapping since it considers all enabled sources.

Example,
https://github.com/NuGet/NuGet.Client/blob/84ba85d08b27afaa38ad4ae4e7e1684c74e9567c/src/NuGet.Clients/NuGet.PackageManagement.VisualStudio/PackageFeeds/MultiSourcePackageMetadataProvider.cs#L65

Desired Behavior

Consider Package Source Mapping sources for services in NuGet.PackageManagement.VisualStudio.
Ideally, extract the concept to an interface to help with testability across PM UI. Right now, PM UI and services have duplicated logic to call directly into source objects and ask for metadata, making it hard to test.

Additional Context

License Dialog in PM UI was addressed in NuGet/NuGet.Client#5295. While working on this, I discovered the other services which directly interact with package sources.

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions