RestoreTaskEx crash with /p:RestoreUseStaticGraphEvaluation=true /graph

[KirillOsenkov]

NuGet Product Used

MSBuild.exe

Product Version

18.0.5+e22287bf1

Worked before?

Not a regression

Impact

It's more difficult to complete my work

Repro Steps & Context

1. md 1 cd 1
2. dotnet new console
3. dotnet new sln
4. dotnet sln add 1.csproj
5. msbuild 1.sln /t:Restore;Build /bl /p:RestoreUseStaticGraphEvaluation=true /graph

Verbose Logs

MSBuild version 18.0.5+e22287bf1 for .NET Framework
Static graph construction started.
Static graph loaded in 0.261 seconds: 1 nodes, 0 edges
Project "C:\temp\1\1.csproj" on node 1 (Restore;Build target(s)).
Restore:
  Determining projects to restore...
C:\Program Files\Microsoft Visual Studio\18\Enterprise\Common7\IDE\CommonExtensions\Microsoft\NuGet\NuGet.RestoreEx.targets(19,5): error : '{' is an unexpected token. The expected token is '"' or '''. Line 2, position 33. [C:\temp\1\1.csproj]
C:\Program Files\Microsoft Visual Studio\18\Enterprise\Common7\IDE\CommonExtensions\Microsoft\NuGet\NuGet.RestoreEx.targets(19,5): error :    at System.Xml.XmlTextReaderImpl.Throw(Exception e) [C:\temp\1\1.csproj]
C:\Program Files\Microsoft Visual Studio\18\Enterprise\Common7\IDE\CommonExtensions\Microsoft\NuGet\NuGet.RestoreEx.targets(19,5): error :    at System.Xml.XmlTextReaderImpl.ParseAttributes() [C:\temp\1\1.csproj]
C:\Program Files\Microsoft Visual Studio\18\Enterprise\Common7\IDE\CommonExtensions\Microsoft\NuGet\NuGet.RestoreEx.targets(19,5): error :    at System.Xml.XmlTextReaderImpl.ParseElement() [C:\temp\1\1.csproj]
C:\Program Files\Microsoft Visual Studio\18\Enterprise\Common7\IDE\CommonExtensions\Microsoft\NuGet\NuGet.RestoreEx.targets(19,5): error :    at System.Xml.XmlTextReaderImpl.ParseElementContent() [C:\temp\1\1.csproj]
C:\Program Files\Microsoft Visual Studio\18\Enterprise\Common7\IDE\CommonExtensions\Microsoft\NuGet\NuGet.RestoreEx.targets(19,5): error :    at System.Xml.XmlLoader.LoadNode(Boolean skipOverWhitespace) [C:\temp\1\1.csproj]
C:\Program Files\Microsoft Visual Studio\18\Enterprise\Common7\IDE\CommonExtensions\Microsoft\NuGet\NuGet.RestoreEx.targets(19,5): error :    at System.Xml.XmlLoader.LoadDocSequence(XmlDocument parentDoc) [C:\temp\1\1.csproj]
C:\Program Files\Microsoft Visual Studio\18\Enterprise\Common7\IDE\CommonExtensions\Microsoft\NuGet\NuGet.RestoreEx.targets(19,5): error :    at System.Xml.XmlDocument.Load(XmlReader reader) [C:\temp\1\1.csproj]
C:\Program Files\Microsoft Visual Studio\18\Enterprise\Common7\IDE\CommonExtensions\Microsoft\NuGet\NuGet.RestoreEx.targets(19,5): error :    at Microsoft.Build.Shared.SolutionConfiguration.GetProjectConfigurations(String xmlString) [C:\temp\1\1.csproj]
C:\Program Files\Microsoft Visual Studio\18\Enterprise\Common7\IDE\CommonExtensions\Microsoft\NuGet\NuGet.RestoreEx.targets(19,5): error :    at Microsoft.Build.Shared.SolutionConfiguration..ctor(String xmlString) [C:\temp\1\1.csproj]
C:\Program Files\Microsoft Visual Studio\18\Enterprise\Common7\IDE\CommonExtensions\Microsoft\NuGet\NuGet.RestoreEx.targets(19,5): error :    at Microsoft.Build.Graph.ProjectInterpretation.<GetReferences>d__24.MoveNext() [C:\temp\1\1.csproj]
C:\Program Files\Microsoft Visual Studio\18\Enterprise\Common7\IDE\CommonExtensions\Microsoft\NuGet\NuGet.RestoreEx.targets(19,5): error :    at Microsoft.Build.Graph.GraphBuilder.ParseReferences(ProjectGraphNode parsedProject) [C:\temp\1\1.csproj]
C:\Program Files\Microsoft Visual Studio\18\Enterprise\Common7\IDE\CommonExtensions\Microsoft\NuGet\NuGet.RestoreEx.targets(19,5): error :    at Microsoft.Build.Graph.GraphBuilder.ParseProject(ConfigurationMetadata configurationMetadata) [C:\temp\1\1.csproj]
C:\Program Files\Microsoft Visual Studio\18\Enterprise\Common7\IDE\CommonExtensions\Microsoft\NuGet\NuGet.RestoreEx.targets(19,5): error :    at System.Lazy`1.CreateValue() [C:\temp\1\1.csproj]
C:\Program Files\Microsoft Visual Studio\18\Enterprise\Common7\IDE\CommonExtensions\Microsoft\NuGet\NuGet.RestoreEx.targets(19,5): error :    at System.Lazy`1.LazyInitValue() [C:\temp\1\1.csproj]
C:\Program Files\Microsoft Visual Studio\18\Enterprise\Common7\IDE\CommonExtensions\Microsoft\NuGet\NuGet.RestoreEx.targets(19,5): error :    at Microsoft.Build.Graph.ParallelWorkSet`2.ExecuteWorkItem() [C:\temp\1\1.csproj]
  The solution did not have any projects to restore, ensure that all projects are known to be MSBuild and that the projects exist.
Done Building Project "C:\temp\1\1.csproj" (Restore;Build target(s)) -- FAILED.

Build FAILED.

"C:\temp\1\1.csproj" (Restore;Build target) (1) ->
(Restore target) -> 
  C:\Program Files\Microsoft Visual Studio\18\Enterprise\Common7\IDE\CommonExtensions\Microsoft\NuGet\NuGet.RestoreEx.targets(19,5): error : '{' is an unexpected token. The expected token is '"' or '''. Line 2, position 33. [C:\temp\1\1.csproj]
C:\Program Files\Microsoft Visual Studio\18\Enterprise\Common7\IDE\CommonExtensions\Microsoft\NuGet\NuGet.RestoreEx.targets(19,5): error :    at System.Xml.XmlTextReaderImpl.Throw(Exception e) [C:\temp\1\1.csproj]
C:\Program Files\Microsoft Visual Studio\18\Enterprise\Common7\IDE\CommonExtensions\Microsoft\NuGet\NuGet.RestoreEx.targets(19,5): error :    at System.Xml.XmlTextReaderImpl.ParseAttributes() [C:\temp\1\1.csproj]
C:\Program Files\Microsoft Visual Studio\18\Enterprise\Common7\IDE\CommonExtensions\Microsoft\NuGet\NuGet.RestoreEx.targets(19,5): error :    at System.Xml.XmlTextReaderImpl.ParseElement() [C:\temp\1\1.csproj]
C:\Program Files\Microsoft Visual Studio\18\Enterprise\Common7\IDE\CommonExtensions\Microsoft\NuGet\NuGet.RestoreEx.targets(19,5): error :    at System.Xml.XmlTextReaderImpl.ParseElementContent() [C:\temp\1\1.csproj]
C:\Program Files\Microsoft Visual Studio\18\Enterprise\Common7\IDE\CommonExtensions\Microsoft\NuGet\NuGet.RestoreEx.targets(19,5): error :    at System.Xml.XmlLoader.LoadNode(Boolean skipOverWhitespace) [C:\temp\1\1.csproj]
C:\Program Files\Microsoft Visual Studio\18\Enterprise\Common7\IDE\CommonExtensions\Microsoft\NuGet\NuGet.RestoreEx.targets(19,5): error :    at System.Xml.XmlLoader.LoadDocSequence(XmlDocument parentDoc) [C:\temp\1\1.csproj]
C:\Program Files\Microsoft Visual Studio\18\Enterprise\Common7\IDE\CommonExtensions\Microsoft\NuGet\NuGet.RestoreEx.targets(19,5): error :    at System.Xml.XmlDocument.Load(XmlReader reader) [C:\temp\1\1.csproj]
C:\Program Files\Microsoft Visual Studio\18\Enterprise\Common7\IDE\CommonExtensions\Microsoft\NuGet\NuGet.RestoreEx.targets(19,5): error :    at Microsoft.Build.Shared.SolutionConfiguration.GetProjectConfigurations(String xmlString) [C:\temp\1\1.csproj]
C:\Program Files\Microsoft Visual Studio\18\Enterprise\Common7\IDE\CommonExtensions\Microsoft\NuGet\NuGet.RestoreEx.targets(19,5): error :    at Microsoft.Build.Shared.SolutionConfiguration..ctor(String xmlString) [C:\temp\1\1.csproj]
C:\Program Files\Microsoft Visual Studio\18\Enterprise\Common7\IDE\CommonExtensions\Microsoft\NuGet\NuGet.RestoreEx.targets(19,5): error :    at Microsoft.Build.Graph.ProjectInterpretation.<GetReferences>d__24.MoveNext() [C:\temp\1\1.csproj]
C:\Program Files\Microsoft Visual Studio\18\Enterprise\Common7\IDE\CommonExtensions\Microsoft\NuGet\NuGet.RestoreEx.targets(19,5): error :    at Microsoft.Build.Graph.GraphBuilder.ParseReferences(ProjectGraphNode parsedProject) [C:\temp\1\1.csproj]
C:\Program Files\Microsoft Visual Studio\18\Enterprise\Common7\IDE\CommonExtensions\Microsoft\NuGet\NuGet.RestoreEx.targets(19,5): error :    at Microsoft.Build.Graph.GraphBuilder.ParseProject(ConfigurationMetadata configurationMetadata) [C:\temp\1\1.csproj]
C:\Program Files\Microsoft Visual Studio\18\Enterprise\Common7\IDE\CommonExtensions\Microsoft\NuGet\NuGet.RestoreEx.targets(19,5): error :    at System.Lazy`1.CreateValue() [C:\temp\1\1.csproj]
C:\Program Files\Microsoft Visual Studio\18\Enterprise\Common7\IDE\CommonExtensions\Microsoft\NuGet\NuGet.RestoreEx.targets(19,5): error :    at System.Lazy`1.LazyInitValue() [C:\temp\1\1.csproj]
C:\Program Files\Microsoft Visual Studio\18\Enterprise\Common7\IDE\CommonExtensions\Microsoft\NuGet\NuGet.RestoreEx.targets(19,5): error :    at Microsoft.Build.Graph.ParallelWorkSet`2.ExecuteWorkItem() [C:\temp\1\1.csproj]

[KirillOsenkov]

This is because the command line passed to NuGet.Build.Tasks.Console.exe corrupts the CurrentSolutionConfigurationContents XML resulting in invalid XML.

Here's how to repro without MSBuild:

C:\Program Files\Microsoft Visual Studio\18\Enterprise\Common7\IDE\CommonExtensions\Microsoft\NuGet\NuGet.Build.Tasks.Console.exe

"Recursive=True;CleanupAssetsForUnsupportedProjects=True;DisableParallel=False;Force=False;ForceEvaluate=False;HideWarningsAndErrors=False;IgnoreFailedSources=False;Interactive=False;NoCache=False;NoHttpCache=False;RestorePackagesConfig=False" "C:\Program Files\Microsoft Visual Studio\18\Enterprise\MSBuild\Current\Bin\amd64\MSBuild.exe" "C:\termp\1\1.sln" "SolutionFileName=DataExtensions.sln;BuildingSolutionFile=true;CurrentSolutionConfigurationContents=<SolutionConfiguration>  <ProjectConfiguration Project="{AA7556FF-5659-FD4C-19C2-AF919717EAF1}" AbsolutePath="C:\temp\1\1.csproj" BuildProjectInSolution="True">Debug|AnyCPU</ProjectConfiguration></SolutionConfiguration>;Configuration=Debug;EnforceProcessCountAcrossBuilds=true;SolutionDir=C:\temp\1\;SolutionExt=.sln;Platform=AnyCPU;SolutionPath=C:\temp\1\1.sln;SolutionName=1;ReportAnalyzer=true;IsGraphBuild=true;ExcludeRestorePackageImports=True;OriginalMSBuildStartupDirectory=C:\temp\1"

[KirillOsenkov]

The CurrentSolutionConfigurationContents ends up being invalid XML without the quotes around attributes:

<SolutionConfiguration> <ProjectConfiguration Project={AA7556FF-5659-FD4C-19C2-AF919717EAF1} AbsolutePath=C:\temp\1\1.csproj BuildProjectInSolution=True>Debug|AnyCPU</ProjectConfiguration></SolutionConfiguration>

[KirillOsenkov]

Note that /r works while /t:Restore;Build doesn't