Skip to content

Commit f80e322

Browse files
authored
Run Reactant tests with Julia v1.12 as well (#577)
* Run Reactant tests with Julia v1.12 as well * [CI] Run Julia v1.12 tests with `--check-bounds=auto` * Remove Reactant from test sources * Move comment around * Load Reactant also for quality assurance tests in v1.12
1 parent fab76dc commit f80e322

6 files changed

Lines changed: 13 additions & 10 deletions

File tree

.github/workflows/Benchmarks.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ concurrency:
2121
env:
2222
# Don't make Reactant occupy all the GPU memory
2323
XLA_REACTANT_GPU_PREALLOCATE: 'false'
24+
JULIA_PKG_SERVER_REGISTRY_PREFERENCE: 'eager'
2425

2526
jobs:
2627
run-benchmarks:

.github/workflows/CI.yml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ permissions:
2828
env:
2929
# Don't make Reactant occupy all the GPU memory
3030
XLA_REACTANT_GPU_PREALLOCATE: 'false'
31+
JULIA_PKG_SERVER_REGISTRY_PREFERENCE: 'eager'
3132

3233
jobs:
3334
test:
@@ -55,12 +56,12 @@ jobs:
5556
- version: "min"
5657
os: windows-latest
5758
include:
59+
# `--check-bounds=auto` is necessary for testing Reactant workloads
60+
# until https://github.com/EnzymeAD/Reactant.jl/issues/2347 is fixed.
5861
- version: "1.12.5"
5962
os: aws-linux-nvidia-gpu-l4
6063
arch: "default"
61-
check-bounds: "yes"
62-
# Necessary for testing Reactant workloads until
63-
# https://github.com/EnzymeAD/Reactant.jl/issues/2347 is fixed.
64+
check-bounds: "auto"
6465
- version: "1.11.9"
6566
os: aws-linux-nvidia-gpu-l4-4xl
6667
arch: "default"

.github/workflows/Documentation.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ env:
2525
BREEZE_LABEL_BUILD_ALL_EXAMPLES: 'build all examples 🏗️'
2626
# Don't make Reactant occupy all the GPU memory
2727
XLA_REACTANT_GPU_PREALLOCATE: 'false'
28+
JULIA_PKG_SERVER_REGISTRY_PREFERENCE: 'eager'
2829

2930
jobs:
3031
build-docs:

test/Project.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ NCDatasets = "0.14"
3939
Oceananigans = "0.105.1, 0.106"
4040
ParallelTestRunner = "2.0.1"
4141
RRTMGP = "0.21"
42-
Reactant = "0.2.210"
42+
Reactant = "0.2.238"
4343
SpecialFunctions = "2"
4444
Statistics = "<0.0.1, 1"
4545
Test = "<0.0.1, 1"

test/quality_assurance.jl

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,15 +9,15 @@ using ClimaComms: ClimaComms
99
using Dates: Dates
1010
using RRTMGP: RRTMGP
1111
using SpecialFunctions: SpecialFunctions
12-
if VERSION < v"1.12"
13-
using Reactant: Reactant
12+
using Reactant: Reactant
1413

14+
allow_unanalyzable = if VERSION < v"1.12"
1515
# For some reason `BreezeReactantExt` is non-analyzable,
1616
# but only in Julia v1.11-.
1717
BreezeReactantExt = isdefined(Base, :get_extension) ? Base.get_extension(Breeze, :BreezeReactantExt) : Breeze.BreezeReactantExt
18-
allow_unanalyzable = (BreezeReactantExt,)
18+
(BreezeReactantExt,)
1919
else
20-
allow_unanalyzable = ()
20+
()
2121
end
2222

2323
@testset "Aqua" begin

test/runtests.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,11 @@ testsuite = find_tests(@__DIR__)
88
# Parse arguments
99
args = parse_args(ARGS)
1010

11-
const REACTANT_COMPAT = !((VERSION >= v"1.12") || (Base.JLOptions().check_bounds == 1))
11+
const REACTANT_COMPAT = VERSION < v"1.13-" && Base.JLOptions().check_bounds != 1
1212

1313
if filter_tests!(testsuite, args)
1414
# Reactant compilation tests require --check-bounds=auto (Reactant/Enzyme
15-
# limitation) and Julia < 1.12 until upstream support is improved.
15+
# limitation).
1616
if !REACTANT_COMPAT
1717
delete!(testsuite, "reactant_centered_compilation")
1818
delete!(testsuite, "reactant_weno_compilation")

0 commit comments

Comments
 (0)