Skip to content

Commit c3fb20c

Browse files
Change default example (#276)
1 parent d6a13f7 commit c3fb20c

File tree

6 files changed

+14
-8
lines changed

6 files changed

+14
-8
lines changed

NEWS.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,12 @@ DispersiveShallowWater.jl follows the interpretation of
55
used in the Julia ecosystem. Notable changes will be documented in this file
66
for human readability.
77

8+
## Changes when updating to v0.9 from v0.8.x
9+
10+
#### Changed
11+
12+
- Changed the `default_example()` from a BBM-BBM setup to a physically more relevant Serre-Green-Naghdi setup ([#276]).
13+
814
## Changes in the v0.8 lifecycle
915

1016
#### Added

Project.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
name = "DispersiveShallowWater"
22
uuid = "4ab875f6-b79a-4e28-9745-4f0293954817"
33
authors = ["Joshua Lampert <joshua.lampert@uni-hamburg.de>"]
4-
version = "0.8.9-DEV"
4+
version = "0.9.0-DEV"
55

66
[deps]
77
BandedMatrices = "aae01518-5342-5314-be14-df237901396f"

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ In the Julia REPL, first load the package DispersiveShallowWater.jl
5858
julia> using DispersiveShallowWater
5959
```
6060

61-
You can run a basic simulation that solves the BBM-BBM equations by executing
61+
You can run a basic simulation that solves the Serre-Green-Naghdi equations by executing
6262

6363
```julia
6464
julia> include(default_example());

docs/src/index.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ In the Julia REPL, first load the package [DispersiveShallowWater.jl](https://gi
5959
julia> using DispersiveShallowWater
6060
```
6161

62-
You can run a basic simulation that solves the BBM-BBM equations by executing
62+
You can run a basic simulation that solves the Serre-Green-Naghdi equations by executing
6363

6464
```julia
6565
julia> include(default_example());

src/util.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ See also [`examples_dir`](@ref) and [`get_examples`](@ref).
4444
Copied from [Trixi.jl](https://github.com/trixi-framework/Trixi.jl).
4545
"""
4646
function default_example()
47-
joinpath(examples_dir(), "bbm_bbm_1d", "bbm_bbm_1d_basic.jl")
47+
joinpath(examples_dir(), "serre_green_naghdi_1d", "serre_green_naghdi_soliton.jl")
4848
end
4949

5050
"""

test/test_unit.jl

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -540,15 +540,15 @@ end
540540

541541
accuracy_orders = [2, 4, 6]
542542
for accuracy_order in accuracy_orders
543-
eoc_mean_values, _ = convergence_test(@__MODULE__, default_example(), 2, N = 512,
543+
eoc_mean_values, _ = convergence_test(@__MODULE__, default_example(), 2, N = 256,
544544
tspan = (0.0, 1.0),
545545
accuracy_order = accuracy_order)
546546
@test isapprox(eoc_mean_values[:l2][1], accuracy_order, atol = 0.5)
547-
@test isapprox(eoc_mean_values[:linf][2], accuracy_order, atol = 0.5)
548-
@test isapprox(eoc_mean_values[:l2][1], accuracy_order, atol = 0.5)
547+
@test isapprox(eoc_mean_values[:linf][1], accuracy_order, atol = 0.5)
548+
@test isapprox(eoc_mean_values[:l2][2], accuracy_order, atol = 0.5)
549549
@test isapprox(eoc_mean_values[:linf][2], accuracy_order, atol = 0.5)
550550

551-
eoc_mean_values2, _ = convergence_test(@__MODULE__, default_example(), [512, 1024],
551+
eoc_mean_values2, _ = convergence_test(@__MODULE__, default_example(), [256, 512],
552552
tspan = (0.0, 1.0),
553553
accuracy_order = accuracy_order)
554554
for kind in (:l2, :linf), variable in (1, 2)

0 commit comments

Comments
 (0)