Skip to content

Commit e4e36e8

Browse files
Apply suggestions from code review
Co-authored-by: Joshua Lampert <51029046+JoshuaLampert@users.noreply.github.com>
1 parent 52cd1da commit e4e36e8

File tree

2 files changed

+2
-5
lines changed

2 files changed

+2
-5
lines changed

src/equations/serre_green_naghdi_1d.jl

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -119,11 +119,8 @@ function initial_condition_manufactured(x, t,
119119

120120
if equations.bathymetry_type isa BathymetryFlat
121121
D = zero(h)
122-
elseif equations.bathymetry_type isa BathymetryVariable ||
123-
equations.bathymetry_type isa BathymetryMildSlope
124-
D = -(1.5 - cospi(2 * x))
125122
else
126-
error("$(equations.bathymetry_type) not supported for initial_condition_manufactured for the Serre Green Naghdi Equation.")
123+
D = -(1.5 - cospi(2 * x))
127124
end
128125

129126
b = -D

test/test_serre_green_naghdi_1d.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -325,7 +325,7 @@ end
325325
cons_error=[1.7763568394002505e-15 0.00019895120429092028 0.0],
326326
change_waterheight=-1.7763568394002505e-15,
327327
change_entropy_modified=135.16210732695845,
328-
atol=1e-9) # to make CI pass)
328+
atol=1e-9) # to make CI pass
329329

330330
@test_allocations(semi, sol, allocs=410_000)
331331
end

0 commit comments

Comments
 (0)