Skip to content

Commit f1c24e9

Browse files
Apply suggestions from code review
Co-authored-by: Joshua Lampert <51029046+JoshuaLampert@users.noreply.github.com>
1 parent 062f4d9 commit f1c24e9

File tree

4 files changed

+5
-5
lines changed

4 files changed

+5
-5
lines changed

src/equations/kdv_1d.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ function KdVEquation1D(; gravity, D = 1.0, eta0 = 0.0)
5353
KdVEquation1D(gravity, D, eta0)
5454
end
5555

56-
# KdV equations have stiff third-order derivative terms that benefit IMEX methods
56+
# KdV equations have stiff third-order derivative terms that benefit from IMEX methods
5757
have_stiff_terms(::KdVEquation1D) = Val{true}()
5858

5959
"""

src/semidiscretization.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -269,7 +269,7 @@ function _check_split_rhs_implementation(semi)
269269
args = (nothing, nothing, nothing, mesh, equations, initial_condition,
270270
boundary_conditions, source_terms, solver, cache)
271271

272-
# # Check if methods are applicable
272+
# Check if methods are applicable
273273
if !applicable(rhs!, args..., :stiff)
274274
throw(ArgumentError("Split RHS method with :stiff argument not implemented for $equation_name."))
275275
end

test/test_kdv_1d.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,5 +68,5 @@ end
6868
cons_error=[2.220446049250313e-15],
6969
change_waterheight=-2.220446049250313e-15)
7070

71-
@test_allocations_splitform(semi, sol, allocs=5_000)
71+
@test_allocations_split_ode(semi, sol, allocs=5_000)
7272
end

test/test_util.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -177,13 +177,13 @@ macro test_allocations(semi, sol, allocs)
177177
end
178178

179179
"""
180-
@test_allocations_splitform(semi, sol, allocs)
180+
@test_allocations_split_ode(semi, sol, allocs)
181181
182182
Test that the memory allocations of `DispersiveShallowWater.rhs_split_stiff!`
183183
and `DispersiveShallowWater.rhs_split_nonstiff!` are below `allocs`
184184
(e.g., from type instabilities).
185185
"""
186-
macro test_allocations_splitform(semi, sol, allocs)
186+
macro test_allocations_split_ode(semi, sol, allocs)
187187
quote
188188
t = $sol.t[end]
189189
q = $sol.u[end]

0 commit comments

Comments
 (0)