Fix PDC tag handling for everyone-open lock signs

Author: phoenixlzx

src/main/java/me/crafter/mc/lockettepro/BlockPlayerListener.java

@@ -97,12 +97,14 @@ public void onPlayerQuickLockChest(PlayerInteractEvent event) {
                         Utils.putSignOn(block, blockface, Config.getDefaultAdditionalString(), "", itemInUse.getType());
                         Utils.removeASign(player, event.getHand());
                         Utils.sendMessages(player, Config.getLang("additional-sign-added-quick"));
+                        Utils.refreshLockedContainerPdcTagLater(block);
                         Dependency.logPlacement(player, block.getRelative(blockface));
                     } else if (LocketteProAPI.isOwner(block, player)) {
                         // Locked, (not locked door nearby), is owner of locked block
                         Utils.putSignOn(block, blockface, Config.getDefaultAdditionalString(), "", itemInUse.getType());
                         Utils.removeASign(player, event.getHand());
                         Utils.sendMessages(player, Config.getLang("additional-sign-added-quick"));
+                        Utils.refreshLockedContainerPdcTagLater(block);
                         Dependency.logPlacement(player, block.getRelative(blockface));
                     } else {
                         // Cannot lock this block
@@ -168,13 +170,15 @@ public void onManualLock(SignChangeEvent event) {
                         event.setLine(0, Config.getLang("sign-error"));
                     } else {
                         Utils.sendMessages(player, Config.getLang("additional-sign-added-manual"));
+                        Utils.refreshLockedContainerPdcTagLater(block);
                     }
                 } else if (LocketteProAPI.isOwner(block, player)) {
                     if (LocketteProAPI.isLockString(topline)) {
                         Utils.sendMessages(player, Config.getLang("block-already-locked-manual"));
                         event.setLine(0, Config.getLang("sign-error"));
                     } else {
                         Utils.sendMessages(player, Config.getLang("additional-sign-added-manual"));
+                        Utils.refreshLockedContainerPdcTagLater(block);
                     }
                 } else { // Not possible to fall here except override
                     Utils.sendMessages(player, Config.getLang("block-already-locked-manual"));

src/main/java/me/crafter/mc/lockettepro/Dependency.java

@@ -66,6 +66,7 @@ public static boolean isPermissionGroupOf(String line, Player player) {
 
     public static boolean isScoreboardTeamOf(String line, Player player) {
         ScoreboardManager scoreboardManager = Bukkit.getScoreboardManager();
+        if (scoreboardManager == null) return false;
         Team team = scoreboardManager.getMainScoreboard().getEntityTeam(player);
         if (team == null) {
             return false;

src/main/java/me/crafter/mc/lockettepro/LockettePro.java

@@ -203,6 +203,7 @@ public boolean onCommand(@NotNull CommandSender sender, Command cmd, @NotNull St
                                                 if (selectedSign != null)
                                                     Utils.updateUuidByUsername(selectedSign, Integer.parseInt(args[0]) - 1);
                                             }
+                                            Utils.refreshLockedContainerPdcTagLater(LocketteProAPI.getAttachedBlock(block));
                                             break;
                                     }
                                 } else if (LocketteProAPI.isAdditionalSign(block)) {
@@ -222,6 +223,7 @@ public boolean onCommand(@NotNull CommandSender sender, Command cmd, @NotNull St
                                                 if (selectedSign != null)
                                                     Utils.updateUuidByUsername(selectedSign, Integer.parseInt(args[0]) - 1);
                                             }
+                                            Utils.refreshLockedContainerPdcTagLater(LocketteProAPI.getAttachedBlock(block));
                                             break;
                                     }
                                 } else {

src/main/java/me/crafter/mc/lockettepro/LocketteProAPI.java

@@ -162,6 +162,63 @@ public static boolean isUserSingleBlock(Block block, BlockFace exempt, Player pl
         return false;
     }
 
+    public static boolean isOpenToEveryone(Block block) {
+        if (block == null) return false;
+        return isOpenToEveryoneByTag(block);
+    }
+
+    private static boolean isOpenToEveryoneByTag(Block block) {
+        if (block.getBlockData() instanceof Door) {
+            Block[] doors = getDoors(block);
+            if (doors == null) return false;
+            for (BlockFace doorface : newsfaces) {
+                Block relative0 = doors[0].getRelative(doorface), relative1 = doors[1].getRelative(doorface);
+                if (relative0.getType() == doors[0].getType() && relative1.getType() == doors[1].getType()) {
+                    if (isOpenToEveryoneSingleBlock(relative1.getRelative(BlockFace.UP), doorface.getOppositeFace()))
+                        return true;
+                    if (isOpenToEveryoneSingleBlock(relative1, doorface.getOppositeFace())) return true;
+                    if (isOpenToEveryoneSingleBlock(relative0, doorface.getOppositeFace())) return true;
+                    if (isOpenToEveryoneSingleBlock(relative0.getRelative(BlockFace.DOWN), doorface.getOppositeFace()))
+                        return true;
+                }
+            }
+            if (isOpenToEveryoneSingleBlock(doors[1].getRelative(BlockFace.UP), null)) return true;
+            if (isOpenToEveryoneSingleBlock(doors[1], null)) return true;
+            if (isOpenToEveryoneSingleBlock(doors[0], null)) return true;
+            if (isOpenToEveryoneSingleBlock(doors[0].getRelative(BlockFace.DOWN), null)) return true;
+        } else if (block.getBlockData() instanceof Chest) {
+            BlockFace chestface = getRelativeChestFace(block);
+            if (chestface != null) {
+                Block relativechest = block.getRelative(chestface);
+                if (isOpenToEveryoneSingleBlock(relativechest, chestface.getOppositeFace())) return true;
+            }
+        }
+        return isOpenToEveryoneSingleBlock(block, null);
+    }
+
+    public static boolean isOpenToEveryoneSingleBlock(Block block, BlockFace exempt) {
+        for (BlockFace blockface : newsfaces) {
+            if (blockface == exempt) continue;
+            Block relativeblock = block.getRelative(blockface);
+            if (isLockSignOrAdditionalSign(relativeblock) && getFacing(relativeblock) == blockface) {
+                if (isEveryoneOnSign(relativeblock)) {
+                    return true;
+                }
+            }
+        }
+        return false;
+    }
+
+    public static boolean isEveryoneOnSign(Block block) { // Requires (isLockSign or isAdditionalSign)
+        String[] lines = ((Sign) block.getState()).getSide(Side.FRONT).getLines();
+        for (int i = 1; i < 4; i++) {
+            if (Config.isEveryoneSignString(lines[i])) {
+                return true;
+            }
+        }
+        return false;
+    }
+
     public static boolean isOwnerOfSign(Block block, Player player) { // Requires isSign
         Block protectedblock = getAttachedBlock(block);
         // Normal situation, that block is just locked by an adjacent sign

src/main/java/me/crafter/mc/lockettepro/Utils.java

@@ -214,7 +214,7 @@ private static void setLockedContainerPdc(Block block, boolean locked) {
     public static void refreshLockedContainerPdcTag(Block block) {
         if (block == null) return;
 
-        boolean locked = LocketteProAPI.isLocked(block);
+        boolean locked = LocketteProAPI.isLocked(block) && !LocketteProAPI.isOpenToEveryone(block);
         setLockedContainerPdc(block, locked);
         syncConnectedContainerPdc(block, locked);
     }