(fix) IllegalArgumentException on sign change

Author: Lori3f6

src/main/java/cat/nyaa/ukit/signedit/SignEditFunction.java

@@ -10,15 +10,11 @@
 import land.melon.lab.simplelanguageloader.utils.TextUtils;
 import org.bukkit.Bukkit;
 import org.bukkit.Location;
-import org.bukkit.block.BlockFace;
 import org.bukkit.block.Sign;
-import org.bukkit.block.data.Directional;
 import org.bukkit.command.Command;
 import org.bukkit.command.CommandSender;
 import org.bukkit.entity.Player;
-import org.bukkit.event.block.BlockPlaceEvent;
-import org.bukkit.inventory.EquipmentSlot;
-import org.bukkit.inventory.ItemStack;
+import org.bukkit.event.block.SignChangeEvent;
 
 import java.util.Arrays;
 import java.util.List;
@@ -81,20 +77,14 @@ public boolean invokeCommand(CommandSender commandSender, Command command, Strin
                             return true;
                         }
                     }
-                    var signSide = Utils.getSignSideLookingAt(senderPlayer, sign);
+                    var side = Utils.getSignSideLookingAt(senderPlayer, sign);
+                    var signSide = sign.getSide(side);
                     var lineContentBeforeChange = signSide.getLine(line - 1);
                     signSide.setLine(line - 1, finalLine);
                     sign.update();
-                    var blockPlaceEvent = new BlockPlaceEvent(targetBlock, targetBlock.getState(),
-                            targetBlock.getBlockData() instanceof Directional ?
-                                    targetBlock.getRelative(((Directional) targetBlock.getBlockData()).getFacing().getOppositeFace()) :
-                                    targetBlock.getRelative(BlockFace.DOWN),
-                            new ItemStack(targetBlock.getType(), 1),
-                            senderPlayer,
-                            !inInSpawnProtection(targetBlock.getLocation()) || senderPlayer.isOp(),
-                            EquipmentSlot.HAND);
-                    Bukkit.getPluginManager().callEvent(blockPlaceEvent);
-                    if (blockPlaceEvent.isCancelled()) {
+                    var signChangeEvent = new SignChangeEvent(targetBlock, senderPlayer, signSide.lines(), side);
+                    Bukkit.getPluginManager().callEvent(signChangeEvent);
+                    if (signChangeEvent.isCancelled()) {
                         signSide.setLine(line - 1, lineContentBeforeChange);
                         sign.update();
                         senderPlayer.sendMessage(pluginInstance.language.signEditLang.modifyCancelled.produce());
@@ -140,8 +130,8 @@ public List<String> tabComplete(CommandSender sender, Command command, String al
                         if (LockettePluginUtils.isLockSign(targetBlock)) {
                             return List.of();
                         }
-                        var signSide = Utils.getSignSideLookingAt(player, sign);
-
+                        var lookingSide = Utils.getSignSideLookingAt(player, sign);
+                        var signSide = sign.getSide(lookingSide);
                         var suggestion = signSide.getLine(line - 1).replaceAll("&", "§§").replaceAll("§", "&");
                         return suggestion.length() == 0 ? List.of() : List.of(suggestion);
                     }

src/main/java/cat/nyaa/ukit/utils/Utils.java

@@ -10,7 +10,6 @@
 import org.bukkit.block.data.Directional;
 import org.bukkit.block.data.Rotatable;
 import org.bukkit.block.sign.Side;
-import org.bukkit.block.sign.SignSide;
 import org.bukkit.entity.Entity;
 import org.bukkit.entity.Player;
 import org.bukkit.inventory.EquipmentSlot;
@@ -85,15 +84,15 @@ public static double getAngleFromBlockFace(BlockFace blockFace) {
         return angleInDegrees;
     }
 
-    public static SignSide getSignSideLookingAt(Player player, Sign sign) {
+    public static Side getSignSideLookingAt(Player player, Sign sign) {
         var signLoc = getCenterOfSign(sign);
         var playerLoc = Vector3D.fromBukkitLocation(player.getLocation());
         var angle = angleFromSignFace(playerLoc, signLoc, sign.getBlockData());
 
         if (angle > 270 || angle <= 90)
-            return sign.getSide(Side.FRONT);
+            return Side.FRONT;
         else
-            return sign.getSide(Side.BACK);
+            return Side.BACK;
     }
 
     public static Entity getEntityLookingAt(Player player, Predicate<Entity> predicate) {