[MIG] account_ecotax_tax: Migration to 18.0

Author: rvalyi

account_ecotax_tax/__manifest__.py

@@ -4,7 +4,7 @@
 {
     "name": "Ecotax Management (with Odoo tax)",
     "summary": "Use Odoo tax mechanism to compute the ecotaxes ",
-    "version": "17.0.1.0.1",
+    "version": "18.0.1.0.1",
     "author": "Akretion, Odoo Community Association (OCA)",
     "website": "https://github.com/OCA/account-fiscal-rule",
     "category": "Localization/Account Taxes",

account_ecotax_tax/models/account_tax.py

@@ -22,11 +22,21 @@ def onchange_is_ecotax(self):
         if self.is_ecotax:
             self.amount_type = "code"
             self.include_base_amount = True
-            self.python_compute = """
+            self.formula = """
 # price_unit
 # product: product.product object or None
 # partner: res.partner object or None
-# for weight based ecotax
-# result = quantity and  product.weight_based_ecotax * quantity or 0.0
-result = quantity and product.fixed_ecotax  * quantity or 0.0
+# for weight based ecotax:
+# quantity and  product.weight_based_ecotax * quantity or 0.0
+quantity and product.fixed_ecotax * quantity or 0.0
             """
+
+    def _eval_taxes_computation_prepare_product_fields(self):
+        # In Odoo 18, product is passed as a dictionary in the eval context.
+        # We need to specify which fields should be included in this dictionary.
+        return super()._eval_taxes_computation_prepare_product_fields() | {
+            "fixed_ecotax",
+            "weight_based_ecotax",
+            "ecotax_amount",
+            "weight",
+        }

account_ecotax_tax/tests/test_ecotax.py

@@ -15,27 +15,25 @@ def setUpClass(cls):
         # included with tax not included (B2B case)
         # Also for this version, the included use case using tax is broken because
         # of a bug in Odoo core (check readme)
-        cls.invoice_tax.price_include = False
+        cls.invoice_tax.price_include_override = "tax_excluded"
         cls.invoice_ecotax_account = cls.env["account.account"].create(
             {
                 "code": "707120",
                 "name": "Ecotax Account",
                 "account_type": "income",
-                "company_id": cls.env.user.company_id.id,
             }
         )
         cls.invoice_fixed_ecotax = cls.env["account.tax"].create(
             {
                 "name": "Fixed Ecotax",
                 "type_tax_use": "sale",
                 "company_id": cls.env.user.company_id.id,
-                "price_include": False,
+                "price_include_override": "tax_excluded",
                 "amount_type": "code",
                 "include_base_amount": True,
                 "sequence": 0,
                 "is_ecotax": True,
-                "python_compute": "result = (quantity and"
-                " product.fixed_ecotax * quantity  or 0.0)",
+                "formula": "quantity and product.fixed_ecotax * quantity or 0.0",
                 "tax_exigibility": "on_invoice",
                 "invoice_repartition_line_ids": [
                     (
@@ -84,11 +82,10 @@ def setUpClass(cls):
                 "company_id": cls.env.user.company_id.id,
                 "amount_type": "code",
                 "include_base_amount": True,
-                "price_include": False,
+                "price_include_override": "tax_excluded",
                 "sequence": 0,
                 "is_ecotax": True,
-                "python_compute": "result = (quantity and"
-                " product.weight_based_ecotax * quantity or 0.0)",
+                "formula": "quantity and product.weight_based_ecotax * quantity or 0.0",
                 "tax_exigibility": "on_invoice",
                 "invoice_repartition_line_ids": [
                     (