[FIX] account_invoice_report_grouped_by_picking: skip non-return moves on refunds

When a credit note is created without physical return, its lines
inherit move_line_ids from the original delivery moves. The report
processed these delivery moves as if they were return moves,
showing wrong picking associations and wrong quantities.

Now delivery moves (location_id.usage != 'customer') are skipped
for out_refund invoices. Affected lines fall through to the
module's existing lines_dict/no_picking path and render under
'Without reference' in the report.

Updates test assertions to verify product lines have no picking
and 'Without reference' appears when no return picking exists.

Author: rrebollo

account_invoice_report_grouped_by_picking/models/account_move.py

@@ -103,6 +103,15 @@ def lines_grouped_by_picking(self):
             remaining_qty = line.quantity
             # Process moves related to the line
             for move in line.move_line_ids:
+                # For credit notes without return, move_line_ids
+                # contain delivery moves from the original invoice.
+                # These must be skipped so lines fall through to
+                # lines_dict -> "Without reference" in the report.
+                if (
+                    self.move_type == "out_refund"
+                    and move.location_id.usage != "customer"
+                ):
+                    continue
                 key = (move.picking_id, line)
                 self._process_section_note_lines_grouped(
                     previous_section, previous_note, picking_dict, move.picking_id

account_invoice_report_grouped_by_picking/tests/test_account_invoice_group_picking.py

@@ -201,6 +201,19 @@ def test_account_invoice_return_without_returned_good(self):
         refund_invoice = self.env["account.move"].browse(reversal["res_id"])
         groups = refund_invoice.lines_grouped_by_picking()
         self.assertEqual(len(groups), 2)
+        # Product lines should not have a picking when no return picking exists
+        product_groups = [
+            g
+            for g in groups
+            if g["line"].display_type not in ("line_section", "line_note")
+            and g["line"].product_id.type != "service"
+        ]
+        for group in product_groups:
+            self.assertFalse(
+                group["picking"],
+                "Product line should not be grouped under a picking "
+                "when there is no return picking",
+            )
 
     def test_account_invoice_group_picking_refund(self):
         # confirm quotation
@@ -351,7 +364,19 @@ def test_account_invoice_group_picking_refund_without_return(self):
         # invoice = self.env["account.move"].browse(inv_id)
         groups = new_invoice.lines_grouped_by_picking()
         self.assertEqual(len(groups), 2)
-        self.assertEqual(groups[0]["picking"], groups[1]["picking"])
+        # Product lines should not have a picking when no return picking exists
+        product_groups = [
+            g
+            for g in groups
+            if g["line"].display_type not in ("line_section", "line_note")
+            and g["line"].product_id.type != "service"
+        ]
+        for group in product_groups:
+            self.assertFalse(
+                group["picking"],
+                "Product line should not be grouped under a picking "
+                "when there is no return picking",
+            )
         # Test report
         content = html.document_fromstring(
             self.env["ir.actions.report"]._render_qweb_html(
@@ -373,6 +398,13 @@ def test_account_invoice_group_picking_refund_without_return(self):
         )
         # information about pickings is printed
         self.assertTrue(picking.name in tbody)
+        # "Without reference" header appears for lines without picking
+        self.assertIn(
+            "Without reference",
+            tbody,
+            "Report should show 'Without reference' for credit note "
+            "lines with no return picking",
+        )
 
     def test_account_invoice_refund_with_section_line(self):
         """Credit note with section/note lines should not raise KeyError.