[16.0][IMP] account_payment_order: check that bank allows out payments

Author: astirpe

account_payment_order/models/account_move.py

@@ -5,6 +5,7 @@
 
 from odoo import _, api, fields, models
 from odoo.exceptions import UserError
+from odoo.fields import first
 
 
 class AccountMove(models.Model):
@@ -151,6 +152,24 @@ def create_account_payment_line(self):
                         "order": payment_lines.order_id.mapped("name"),
                     }
                 )
+
+            # Check that the bank allows out payments
+            for line in applicable_lines.filtered(
+                lambda l: l.account_id.account_type == "liability_payable"
+            ):
+                bank = line.partner_bank_id or first(line.partner_id.bank_ids)
+                if bank and not bank.allow_out_payment:
+                    raise UserError(
+                        _(
+                            'The option "Send Money" is not enabled on the bank '
+                            "account %(bank_account)s of partner %(partner)s."
+                        )
+                        % {
+                            "bank_account": bank.bank_name,
+                            "partner": line.partner_id.name,
+                        }
+                    )
+
             for payment_mode in payment_modes:
                 payorder = apoo.search(
                     move.get_account_payment_domain(payment_mode), limit=1

account_payment_order/tests/test_payment_order_outbound.py

@@ -79,6 +79,13 @@ def setUpClass(cls, chart_template_ref=None):
             ("company_id", "=", cls.env.user.company_id.id),
         ]
         cls.env["account.payment.order"].search(cls.domain).unlink()
+        cls.partner_bank = cls.env["res.partner.bank"].create(
+            {
+                "acc_number": "1234",
+                "partner_id": cls.partner.id,
+                "allow_out_payment": True,
+            }
+        )
 
     def _create_supplier_invoice(self, ref):
         invoice = self.env["account.move"].create(
@@ -573,3 +580,18 @@ def test_action_open_business_document(self):
         self.assertEqual(invoice_action["res_id"], self.invoice.id)
         manual_line_action = order.payment_line_ids[1].action_open_business_doc()
         self.assertFalse(manual_line_action)
+    def test_check_allow_out_payment(self):
+        """Check that, in case option "Send Money" is not enabled on
+        the bank, out payments are not allowed.
+        """
+        # Open invoice
+        self.invoice.action_post()
+
+        # Do not allow out payments
+        self.partner_bank.allow_out_payment = False
+
+        # Add to payment order using the wizard: error raised
+        with self.assertRaises(UserError):
+            self.env["account.invoice.payment.line.multi"].with_context(
+                active_model="account.move", active_ids=self.invoice.ids
+            ).create({}).run()