[MIG] account_payment_partner: Migration to 18.0

absal-smile · carlos-lopez-tecnativa · commit f2423e4dd2aa · 2025-04-16T14:18:42.000-05:00
diff --git a/account_payment_partner/README.rst b/account_payment_partner/README.rst
@@ -30,12 +30,12 @@ Account Payment Partner
 
 This module adds several fields:
 
--  the *Supplier Payment Mode* and *Customer Payment Mode* on Partners,
--  the *Payment Mode* on Invoices.
--  the *Show bank account* on Payment Mode.
--  the *# of digits for customer bank account* on Payment Mode.
--  the *Bank account from journals* on Payment Mode.
--  the *Payment mode* on Invoices Analysis.
+- the *Supplier Payment Mode* and *Customer Payment Mode* on Partners,
+- the *Payment Mode* on Invoices.
+- the *Show bank account* on Payment Mode.
+- the *# of digits for customer bank account* on Payment Mode.
+- the *Bank account from journals* on Payment Mode.
+- the *Payment mode* on Invoices Analysis.
 
 On a Payment Order, in the wizard *Select Invoices to Pay*, the invoices
 will be filtered per Payment Mode.
@@ -70,8 +70,8 @@ Changelog
 10.0.1.2.0 (2018-05-24)
 -----------------------
 
--  [IMP] Add options to show partner bank account in invoice report
-   (`#458 <https://github.com/OCA/bank-payment/issues/458>`__)
+- [IMP] Add options to show partner bank account in invoice report
+  (`#458 <https://github.com/OCA/bank-payment/issues/458>`__)
 
 Bug Tracker
 ===========
@@ -95,25 +95,25 @@ Authors
 Contributors
 ------------
 
--  Alexis de Lattre <alexis.delattre@akretion.com>
--  Raphaël Valyi
--  Stefan Rijnhart (Therp)
--  Alexandre Fayolle
--  Stéphane Bidoul <stephane.bidoul@acsone.eu>
--  Danimar Ribeiro
--  Angel Moya <angel.moya@domatix.com>
--  `Tecnativa <https://www.tecnativa.com>`__:
+- Alexis de Lattre <alexis.delattre@akretion.com>
+- Raphaël Valyi
+- Stefan Rijnhart (Therp)
+- Alexandre Fayolle
+- Stéphane Bidoul <stephane.bidoul@acsone.eu>
+- Danimar Ribeiro
+- Angel Moya <angel.moya@domatix.com>
+- `Tecnativa <https://www.tecnativa.com>`__:
 
-   -  Pedro M. Baeza
-   -  Carlos Dauden
-   -  Víctor Martínez
+  - Pedro M. Baeza
+  - Carlos Dauden
+  - Víctor Martínez
 
--  `DynApps <https://www.dynapps.be>`__:
+- `DynApps <https://www.dynapps.be>`__:
 
-   -  Raf Ven <raf.ven@dynapps.be>
+  - Raf Ven <raf.ven@dynapps.be>
 
--  Marçal Isern <marsal.isern@qubiq.es>
--  Miquel Alzanillas <malzanillas@apsl.net>
+- Marçal Isern <marsal.isern@qubiq.es>
+- Miquel Alzanillas <malzanillas@apsl.net>
 
 Maintainers
 -----------
diff --git a/account_payment_partner/demo/partner_demo.xml b/account_payment_partner/demo/partner_demo.xml
@@ -1,35 +1,13 @@
 <?xml version="1.0" encoding="utf-8" ?>
 <odoo noupdate="1">
-    <record
-        id="default_supplier_payment_mode_id"
-        model="ir.property"
-        forcecreate="True"
-    >
-        <field name="name">Default Supplier Payment Mode</field>
-        <field
-            name="fields_id"
-            search="[('model','=','res.partner'),('name','=','supplier_payment_mode_id')]"
-        />
-        <field
-            name="value"
-            eval="'account.payment.mode,'+str(ref('account_payment_mode.payment_mode_outbound_ct1'))"
-        />
-        <field name="company_id" ref="base.main_company" />
-    </record>
-    <record
-        id="default_customer_payment_mode_id"
-        model="ir.property"
-        forcecreate="True"
-    >
-        <field name="name">Default Customer Payment Mode</field>
-        <field
-            name="fields_id"
-            search="[('model','=','res.partner'),('name','=','customer_payment_mode_id')]"
-        />
-        <field
-            name="value"
-            eval="'account.payment.mode,'+str(ref('account_payment_mode.payment_mode_inbound_ct1'))"
-        />
-        <field name="company_id" ref="base.main_company" />
-    </record>
+    <function
+        model="ir.default"
+        name="set"
+        eval="('res.partner', 'supplier_payment_mode_id', ref('account_payment_mode.payment_mode_outbound_ct1'))"
+    />
+    <function
+        model="ir.default"
+        name="set"
+        eval="('res.partner', 'customer_payment_mode_id', ref('account_payment_mode.payment_mode_inbound_ct1'))"
+    />
 </odoo>
diff --git a/account_payment_partner/tests/test_account_payment_partner.py b/account_payment_partner/tests/test_account_payment_partner.py
@@ -5,7 +5,7 @@
 from odoo import _, fields
 from odoo.exceptions import UserError, ValidationError
 from odoo.fields import Date
-from odoo.tests.common import Form, TransactionCase, tagged
+from odoo.tests import Form, TransactionCase, tagged
 
 from odoo.addons.base.tests.common import DISABLED_MAIL_CONTEXT
 
@@ -124,7 +124,7 @@ def setUpClass(cls):
             .create(
                 {
                     "name": "Test customer",
-                    "customer_payment_mode_id": cls.customer_payment_mode,
+                    "customer_payment_mode_id": cls.customer_payment_mode.id,
                 }
             )
         )
@@ -135,7 +135,7 @@ def setUpClass(cls):
             .create(
                 {
                     "name": "Test supplier",
-                    "supplier_payment_mode_id": cls.supplier_payment_mode,
+                    "supplier_payment_mode_id": cls.supplier_payment_mode.id,
                 }
             )
         )
@@ -152,14 +152,14 @@ def setUpClass(cls):
         cls.invoice_account = cls.env["account.account"].search(
             [
                 ("account_type", "=", "liability_payable"),
-                ("company_id", "=", cls.company.id),
+                ("company_id", "in", cls.company.id),
             ],
             limit=1,
         )
         cls.invoice_line_account = cls.env["account.account"].search(
             [
                 ("account_type", "=", "expense"),
-                ("company_id", "=", cls.company.id),
+                ("company_id", "in", cls.company.id),
             ],
             limit=1,
         )
@@ -227,7 +227,7 @@ def test_create_partner(self):
             .create(
                 {
                     "name": "Test customer",
-                    "customer_payment_mode_id": self.customer_payment_mode,
+                    "customer_payment_mode_id": self.customer_payment_mode.id,
                 }
             )
         )
diff --git a/account_payment_partner/views/account_move_line.xml b/account_payment_partner/views/account_move_line.xml
@@ -11,8 +11,6 @@
         <field name="arch" type="xml">
             <xpath expr="//field[@name='analytic_distribution']/.." position="after">
                 <group name="payments" string="Payments">
-                    <field name="account_type" invisible="1" />
-                    <field name="reconciled" invisible="1" />
                     <field
                         name="payment_mode_id"
                         force_save="1"
@@ -29,8 +27,6 @@
         <field name="inherit_id" ref="account.view_move_line_tree" />
         <field name="arch" type="xml">
             <field name="date_maturity" position="after">
-                <field name="account_type" invisible="1" />
-                <field name="reconciled" invisible="1" />
                 <field
                     name="payment_mode_id"
                     optional="hide"
diff --git a/account_payment_partner/views/account_move_view.xml b/account_payment_partner/views/account_move_view.xml
@@ -31,10 +31,6 @@
                     readonly="has_reconciled_items"
                     invisible="move_type not in ['out_invoice','out_refund','in_invoice','in_refund']"
                 />
-                <field name="has_reconciled_items" invisible="1" />
-                <field name="bank_account_required" invisible="1" />
-                <field name="payment_mode_filter_type_domain" invisible="1" />
-                <field name="partner_bank_filter_type_domain" invisible="1" />
             </field>
             <xpath
                 expr="//group[@id='header_right_group']//field[@name='partner_bank_id']"

Original file line number	Diff line number	Diff line change
`@@ -5,7 +5,7 @@`
`5`	`5`	`from odoo import _, fields`
`6`	`6`	`from odoo.exceptions import UserError, ValidationError`
`7`	`7`	`from odoo.fields import Date`
`8`		`-from odoo.tests.common import Form, TransactionCase, tagged`
	`8`	`+from odoo.tests import Form, TransactionCase, tagged`
`9`	`9`
`10`	`10`	`from odoo.addons.base.tests.common import DISABLED_MAIL_CONTEXT`
`11`	`11`
`@@ -124,7 +124,7 @@ def setUpClass(cls):`
`124`	`124`	`.create(`
`125`	`125`	`{`
`126`	`126`	`"name": "Test customer",`
`127`		`- "customer_payment_mode_id": cls.customer_payment_mode,`
	`127`	`+ "customer_payment_mode_id": cls.customer_payment_mode.id,`
`128`	`128`	`}`
`129`	`129`	`)`
`130`	`130`	`)`
`@@ -135,7 +135,7 @@ def setUpClass(cls):`
`135`	`135`	`.create(`
`136`	`136`	`{`
`137`	`137`	`"name": "Test supplier",`
`138`		`- "supplier_payment_mode_id": cls.supplier_payment_mode,`
	`138`	`+ "supplier_payment_mode_id": cls.supplier_payment_mode.id,`
`139`	`139`	`}`
`140`	`140`	`)`
`141`	`141`	`)`
`@@ -152,14 +152,14 @@ def setUpClass(cls):`
`152`	`152`	`cls.invoice_account = cls.env["account.account"].search(`
`153`	`153`	`[`
`154`	`154`	`("account_type", "=", "liability_payable"),`
`155`		`- ("company_id", "=", cls.company.id),`
	`155`	`+ ("company_id", "in", cls.company.id),`
`156`	`156`	`],`
`157`	`157`	`limit=1,`
`158`	`158`	`)`
`159`	`159`	`cls.invoice_line_account = cls.env["account.account"].search(`
`160`	`160`	`[`
`161`	`161`	`("account_type", "=", "expense"),`
`162`		`- ("company_id", "=", cls.company.id),`
	`162`	`+ ("company_id", "in", cls.company.id),`
`163`	`163`	`],`
`164`	`164`	`limit=1,`
`165`	`165`	`)`
`@@ -227,7 +227,7 @@ def test_create_partner(self):`
`227`	`227`	`.create(`
`228`	`228`	`{`
`229`	`229`	`"name": "Test customer",`
`230`		`- "customer_payment_mode_id": self.customer_payment_mode,`
	`230`	`+ "customer_payment_mode_id": self.customer_payment_mode.id,`
`231`	`231`	`}`
`232`	`232`	`)`
`233`	`233`	`)`