First POC

Author: flotho

.flake8

@@ -0,0 +1,36 @@
+stages:
+  - git-robot
+  - check_repository_structure
+  - check_python_syntax
+
+git-rebase-branch:
+  stage: git-robot
+  script:
+    - echo 'Has to be improved to autoamtically rebase'
+    #- git clone git@gitlab.dev.mind-and-go.net:${CI_PROJECT_PATH}.git
+    #- cd ${CI_PROJECT_NAME}
+    #- git checkout ts
+    #- git rebase master
+    #- git push --force origin ts
+
+check_repository_minimum_files:
+  stage: check_repository_structure
+  script:
+    - echo "Checking minimal repository structure"
+    - echo 'Is .gitignore file preset and created FROM gitlab.dev.mind-and-go.net and use templates'
+    - test -e ./.gitignore
+    - echo 'Is a README.md file present? Precise whats going on there'
+    - test -e ./README.md
+    - echo 'Is a requirements.txt file present ? put inside the python libraries dependencies'
+    - test -e ./requirements.txt
+
+check_modules_structure:
+  stage: check_repository_structure
+  script:
+    - echo "Checking minimal module structure"
+
+pylint:
+  stage: check_python_syntax
+  script:
+    - echo "Running pylint on the project"
+    - pylint --load-plugins=pylint_odoo -d all -e odoolint ./*

.gitlab-ci.yml

@@ -5,24 +5,18 @@ exclude: |
   # Files and folders generated by bots, to avoid loops
   ^setup/|/static/description/index\.html$|
   # We don't want to mess with tool-generated files
-  .svg$|/tests/([^/]+/)?cassettes/|^.copier-answers.yml$|^.github/|^eslint.config.cjs|^prettier.config.cjs|
+  .svg$|/tests/([^/]+/)?cassettes/|^.copier-answers.yml$|^.github/|
   # Maybe reactivate this when all README files include prettier ignore tags?
   ^README\.md$|
   # Library files can have extraneous formatting (even minimized)
   /static/(src/)?lib/|
   # Repos using Sphinx to generate docs don't need prettying
   ^docs/_templates/.*\.html$|
-  # Don't bother non-technical authors with formatting issues in docs
-  readme/.*\.(rst|md)$|
-  # Ignore build and dist directories in addons
-  /build/|/dist/|
-  # Ignore test files in addons
-  /tests/samples/.*|
   # You don't usually want a bot to modify your legal texts
   (LICENSE.*|COPYING.*)
 default_language_version:
   python: python3
-  node: "22.9.0"
+  node: "14.13.0"
 repos:
   - repo: local
     hooks:
@@ -33,70 +27,49 @@ repos:
         entry: found forbidden files; remove them
         language: fail
         files: "\\.rej$"
-      - id: en-po-files
-        name: en.po files cannot exist
-        entry: found a en.po file
-        language: fail
-        files: '[a-zA-Z0-9_]*/i18n/en\.po$'
-  - repo: https://github.com/sbidoul/whool
-    rev: v1.2
-    hooks:
-      - id: whool-init
-  - repo: https://github.com/oca/maintainer-tools
-    rev: bf9ecb9938b6a5deca0ff3d870fbd3f33341fded
+  #- repo: https://github.com/oca/maintainer-tools
+  #rev: ab1d7f6
+  #hooks:
+  #update the NOT INSTALLABLE ADDONS section above
+  #- id: oca-update-pre-commit-excluded-addons
+  #- id: oca-fix-manifest-website
+  #args: ["https://github.com/OCA/project"]
+  - repo: https://github.com/myint/autoflake
+    rev: v1.4
     hooks:
-      # update the NOT INSTALLABLE ADDONS section above
-      - id: oca-update-pre-commit-excluded-addons
-      - id: oca-fix-manifest-website
-        args: ["https://github.com/OCA/connector-prestashop"]
-      - id: oca-gen-addon-readme
+      - id: autoflake
         args:
-          - --addons-dir=.
-          - --branch=18.0
-          - --org-name=OCA
-          - --repo-name=connector-prestashop
-          - --if-source-changed
-          - --keep-source-digest
-          - --convert-fragments-to-markdown
-      - id: oca-gen-external-dependencies
-  - repo: https://github.com/OCA/odoo-pre-commit-hooks
-    rev: v0.0.33
+          - --expand-star-imports
+          - --ignore-init-module-imports
+          - --in-place
+          - --remove-all-unused-imports
+          - --remove-duplicate-keys
+          - --remove-unused-variables
+  - repo: https://github.com/psf/black
+    rev: 20.8b1
     hooks:
-      - id: oca-checks-odoo-module
-      - id: oca-checks-po
-        args:
-          - --disable=po-pretty-format
-  - repo: local
+      - id: black
+  - repo: https://github.com/pre-commit/mirrors-prettier
+    rev: v2.1.2
     hooks:
       - id: prettier
         name: prettier (with plugin-xml)
-        entry: prettier
+        additional_dependencies:
+          - "prettier@2.1.2"
+          - "@prettier/plugin-xml@0.12.0"
         args:
-          - --write
-          - --list-different
-          - --ignore-unknown
-        types: [text]
+          - --plugin=@prettier/plugin-xml
         files: \.(css|htm|html|js|json|jsx|less|md|scss|toml|ts|xml|yaml|yml)$
-        language: node
-        additional_dependencies:
-          - "prettier@3.3.3"
-          - "@prettier/plugin-xml@3.4.1"
-  - repo: local
+  - repo: https://github.com/pre-commit/mirrors-eslint
+    rev: v7.8.1
     hooks:
       - id: eslint
-        name: eslint
-        entry: eslint
+        verbose: true
         args:
           - --color
           - --fix
-        verbose: true
-        types: [javascript]
-        language: node
-        additional_dependencies:
-          - "eslint@9.12.0"
-          - "eslint-plugin-jsdoc@50.3.1"
   - repo: https://github.com/pre-commit/pre-commit-hooks
-    rev: v4.6.0
+    rev: v3.2.0
     hooks:
       - id: trailing-whitespace
         # exclude autogenerated files
@@ -117,21 +90,37 @@ repos:
       - id: check-xml
       - id: mixed-line-ending
         args: ["--fix=lf"]
-  - repo: https://github.com/astral-sh/ruff-pre-commit
-    rev: v0.6.8
+  - repo: https://github.com/asottile/pyupgrade
+    rev: v2.7.2
+    hooks:
+      - id: pyupgrade
+        args: ["--keep-percent-format"]
+  - repo: https://github.com/PyCQA/isort
+    rev: 5.5.1
+    hooks:
+      - id: isort
+        name: isort except __init__.py
+        args:
+          - --settings=.
+        exclude: /__init__\.py$
+  - repo: https://gitlab.com/pycqa/flake8
+    rev: 3.9.2
     hooks:
-      - id: ruff
-        args: [--fix, --exit-non-zero-on-fix]
-      - id: ruff-format
-  - repo: https://github.com/OCA/pylint-odoo
-    rev: v9.1.3
+      - id: flake8
+        additional_dependencies: ["flake8-bugbear==21.9.2"]
+  - repo: https://github.com/PyCQA/pylint
+    rev: pylint-2.5.3
     hooks:
-      - id: pylint_odoo
+      - id: pylint
         name: pylint with optional checks
         args:
           - --rcfile=.pylintrc
           - --exit-zero
         verbose: true
-      - id: pylint_odoo
+        additional_dependencies: &pylint_deps
+          - pylint-odoo==3.5.0
+      - id: pylint
+        name: pylint with mandatory checks
         args:
           - --rcfile=.pylintrc-mandatory
+        additional_dependencies: *pylint_deps

.pre-commit-config.yaml

@@ -1,16 +1,14 @@
-
-
 [MASTER]
 load-plugins=pylint_odoo
 score=n
 
 [ODOOLINT]
-readme-template-url="https://github.com/OCA/maintainer-tools/blob/master/template/module/README.rst"
-manifest-required-authors=Odoo Community Association (OCA)
-manifest-required-keys=license
-manifest-deprecated-keys=description,active
-license-allowed=AGPL-3,GPL-2,GPL-2 or any later version,GPL-3,GPL-3 or any later version,LGPL-3
-valid-odoo-versions=18.0
+readme_template_url="https://github.com/OCA/maintainer-tools/blob/master/template/module/README.rst"
+manifest_required_authors=Mind And Go,Mind And Go (M&Go),M&Go
+manifest_required_keys=license
+manifest_deprecated_keys=description,active
+license_allowed=AGPL-3,GPL-2,GPL-2 or any later version,GPL-3,GPL-3 or any later version,LGPL-3
+valid_odoo_versions=10.0
 
 [MESSAGES CONTROL]
 disable=all
@@ -66,39 +64,6 @@ enable=anomalous-backslash-in-string,
     use-vim-comment,
     wrong-tabs-instead-of-spaces,
     xml-syntax-error,
-    attribute-string-redundant,
-    character-not-valid-in-resource-link,
-    consider-merging-classes-inherited,
-    context-overridden,
-    create-user-wo-reset-password,
-    dangerous-filter-wo-user,
-    dangerous-qweb-replace-wo-priority,
-    deprecated-data-xml-node,
-    deprecated-openerp-xml-node,
-    duplicate-po-message-definition,
-    except-pass,
-    file-not-used,
-    invalid-commit,
-    manifest-maintainers-list,
-    missing-newline-extrafiles,
-    missing-readme,
-    missing-return,
-    odoo-addons-relative-import,
-    old-api7-method-defined,
-    po-msgstr-variables,
-    po-syntax-error,
-    renamed-field-parameter,
-    resource-not-exist,
-    str-format-used,
-    test-folder-imported,
-    translation-contains-variable,
-    translation-positional-used,
-    unnecessary-utf8-coding-comment,
-    website-manifest-key-not-valid-uri,
-    xml-attribute-translatable,
-    xml-deprecated-qweb-directive,
-    xml-deprecated-tree-attribute,
-    external-request-timeout,
     # messages that do not cause the lint step to fail
     consider-merging-classes-inherited,
     create-user-wo-reset-password,

.pylintrc

@@ -1,15 +1,14 @@
-
 [MASTER]
 load-plugins=pylint_odoo
 score=n
 
 [ODOOLINT]
-readme-template-url="https://github.com/OCA/maintainer-tools/blob/master/template/module/README.rst"
-manifest-required-authors=Odoo Community Association (OCA)
-manifest-required-keys=license
-manifest-deprecated-keys=description,active
-license-allowed=AGPL-3,GPL-2,GPL-2 or any later version,GPL-3,GPL-3 or any later version,LGPL-3
-valid-odoo-versions=18.0
+readme_template_url="https://github.com/OCA/maintainer-tools/blob/master/template/module/README.rst"
+manifest_required_authors=Mind And Go,Mind And Go (M&Go),M&Go
+manifest_required_keys=license
+manifest_deprecated_keys=description,active
+license_allowed=AGPL-3,GPL-2,GPL-2 or any later version,GPL-3,GPL-3 or any later version,LGPL-3
+valid_odoo_versions=10.0
 
 [MESSAGES CONTROL]
 disable=all
@@ -57,40 +56,7 @@ enable=anomalous-backslash-in-string,
     unreachable,
     use-vim-comment,
     wrong-tabs-instead-of-spaces,
-    xml-syntax-error,
-    attribute-string-redundant,
-    character-not-valid-in-resource-link,
-    consider-merging-classes-inherited,
-    context-overridden,
-    create-user-wo-reset-password,
-    dangerous-filter-wo-user,
-    dangerous-qweb-replace-wo-priority,
-    deprecated-data-xml-node,
-    deprecated-openerp-xml-node,
-    duplicate-po-message-definition,
-    except-pass,
-    file-not-used,
-    invalid-commit,
-    manifest-maintainers-list,
-    missing-newline-extrafiles,
-    missing-readme,
-    missing-return,
-    odoo-addons-relative-import,
-    old-api7-method-defined,
-    po-msgstr-variables,
-    po-syntax-error,
-    renamed-field-parameter,
-    resource-not-exist,
-    str-format-used,
-    test-folder-imported,
-    translation-contains-variable,
-    translation-positional-used,
-    unnecessary-utf8-coding-comment,
-    website-manifest-key-not-valid-uri,
-    xml-attribute-translatable,
-    xml-deprecated-qweb-directive,
-    xml-deprecated-tree-attribute,
-    external-request-timeout
+    xml-syntax-error
 
 [REPORTS]
 msg-template={path}:{line}: [{msg_id}({symbol}), {obj}] {msg}

.pylintrc-mandatory

@@ -12,7 +12,7 @@
         "account",
         "base_vat",  # for vat validation on partner address
         "product_multi_category",  # oca/product-attribute
-        "product_multi_image",  # oca/product-attribute
+        # "product_multi_image",  # oca/product-attribute #TODO
         "connector_ecommerce",  # oca/connector-ecommerce
         "purchase",
     ],
@@ -47,7 +47,8 @@
         "views/account_tax_group_views.xml",
         "views/prestashop_address_views.xml",
         "views/prestashop_backend_views.xml",
-        "views/connector_prestashop_menu.xml",
+        "views/prestashop_shop_group_views.xml",
+        "views/prestashop_shop_views.xml",
         "views/prestahop_sale_order_views.xml",
         "views/prestashop_account_tax_group_views.xml",
         "views/prestashop_delivery_carrier_views.xml",
@@ -58,8 +59,6 @@
         "views/prestashop_res_partner_category_views.xml",
         "views/prestashop_res_partner_views.xml",
         "views/prestashop_sale_order_state_views.xml",
-        "views/prestashop_shop_group_views.xml",
-        "views/prestashop_shop_views.xml",
         "views/product_category_views.xml",
         "views/product_product_views.xml",
         "views/product_template_views.xml",
@@ -70,6 +69,7 @@
         "views/sale_order_views.xml",
         "views/stock_location_views.xml",
         "views/stock_warehouse_views.xml",
+        "views/connector_prestashop_menu.xml",
     ],
     "application": True,
 }

connector_prestashop/__manifest__.py

@@ -3,7 +3,6 @@
 import logging
 
 from odoo import _, exceptions
-
 from odoo.addons.component.core import Component
 
 _logger = logging.getLogger(__name__)