[MIG] delivery_carrier_deposit: Migration to 17.0

Author: BhaveshHeliconia

delivery_carrier_deposit/README.rst

@@ -30,6 +30,7 @@ Contributors
 * Alexis de Lattre <alexis.delattre@akretion.com>
 * Raphael Reverdy <raphael.reverdy@akretion.com>
 * MonsieurB <monsieurb@saaslys.com>
+* Heliconia Solutions Pvt. Ltd. <https://www.heliconia.io>
 
 Maintainer
 ----------

delivery_carrier_deposit/__manifest__.py

@@ -3,13 +3,13 @@
 
 {
     "name": "Delivery Deposit",
-    "version": "16.0.1.0.0",
+    "version": "17.0.1.0.0",
     "category": "Delivery",
     "author": "Akretion,Odoo Community Association (OCA)",
     "maintainer": "Akretion",
     "summary": "Create deposit slips",
     "depends": [
-        "delivery",
+        "stock_delivery",
     ],
     "website": "https://github.com/OCA/delivery-carrier",
     "data": [

delivery_carrier_deposit/models/deposit_slip.py

@@ -25,9 +25,7 @@ def _compute_weight_and_packages(self):
             deposit.weight = weight
             deposit.package_number = len(packages)
 
-    name = fields.Char(
-        readonly=True, states={"draft": [("readonly", False)]}, default="/", copy=False
-    )
+    name = fields.Char(default="/", copy=False)
     delivery_type = fields.Selection(
         selection=lambda self: self.env["delivery.carrier"]
         ._fields["delivery_type"]
@@ -37,8 +35,6 @@ def _compute_weight_and_packages(self):
         comodel_name="stock.picking",
         inverse_name="deposit_slip_id",
         string="Pickings",
-        readonly=True,
-        states={"draft": [("readonly", False)]},
     )
     state = fields.Selection(
         selection=[

delivery_carrier_deposit/report/report.xml

@@ -8,7 +8,6 @@
       <field
             name="report_name"
         >delivery_carrier_deposit.report_generic_deposit_slip</field>
-          <!--  <field name="report_file">auth_token.report.label_res_users</field>-->
       <field name="print_report_name">object.name + '_delivery_slip.pdf'</field>
       <field
             name="binding_model_id"

delivery_carrier_deposit/tests/models.py

@@ -1,44 +1,23 @@
 # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
 
-from odoo_test_helper import FakeModelLoader
+from odoo.addons.base.tests.common import BaseCommon
 
-from odoo.tests.common import TransactionCase
 
-
-class TestDepositSlip(TransactionCase):
+class TestDepositSlip(BaseCommon):
     @classmethod
     def setUpClass(cls):
         super().setUpClass()
-        cls.loader = FakeModelLoader(cls.env, cls.__module__)
-        cls.loader.backup_registry()
-
-        # The fake class is imported here !! After the backup_registry
-        from .models import FakeDeliveryCarrier
 
-        cls.loader.update_registry((FakeDeliveryCarrier,))
-
-        delivery_free_product = cls.env.ref("delivery.product_product_delivery")
-        cls.carrier = cls.env["delivery.carrier"].create(
-            {
-                "name": "Test Carrier",
-                "delivery_type": "test",
-                "product_id": delivery_free_product.id,
-            }
-        )
+        carrier_id = cls.env.ref("delivery.free_delivery_carrier")
         cls.delivery_order = cls.env.ref("stock.outgoing_shipment_main_warehouse4")
-        cls.delivery_order.write({"carrier_id": cls.carrier.id})
-
-    @classmethod
-    def tearDownClass(cls):
-        cls.loader.restore_registry()
-        super().tearDownClass()
+        cls.delivery_order.write({"carrier_id": carrier_id.id})
 
     def test_delivery_slip_creation(self):
-        self.delivery_order.move_line_ids.qty_done = 16
-        self.delivery_order._action_done()
+        self.delivery_order.move_line_ids.quantity = 16
+        self.delivery_order.button_validate()
         wizard = self.env["delivery.deposit.wizard"].create(
             {
-                "delivery_type": "test",
+                "delivery_type": "fixed",
             }
         )
         wizard.create_deposit_slip()

delivery_carrier_deposit/tests/test_deposit_slip.py

@@ -67,15 +67,15 @@
                         name="validate_deposit"
                         string="Confirm"
                         type="object"
-                        attrs="{'invisible' : ['|', ('state','!=','draft'), ('delivery_type', '=', False)]}"
+                        invisible="state != 'draft' or not delivery_type"
                         class="oe_highlight"
                     />
                 <button
                         name="create_edi_file"
                         string="Re-generate EDI file"
                         type="object"
                         confirm="Are you sure that you re-generate the EDI file ?"
-                        attrs="{'invisible': True}"
+                        invisible="1"
                     />
                 <field
                         name="state"
@@ -86,7 +86,7 @@
             </header>
             <sheet>
                 <group name="main" col="4">
-                    <field name="name" />
+                    <field name="name" readonly="state != 'draft'" />
                     <field name="weight" />
                     <field name="package_number" />
                     <field name="delivery_type" />
@@ -98,6 +98,7 @@
                             colspan="2"
                             widget="many2many"
                             options="{'not_delete': True, 'no_create': True}"
+                            readonly="state != 'draft'"
                         >
                         <tree>
                             <field name="name" />
@@ -106,7 +107,7 @@
                             <field name="origin" />
                             <field name="backorder_id" />
                             <field name="date_done" />
-                            <field name="state" invisible="1" />
+                            <field name="state" column_invisible="1" />
                         </tree>
                     </field>
                 </group>

delivery_carrier_deposit/views/deposit_slip_view.xml

@@ -3,12 +3,13 @@
 
 <record id="view_picking_withcarrier_out_form" model="ir.ui.view">
     <field name="model">stock.picking</field>
-    <field name="inherit_id" ref="delivery.view_picking_withcarrier_out_form" />
+    <field name="inherit_id" ref="stock_delivery.view_picking_withcarrier_out_form" />
     <field name="arch" type="xml">
         <field name="carrier_id" position="after">
             <field
                     name="deposit_slip_id"
-                    attrs="{'readonly': True,'invisible': [('deposit_slip_id', '=', False)]}"
+                    readonly="1"
+                    invisible="not deposit_slip_id"
                 />
         </field>
     </field>