[MIG] edi_voxel_sale_order_import_oca: Migration to 18.0

TT54159

Author: juancarlosonate-tecnativa

edi_voxel_sale_order_import_oca/README.rst

@@ -60,7 +60,7 @@ Note:
 
 This module enqueue the imports in jobs in the background. To do that it
 uses queue_job module, so a configuration is required according to that.
-The jobs for impots are queued in the channel ``root.voxel_import``.
+The jobs for imports are queued in the channel ``root.voxel_import``.
 
 Usage
 =====
@@ -98,6 +98,7 @@ Contributors
   - Ernesto Tejeda
   - Pedro M. Baeza
   - Sergio Teruel
+  - Juan Carlos Oñate
 
 Maintainers
 -----------

edi_voxel_sale_order_import_oca/__manifest__.py

@@ -4,7 +4,7 @@
 {
     "name": "Voxel sale order oca",
     "summary": "Import sale order from Voxel.",
-    "version": "15.0.1.0.1",
+    "version": "18.0.1.0.0",
     "category": "Sale",
     "author": "Tecnativa, Odoo Community Association (OCA)",
     "website": "https://github.com/OCA/edi",

edi_voxel_sale_order_import_oca/data/ir_cron_data.xml

@@ -10,7 +10,5 @@
         <field name="user_id" ref="base.user_root" />
         <field name="interval_number">10</field>
         <field name="interval_type">minutes</field>
-        <field name="numbercall">-1</field>
-        <field eval="False" name="doall" />
     </record>
 </odoo>

edi_voxel_sale_order_import_oca/models/sale_order.py

@@ -7,7 +7,7 @@
 
 from lxml import etree
 
-from odoo import _, api, fields, models
+from odoo import api, fields, models
 from odoo.exceptions import UserError
 from odoo.osv import expression
 
@@ -53,18 +53,17 @@ def create_document_from_xml(self, xml_content, voxel_filename, company):
             xml_content, voxel_filename, error_msgs, company
         )
         # Add internal note to the created sale order
-        create_msg = _("Created automatically via voxel import (%s).") % voxel_filename
+        create_msg = (
+            self.env._("Created automatically via voxel import (%s).") % voxel_filename
+        )
         if error_msgs:
             str_error_msgs = ""
             for error_msg in error_msgs:
-                str_error_msgs += "<li>%s</li>" % error_msg
-            create_msg += (
-                _(
-                    "<br/><span style='font-weight: bold;'>"
-                    "The following errors were found:</span><br/>"
-                    "<ul>%s</ul>"
-                )
-                % str_error_msgs
+                str_error_msgs += f"<li>{error_msg}</li>"
+            create_msg += self.env._(
+                "<br/><span style='font-weight: bold;'>"
+                "The following errors were found:</span><br/>"
+                f"<ul>{str_error_msgs}</ul>"
             )
         order.message_post(body=create_msg)
         return order
@@ -77,15 +76,20 @@ def _parse_voxel_order(self, order_file, order_filename, error_msgs, company):
             try:
                 xml_root = etree.fromstring(order_file)
             except Exception as exc:
-                raise UserError(_("This XML file is not XML-compliant")) from exc
+                raise UserError(
+                    self.env._("This XML file is not XML-compliant")
+                ) from exc
         else:
-            raise UserError(_("'%s' is not recognised as an XML file") % order_filename)
-        _logger.debug("Starting to import:%s" % (order_filename))
+            raise UserError(
+                self.env._(f"'{order_filename}' is not recognised as an XML file")
+            )
+        _logger.debug(f"Starting to import:{order_filename}")
         try:
             return self._parse_xml_order(xml_root, error_msgs, company)
         except Exception as exc:
             raise UserError(
-                _("Error creating the order") + f"\n\nFile contents:\n{order_file}"
+                self.env._("Error creating the order")
+                + f"\n\nFile contents:\n{order_file}"
             ) from exc
 
     def _parse_xml_order(self, xml_root, error_msgs, company):
@@ -150,13 +154,12 @@ def _parse_supplier_data_voxel(self, vals, xml_root, error_msgs):
                 # Add error message to error_msgs list
                 msg_fields = self._get_voxel_msg_fields("res.partner", partner_data)
                 error_msgs.append(
-                    _(
+                    self.env._(
                         "Couldn't find any <b>Company</b> corresponding to "
                         "the following information extracted from the Voxel "
                         "document:<br/>"
-                        "<ul>%s</ul>"
+                        f"<ul>{msg_fields}</ul>"
                     )
-                    % (msg_fields)
                 )
 
     def _parse_client_data_voxel(self, vals, xml_root, error_msgs):
@@ -199,13 +202,12 @@ def _parse_customers_data_voxel(self, vals, xml_root, error_msgs):
                 # Add error message to error_msgs list
                 msg_fields = self._get_voxel_msg_fields("res.partner", partner_data)
                 error_msgs.append(
-                    _(
+                    self.env._(
                         "Couldn't find any <b>Delivery Address</b> "
                         "corresponding to the following information extracted "
                         "from the Voxel document:<br/>"
-                        "<ul>%s</ul>"
+                        f"<ul>{msg_fields}</ul>"
                     )
-                    % (msg_fields)
                 )
 
     def _parse_partner_data_voxel(self, data, raise_error=True):
@@ -236,7 +238,7 @@ def _parse_partner_data_voxel(self, data, raise_error=True):
             return partner  # return the unique partner matching
         if raise_error:
             raise UserError(
-                _(
+                self.env._(
                     "Can't find a suitable partner for this data:\n\n%(data)s"
                     "\nResults: %(partner_count)s",
                     data=data,
@@ -283,13 +285,16 @@ def _parse_product_voxel(self, line_vals, line_element):
                     self.env["sale.order"].browse(line_vals["order_id"]).partner_id
                 )
                 customerinfo = self.env["product.customerinfo"].search(
-                    [("name", "=", partner.id), ("product_code", "=", supplier_sku)],
+                    [
+                        ("partner_id", "=", partner.id),
+                        ("product_code", "=", supplier_sku),
+                    ],
                     limit=1,
                 )
                 if not customerinfo:
                     customerinfo = self.env["product.customerinfo"].search(
                         [
-                            ("name", "=", partner.commercial_partner_id.id),
+                            ("partner_id", "=", partner.commercial_partner_id.id),
                             ("product_code", "=", supplier_sku),
                         ],
                         limit=1,
@@ -306,11 +311,9 @@ def _parse_product_voxel(self, line_vals, line_element):
                 product = self.env["product.product"].search(domain)
         if len(product) != 1:
             raise UserError(
-                _(
-                    "Can't find a suitable product for this data:\n\n%(product_data)s"
-                    "\nResults: %(product_count)s",
-                    product_data=product_data,
-                    product_count=len(product),
+                self.env._(
+                    f"Can't find a suitable product for this data:\n\n{product_data}"
+                    f"\nResults: {len(product)}",
                 )
             )
         line_vals.update(product_id=product.id)
@@ -322,11 +325,10 @@ def _parse_qty_uom_voxel(self, line_vals, line_element):
         product_uom = self.env["uom.uom"].search([("voxel_code", "=", mu)])
         if len(product_uom) != 1:
             raise UserError(
-                _(
-                    "Can't find a suitable Unit of Measure for this data:\n\n%(product_data)s"
-                    "\nResults: %(product_uom_count)s",
-                    product_data=product_data,
-                    product_uom_count=len(product_uom),
+                self.env._(
+                    "Can't find a suitable Unit of Measure for this data:"
+                    f"\n\n{product_data}"
+                    f"\nResults: {len(product_uom)}"
                 )
             )
         line_vals.update(product_uom_qty=qty, product_uom=product_uom.id)
@@ -360,13 +362,12 @@ def _parse_taxes_product_voxel(self, line_vals, line_element, error_msgs):
                 tax_data = {"voxel_tax_code": voxel_tax_code, "amount": amount}
                 msg_fields = self._get_voxel_msg_fields("account.tax", tax_data)
                 error_msgs.append(
-                    _(
+                    self.env._(
                         "Couldn't find any <b>Tax</b> corresponding to "
                         "the following information extracted from the Voxel "
                         "document:<br/>"
-                        "<ul>%s</ul>"
+                        f"<ul>{msg_fields}</ul>"
                     )
-                    % (msg_fields)
                 )
 
     def _get_partner_data_voxel(self, data):

edi_voxel_sale_order_import_oca/readme/CONFIGURE.md

@@ -19,4 +19,4 @@ Note:
 
 This module enqueue the imports in jobs in the background. To do that it
 uses queue_job module, so a configuration is required according to that.
-The jobs for impots are queued in the channel `root.voxel_import`.
+The jobs for imports are queued in the channel `root.voxel_import`.

edi_voxel_sale_order_import_oca/readme/CONTRIBUTORS.md

@@ -2,3 +2,4 @@
   - Ernesto Tejeda
   - Pedro M. Baeza
   - Sergio Teruel
+  - Juan Carlos Oñate

edi_voxel_sale_order_import_oca/static/description/index.html

@@ -408,7 +408,7 @@ <h1><a class="toc-backref" href="#toc-entry-1">Configuration</a></h1>
 <p>Note:</p>
 <p>This module enqueue the imports in jobs in the background. To do that it
 uses queue_job module, so a configuration is required according to that.
-The jobs for impots are queued in the channel <tt class="docutils literal">root.voxel_import</tt>.</p>
+The jobs for imports are queued in the channel <tt class="docutils literal">root.voxel_import</tt>.</p>
 </div>
 <div class="section" id="usage">
 <h1><a class="toc-backref" href="#toc-entry-2">Usage</a></h1>
@@ -441,6 +441,7 @@ <h2><a class="toc-backref" href="#toc-entry-6">Contributors</a></h2>
 <li>Ernesto Tejeda</li>
 <li>Pedro M. Baeza</li>
 <li>Sergio Teruel</li>
+<li>Juan Carlos Oñate</li>
 </ul>
 </li>
 </ul>

edi_voxel_sale_order_import_oca/tests/test_voxel_sale_order_import.py

@@ -5,10 +5,11 @@
 from datetime import date, datetime
 
 from odoo.modules.module import get_module_path
-from odoo.tests.common import TransactionCase
 
+from odoo.addons.base.tests.common import BaseCommon
 
-class TestVoxelSaleOrderImportCommon(TransactionCase):
+
+class TestVoxelSaleOrderImportCommon(BaseCommon):
     @classmethod
     def setUpClass(cls):
         super().setUpClass()
@@ -33,7 +34,7 @@ def setUpClass(cls):
         )
         cls.supplierinfo_product_test_1 = cls.env["product.customerinfo"].create(
             {
-                "name": cls.customer_test.id,
+                "partner_id": cls.customer_test.id,
                 "product_tmpl_id": cls.product_test_1.product_tmpl_id.id,
                 "product_id": cls.product_test_1.id,
                 "product_code": "SP11111",

edi_voxel_sale_order_import_oca/views/res_config_settings_views.xml

@@ -6,18 +6,17 @@
         <field name="name">res.config.settings.view.form.voxel.invoice</field>
         <field name="model">res.config.settings</field>
         <field name="inherit_id" ref="edi_voxel_oca.res_config_settings_view_form" />
-        <field
-            name="groups_id"
-            eval="[(4, ref('edi_voxel_oca.group_voxel_manager'))]"
-        />
         <field name="arch" type="xml">
             <xpath expr="//div[@name='voxel_login_config']" position="inside">
                 <div class="row mt16">
                     <label
                         for="voxel_sale_order_login_id"
                         class="col-lg-3 o_light_label"
                     />
-                    <field name="voxel_sale_order_login_id" />
+                    <field
+                        name="voxel_sale_order_login_id"
+                        groups="edi_voxel_oca.group_voxel_manager"
+                    />
                 </div>
             </xpath>
         </field>

edi_voxel_sale_order_import_oca/views/sale_order_views.xml

@@ -6,16 +6,13 @@
         <field name="name">sale.order.view.form</field>
         <field name="model">sale.order</field>
         <field name="inherit_id" ref="sale.view_order_form" />
-        <field
-            name="groups_id"
-            eval="[(4, ref('edi_voxel_oca.group_voxel_manager'))]"
-        />
         <field name="arch" type="xml">
             <notebook>
                 <page
                     string="Voxel"
                     name="page_voxel"
-                    attrs="{'invisible': [('voxel_xml_report', '=', False)]}"
+                    invisible="not voxel_xml_report"
+                    groups="edi_voxel_oca.group_voxel_manager"
                 >
                     <group name="group_voxel">
                         <group>