[MIG] hr_holidays_auto_extend: Migration to 18.0

Author: BhaveshHeliconia

hr_holidays_auto_extend/README.rst

@@ -71,7 +71,9 @@ Contributors
 ------------
 
 - Enric Tobella
-- 
+- `Heliconia Solutions Pvt. Ltd. <https://www.heliconia.io>`__
+
+  - Bhavesh Heliconia
 
 Maintainers
 -----------

hr_holidays_auto_extend/__manifest__.py

@@ -5,7 +5,7 @@
     "name": "Hr Holidays Auto Extend",
     "summary": """
         Allow to extend some kind of holidays""",
-    "version": "16.0.1.0.0",
+    "version": "18.0.1.0.0",
     "license": "AGPL-3",
     "author": "CreuBlanca,Odoo Community Association (OCA)",
     "website": "https://github.com/OCA/hr-holidays",

hr_holidays_auto_extend/data/cron.xml

@@ -5,7 +5,6 @@
         <field name="user_id" ref="base.user_root" />
         <field name="interval_number">1</field>
         <field name="interval_type">days</field>
-        <field name="numbercall">-1</field>
         <field name="model_id" ref="model_hr_leave" />
         <field name="state">code</field>
         <field name="code">model._cron_auto_extend()</field>

hr_holidays_auto_extend/models/hr_leave.py

@@ -69,11 +69,12 @@ def _cron_auto_extend(self):
                 )
                 continue
             vals = {"request_date_to": request_date_to}
-            vals.update(
-                leave.onchange(vals, ["request_date_to"], leave._onchange_spec())[
-                    "value"
-                ]
-            )
+            fields_spec = {}
+            result = leave.onchange(vals, ["request_date_to"], fields_spec)
+
+            if result and "value" in result:
+                vals.update(result["value"])
+
             leave.write(vals)
             leave._remove_resource_leave()
             leave._create_resource_leave()

hr_holidays_auto_extend/readme/CONTRIBUTORS.md

@@ -1,2 +1,4 @@
 - Enric Tobella
-- 
+- [Heliconia Solutions Pvt. Ltd.](https://www.heliconia.io)
+  - Bhavesh Heliconia
+

hr_holidays_auto_extend/static/description/index.html

@@ -418,7 +418,10 @@ <h2><a class="toc-backref" href="#toc-entry-4">Authors</a></h2>
 <h2><a class="toc-backref" href="#toc-entry-5">Contributors</a></h2>
 <ul class="simple">
 <li>Enric Tobella</li>
-<li></li>
+<li><a class="reference external" href="https://www.heliconia.io">Heliconia Solutions Pvt. Ltd.</a><ul>
+<li>Bhavesh Heliconia</li>
+</ul>
+</li>
 </ul>
 </div>
 <div class="section" id="maintainers">

hr_holidays_auto_extend/tests/test_extend.py

@@ -4,7 +4,7 @@
 from datetime import timedelta
 
 from odoo import fields
-from odoo.tests.common import Form
+from odoo.tests import Form
 
 from odoo.addons.hr_holidays.tests.common import TestHrHolidaysCommon
 
@@ -15,6 +15,7 @@ def test_time_type(self):
             {
                 "name": "Paid Time Off",
                 "time_type": "leave",
+                "requires_allocation": "no",
                 "auto_extend": True,
             }
         )
@@ -50,12 +51,14 @@ def test_extend_overlap(self):
             {
                 "name": "Paid Time Off",
                 "time_type": "leave",
+                "requires_allocation": "no",
                 "auto_extend": True,
             }
         )
         leave_type_02 = self.env["hr.leave.type"].create(
             {
                 "name": "Another leave type",
+                "requires_allocation": "no",
                 "time_type": "leave",
             }
         )
@@ -102,6 +105,7 @@ def test_check_date_state(self):
             {
                 "name": "Paid Time Off",
                 "time_type": "leave",
+                "requires_allocation": "no",
                 "auto_extend": True,
             }
         )

hr_holidays_auto_extend/views/hr_leave.xml

@@ -13,12 +13,12 @@
                     name="auto_extend"
                     groups="hr_holidays.group_hr_holidays_user"
                     widget="boolean_toggle"
-                    attrs="{'invisible':[('auto_extend_type', '=', False), ('auto_extend', '=', False)]}"
+                    invisible="not auto_extend_type and not auto_extend"
                 />
                 <field
                     name="auto_extend_period"
                     groups="hr_holidays.group_hr_holidays_user"
-                    attrs="{'invisible':[('auto_extend', '=', False)]}"
+                    invisible="not auto_extend"
                 />
             </field>
         </field>

hr_holidays_auto_extend/views/hr_leave_type.xml

@@ -9,10 +9,7 @@
         <field name="arch" type="xml">
             <field name="request_unit" position="after">
                 <field name="auto_extend" widget="boolean_toggle" />
-                <field
-                    name="auto_extend_period"
-                    attrs="{'invisible':[('auto_extend', '=', False)]}"
-                />
+                <field name="auto_extend_period" invisible="not auto_extend" />
             </field>
         </field>
     </record>