[IMP] hr_holidays_leave_report_calendar_type: implement compute and search methods to allow filtering by calendar type

Author: cgarcia-solvos

hr_holidays_leave_report_calendar_type/__init__.py

@@ -1,2 +1 @@
-# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
 from . import models

hr_holidays_leave_report_calendar_type/models/hr_leave_report_calendar.py

@@ -1,43 +1,26 @@
 # Copyright 2026 Solvos Consultoría Informática, S.L. (<https://www.solvos.es>)
 # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
 
-from psycopg2 import sql
-
-from odoo import fields, models, tools
+from odoo import fields, models
 
 
 class LeaveReportCalendar(models.Model):
     _inherit = "hr.leave.report.calendar"
 
     holiday_status_id = fields.Many2one(
         "hr.leave.type",
-        readonly=True,
         string="Time Off Type",
+        compute="_compute_holiday_status_id",
+        search="_search_holiday_status_id",
         groups="hr_holidays.group_hr_holidays_user",
     )
 
-    def init(self):
-        res = super().init()
-
-        self._cr.execute(
-            """
-            SELECT view_definition
-            FROM information_schema.views
-            WHERE table_name = 'hr_leave_report_calendar'
-            """
-        )
-        view_def = self._cr.fetchone()[0]
-
-        if "holiday_status_id" not in view_def:
-            view_def = view_def.replace(
-                "is_hatched", "is_hatched, hl.holiday_status_id AS holiday_status_id"
-            )
-
-            tools.drop_view_if_exists(self._cr, "hr_leave_report_calendar")
-
-            query = sql.SQL(
-                "CREATE OR REPLACE VIEW hr_leave_report_calendar AS {}"
-            ).format(sql.SQL(view_def))
-            self._cr.execute(query)
+    def _compute_holiday_status_id(self):
+        leaves = self.env["hr.leave"].browse(self.ids)
+        leave_status_dict = {leave.id: leave.holiday_status_id for leave in leaves}
+        for record in self:
+            record.holiday_status_id = leave_status_dict.get(record.id, False)
 
-        return res
+    def _search_holiday_status_id(self, operator, value):
+        leaves = self.env["hr.leave"].search([("holiday_status_id", operator, value)])
+        return [("id", "in", leaves.ids)]

hr_holidays_leave_report_calendar_type/tests/test_hr_holidays_leave_report_calendar_type.py

@@ -1,6 +1,7 @@
 # Copyright 2026 Solvos Consultoría Informática, S.L. (<https://www.solvos.es>)
 # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
 
+
 from odoo.tests.common import TransactionCase, tagged
 
 
@@ -40,23 +41,20 @@ def test_field_exists(self):
         self.assertIn(
             "holiday_status_id",
             self.env["hr.leave.report.calendar"]._fields,
-            "holiday_status_id field dont exists.",
+            "The 'holiday_status_id' field is not found in the Odoo model.",
         )
 
-    def test_sql_view_column_exists(self):
-        self.env.cr.execute(
-            """
-            SELECT column_name
-            FROM information_schema.columns
-            WHERE table_name = 'hr_leave_report_calendar';
-        """
-        )
-        result = self.env.cr.fetchall()
+    def test_field_assigned_properly(self):
+        calendar_record = self.env["hr.leave.report.calendar"].browse(self.leave.id)
 
-        column_names = [row[0] for row in result]
+        self.assertEqual(
+            calendar_record.holiday_status_id,
+            self.leave.holiday_status_id,
+            "The holiday_status_id is not properly assigned in the calendar report.",
+        )
 
-        self.assertIn(
-            "holiday_status_id",
-            column_names,
-            "The init() method failed or did not add the holiday_status_id column.",
+    def test_search_holiday_status_id(self):
+        calendars = self.env["hr.leave.report.calendar"].search(
+            [("holiday_status_id", "=", self.leave_type.id)]
         )
+        self.assertIn(self.leave.id, calendars.ids)