[FIX] intrastat_base: Fix tests

Author: victoralmau

intrastat_base/tests/__init__.py

@@ -1,2 +1 @@
-from . import common
 from . import test_all

intrastat_base/tests/common.py

@@ -1,24 +1,31 @@
 # Copyright 2021 ACSONE SA/NV
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
 
+from odoo.tests import new_test_user
 
-class IntrastatCommon:
+from odoo.addons.base.tests.common import BaseCommon
+
+
+class IntrastatCommon(BaseCommon):
     @classmethod
     def setUpClass(cls):
         super().setUpClass()
-        cls.env = cls.env(context=dict(cls.env.context, tracking_disable=True))
         cls.chart_template_obj = cls.env["account.chart.template"]
         cls.mail_obj = cls.env["mail.mail"]
 
-        cls.demo_user = cls.env.ref("base.user_demo")
-        cls.demo_company = cls.env.ref("base.main_company")
+        cls.demo_user = new_test_user(
+            cls.env,
+            login="test-user",
+            email="test@test.com",
+        )
+        cls.demo_company = cls.company
 
         cls.shipping_cost = cls.env["product.product"].create(
             {
                 "name": "Shipping costs TEST",
                 "default_code": "TEST_SHIP",
                 "type": "service",
                 "is_accessory_cost": True,
-                "categ_id": cls.env.ref("product.product_category_services"),
+                "categ_id": cls.env.ref("product.product_category_services").id,
             }
         )

intrastat_base/tests/test_all.py

@@ -47,10 +47,6 @@ def test_get_data(self, template_code):
 class TestIntrastatBase(IntrastatCommon):
     """Tests for this module"""
 
-    @classmethod
-    def setUpClass(cls):
-        super().setUpClass()
-
     def test_company(self):
         # add 'Demo user' to intrastat_remind_user_ids
         self.demo_company.write(
@@ -69,6 +65,7 @@ def test_no_email(self):
     def test_accessory(self):
         with self.assertRaises(ValidationError):
             self.shipping_cost.type = "consu"
+            self.shipping_cost.is_accessory_cost = True
 
     def test_fiscal_position(self):
         with self.assertRaises(ValidationError):