[FIX]l10n_it_riba_oca fix add riba cost issue #5063

Author: mmircoli-nexapp

l10n_it_riba_oca/models/account.py

@@ -185,32 +185,6 @@ def month_check(self, invoice_date_due, all_date_due):
         return False
 
     def _post(self, soft=True):
-        inv_riba_no_bank = self.filtered(
-            lambda x: x.is_riba_payment
-            and x.move_type == "out_invoice"
-            and not x.riba_partner_bank_id
-        )
-        if inv_riba_no_bank:
-            inv_details = (
-                self.env._(
-                    'Invoice %(name)s for customer "%(customer_name)s", '
-                    "total %(amount)s",
-                    name=inv.display_name,
-                    customer_name=inv.partner_id.display_name,
-                    amount=inv.amount_total,
-                )
-                for inv in inv_riba_no_bank
-            )
-            raise UserError(
-                self.env._(
-                    "Cannot post invoices with C/O payments without bank. "
-                    "Please check the following invoices:\n\n- "
-                    + "\n- ".join(inv_details)
-                )
-            )
-        return super()._post(soft=soft)
-
-    def action_post(self):
         for invoice in self:
             # ---- Add a line with collection fees for each due date only for first due
             # ---- date of the month
@@ -284,8 +258,30 @@ def action_post(self):
                     invoice._sync_dynamic_lines(
                         container={"records": invoice, "self": invoice}
                     )
-        res = super().action_post()
-
+        inv_riba_no_bank = self.filtered(
+            lambda x: x.is_riba_payment
+            and x.move_type == "out_invoice"
+            and not x.riba_partner_bank_id
+        )
+        if inv_riba_no_bank:
+            inv_details = (
+                self.env._(
+                    'Invoice %(name)s for customer "%(customer_name)s", '
+                    "total %(amount)s",
+                    name=inv.display_name,
+                    customer_name=inv.partner_id.display_name,
+                    amount=inv.amount_total,
+                )
+                for inv in inv_riba_no_bank
+            )
+            raise UserError(
+                self.env._(
+                    "Cannot post invoices with C/O payments without bank. "
+                    "Please check the following invoices:\n\n- "
+                    + "\n- ".join(inv_details)
+                )
+            )
+        res = super()._post(soft=soft)
         # Automatic reconciliation for RiBa credit moves
         # When a credit move is posted and there are related RiBa slips,
         # we need to reconcile the acceptance and credit move lines