[FIX]l10n_it_riba_oca add test to very the fee is added when the invoice is confirmed from tree

Author: mmircoli-nexapp

l10n_it_riba_oca/tests/test_riba.py

@@ -44,6 +44,38 @@ def test_add_due_cost(self):
         new_inv = self.invoice.copy()
         self.assertEqual(len(new_inv.invoice_line_ids), 1)
 
+    def test_add_due_cost_via_post(self):
+        """Collection fees are added when _post is called directly.
+
+        Regression test for https://github.com/OCA/l10n-italy/issues/5063:
+        when confirming invoices from the list view using 'Confirm Entries',
+        the collection fees must be added. Before this fix, the fee-adding
+        logic was only in action_post() and was skipped when _post() was
+        called directly.
+        """
+        # ---- Set Service in Company Config
+        self.invoice.company_id.due_cost_service_id = self.service_due_cost.id
+        # ---- Validate Invoice using _post() directly, simulating the code
+        # ---- path used by batch confirmation from list view
+        self.invoice._post(soft=False)
+        # ---- Test Invoice has 3 lines (1 product + 2 collection fees)
+        self.assertEqual(len(self.invoice.invoice_line_ids), 3)
+        # ---- Test Invoice Line for service cost
+        self.assertEqual(
+            self.invoice.invoice_line_ids[1].product_id.id, self.service_due_cost.id
+        )
+        self.assertEqual(
+            self.invoice.invoice_line_ids[2].product_id.id, self.service_due_cost.id
+        )
+        # ---- Test Cost lines total is equal to 10.00 (5.00 x 2 due dates)
+        self.assertEqual(
+            (
+                self.invoice.invoice_line_ids[1].price_unit
+                + self.invoice.invoice_line_ids[2].price_unit
+            ),
+            10.00,
+        )
+
     def test_not_add_due_cost(self):
         # create 2 invoice for partner in same month on the second one no
         # collection fees line expected
@@ -983,9 +1015,11 @@ def test_charge_to_customer_with_partner(self):
 
         # Find the bank fee line
         bank_fee_line = past_due_move.line_ids.filtered(
-            lambda line: line.name == "Bank Fee"
-            and line.account_id == past_due_wizard.bank_expense_account_id
-            and line.debit > 0
+            lambda line: (
+                line.name == "Bank Fee"
+                and line.account_id == past_due_wizard.bank_expense_account_id
+                and line.debit > 0
+            )
         )
 
         # Assert that partner_id is set
@@ -1024,9 +1058,11 @@ def test_charge_to_customer_without_partner(self):
 
         # Find the bank fee line
         bank_fee_line = past_due_move.line_ids.filtered(
-            lambda line: line.name == "Bank Fee"
-            and line.account_id == past_due_wizard.bank_expense_account_id
-            and line.debit > 0
+            lambda line: (
+                line.name == "Bank Fee"
+                and line.account_id == past_due_wizard.bank_expense_account_id
+                and line.debit > 0
+            )
         )
 
         # Assert that partner_id is not set