[MIG] l10n_es_facturae_face: Migration to 19.0

Author: Alexgars73

l10n_es_facturae_face/README.rst

@@ -21,13 +21,13 @@ Envío de Facturae a FACe
     :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html
     :alt: License: AGPL-3
 .. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fl10n--spain-lightgray.png?logo=github
-    :target: https://github.com/OCA/l10n-spain/tree/18.0/l10n_es_facturae_face
+    :target: https://github.com/OCA/l10n-spain/tree/19.0/l10n_es_facturae_face
     :alt: OCA/l10n-spain
 .. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png
-    :target: https://translation.odoo-community.org/projects/l10n-spain-18-0/l10n-spain-18-0-l10n_es_facturae_face
+    :target: https://translation.odoo-community.org/projects/l10n-spain-19-0/l10n-spain-19-0-l10n_es_facturae_face
     :alt: Translate me on Weblate
 .. |badge5| image:: https://img.shields.io/badge/runboat-Try%20me-875A7B.png
-    :target: https://runboat.odoo-community.org/builds?repo=OCA/l10n-spain&target_branch=18.0
+    :target: https://runboat.odoo-community.org/builds?repo=OCA/l10n-spain&target_branch=19.0
     :alt: Try me on Runboat
 
 |badge1| |badge2| |badge3| |badge4| |badge5|
@@ -130,7 +130,7 @@ Bug Tracker
 Bugs are tracked on `GitHub Issues <https://github.com/OCA/l10n-spain/issues>`_.
 In case of trouble, please check there if your issue has already been reported.
 If you spotted it first, help us to smash it by providing a detailed and welcomed
-`feedback <https://github.com/OCA/l10n-spain/issues/new?body=module:%20l10n_es_facturae_face%0Aversion:%2018.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
+`feedback <https://github.com/OCA/l10n-spain/issues/new?body=module:%20l10n_es_facturae_face%0Aversion:%2019.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
 
 Do not contact contributors directly about support or help with technical issues.
 
@@ -149,6 +149,7 @@ Contributors
 - Eric Antones <eantones@nuobit.com>
 - Manuel Regidor <manuel.regidor@sygel.es>
 - Valentín Vinagre <valentin.vinagre@sygel.es>
+- Alex Garcia <alex@studio73.es>
 
 Maintainers
 -----------
@@ -171,6 +172,6 @@ Current `maintainer <https://odoo-community.org/page/maintainer-role>`__:
 
 |maintainer-etobella| 
 
-This module is part of the `OCA/l10n-spain <https://github.com/OCA/l10n-spain/tree/18.0/l10n_es_facturae_face>`_ project on GitHub.
+This module is part of the `OCA/l10n-spain <https://github.com/OCA/l10n-spain/tree/19.0/l10n_es_facturae_face>`_ project on GitHub.
 
 You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute.

l10n_es_facturae_face/__manifest__.py

@@ -3,7 +3,7 @@
 
 {
     "name": "Envío de Facturae a FACe",
-    "version": "18.0.1.0.1",
+    "version": "19.0.1.0.0",
     "author": "Creu Blanca, Odoo Community Association (OCA)",
     "category": "Accounting & Finance",
     "website": "https://github.com/OCA/l10n-spain",

l10n_es_facturae_face/models/account_move.py

@@ -2,7 +2,7 @@
 # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl.html).
 
 
-from odoo import _, api, fields, models
+from odoo import api, fields, models
 from odoo.exceptions import UserError, ValidationError
 
 
@@ -60,7 +60,7 @@ def _edi_create_exchange_record_vals(self, exchange_type):
                 self.env.ref("l10n_es_facturae_face.face_backend"),
             )
             if not related_record:
-                raise UserError(_("Exchange record cannot be found for FACe"))
+                raise UserError(self.env._("Exchange record cannot be found for FACe"))
             result.update(
                 {"edi_exchange_state": "input_pending", "parent_id": related_record.id}
             )
@@ -107,17 +107,17 @@ def validate_facturae_fields(self):
             self.partner_id.l10n_es_facturae_sending_code == "face"
             and not self.partner_id.organo_gestor
         ):
-            raise ValidationError(_("Organo Gestor not provided"))
+            raise ValidationError(self.env._("Organo Gestor not provided"))
         if (
             self.partner_id.l10n_es_facturae_sending_code == "face"
             and not self.partner_id.unidad_tramitadora
         ):
-            raise ValidationError(_("Unidad Tramitadora not provided"))
+            raise ValidationError(self.env._("Unidad Tramitadora not provided"))
         if (
             self.partner_id.l10n_es_facturae_sending_code == "face"
             and not self.partner_id.oficina_contable
         ):
-            raise ValidationError(_("Oficina Contable not provided"))
+            raise ValidationError(self.env._("Oficina Contable not provided"))
         return
 
     def _get_l10n_es_facturae_face_backend(self):

l10n_es_facturae_face/models/edi_exchange_record.py

@@ -7,7 +7,7 @@
 
 from zeep import helpers
 
-from odoo import _, fields, models
+from odoo import fields, models
 
 _logger = logging.getLogger(__name__)
 
@@ -84,7 +84,7 @@ def _cron_face_update_method(self, company_domain=False, limit=None, days_limit=
                 exchanges,
             )
             if response.resultado.codigo != "0":
-                _logger.info(_("Company %s cannot be processed") % company.display_name)
+                _logger.info("Company %s cannot be processed", company.display_name)
                 continue
             for invoice in response.facturas.consultarListadoFactura:
                 exchange_record = exchange_dict[invoice.factura.numeroRegistro]

l10n_es_facturae_face/models/l10n_es_facturae_face_base_handler.py

@@ -59,6 +59,10 @@ def send_webservice(
             email, invoice_file, anexos
         )
         response = client.service.enviarFactura(invoice_call)
+        if not response:
+            raise ValidationError(
+                self.env._("No response received from FACe webservice")
+            )
         if response.resultado.codigo != "0":
             raise ValidationError(response.resultado.descripcion)
         return response
@@ -75,14 +79,14 @@ def consult_invoices(self, public_crt, private_key, invoices):
     def cancel(self, public_crt, private_key, identifier, motive):
         client = self._get_client(public_crt, private_key)
         response = client.service.anularFactura(identifier, motive)
+        if not response:
+            raise UserError(self.env._("No response received from FACe webservice"))
         if response.resultado.codigo != "0":
             raise UserError(
                 self.env._(
-                    "Connection with FACe returned error %(code)s - %(description)s"
+                    "Connection with FACe returned error %(code)s - %(description)s",
+                    code=response.resultado.codigo,
+                    description=response.resultado.descripcion,
                 )
-                % {
-                    "code": response.resultado.codigo,
-                    "description": response.resultado.descripcion,
-                }
             )
         return response

l10n_es_facturae_face/models/l10n_es_facturae_face_update_handler.py

@@ -32,20 +32,20 @@ def receive(self, exchange_record):
         if response.resultado.codigo != "0":
             raise UserError(
                 self.env._(
-                    "Connection with FACe returned error %(code)s - %(description)s"
+                    "Connection with FACe returned error %(code)s - %(description)s",
+                    code=response.resultado.codigo,
+                    description=response.resultado.descripcion,
                 )
-                % {
-                    "code": response.resultado.codigo,
-                    "description": response.resultado.descripcion,
-                }
             )
         return json.dumps(helpers.serialize_object(response.factura))
 
     def process(self, exchange_record):
         data = json.loads(exchange_record._get_file_content())
         parent = exchange_record.parent_id
-        process_code = "face-" + data["tramitacion"]["codigo"]
-        revocation_code = "face-" + data["anulacion"]["codigo"]
+        tramitacion = data.get("tramitacion") or {}
+        anulacion = data.get("anulacion") or {}
+        process_code = "face-" + tramitacion.get("codigo", "")
+        revocation_code = "face-" + anulacion.get("codigo", "")
         if (
             process_code == parent.l10n_es_facturae_status
             and revocation_code == parent.l10n_es_facturae_cancellation_status
@@ -54,9 +54,9 @@ def process(self, exchange_record):
         parent.write(
             {
                 "l10n_es_facturae_status": process_code,
-                "l10n_es_facturae_motive": data["tramitacion"]["motivo"],
+                "l10n_es_facturae_motive": tramitacion.get("motivo", ""),
                 "l10n_es_facturae_cancellation_status": revocation_code,
-                "l10n_es_facturae_cancellation_motive": data["anulacion"]["motivo"],
+                "l10n_es_facturae_cancellation_motive": anulacion.get("motivo", ""),
             }
         )
         exchange_record.record.write(

l10n_es_facturae_face/models/res_company.py

@@ -3,7 +3,7 @@
 
 import re
 
-from odoo import _, api, fields, models
+from odoo import api, fields, models
 from odoo.exceptions import ValidationError
 
 
@@ -19,4 +19,4 @@ def check_face_email(self):
                 "(^[a-zA-Z0-9_.+-]+@[a-zA-Z0-9-]+\\.[a-zA-Z0-9-.]+$)",
                 record.face_email,
             ):
-                raise ValidationError(_("Invalid facturae email"))
+                raise ValidationError(self.env._("Invalid facturae email"))

l10n_es_facturae_face/models/res_partner.py

@@ -2,7 +2,7 @@
 # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl.html).
 
 
-from odoo import _, api, exceptions, fields, models
+from odoo import api, exceptions, fields, models
 
 
 class ResPartner(models.Model):
@@ -30,18 +30,20 @@ def _constrain_l10n_es_facturae_sending_code_face(self):
                 continue
             if not record.facturae:
                 raise exceptions.ValidationError(
-                    _("Facturae must be selected in order to send to FACe")
+                    self.env._("Facturae must be selected in order to send to FACe")
                 )
             if not record.vat:
                 raise exceptions.ValidationError(
-                    _("Vat must be defined in order to send to FACe")
+                    self.env._("Vat must be defined in order to send to FACe")
                 )
             if not record.country_id:
                 raise exceptions.ValidationError(
-                    _("Country must be defined in order to send to FACe")
+                    self.env._("Country must be defined in order to send to FACe")
                 )
             if record.country_id.code_alpha3 == "ESP":
                 if not record.state_id:
                     raise exceptions.ValidationError(
-                        _("State must be defined in Spain in order to send to FACe")
+                        self.env._(
+                            "State must be defined in Spain in order to send to FACe"
+                        )
                     )

l10n_es_facturae_face/readme/CONTRIBUTORS.md

@@ -2,3 +2,4 @@
 - Eric Antones \<<eantones@nuobit.com>\>
 - Manuel Regidor \<<manuel.regidor@sygel.es>\>
 - Valentín Vinagre \<<valentin.vinagre@sygel.es>\>
+- Alex Garcia \<<alex@studio73.es>\>

l10n_es_facturae_face/static/description/index.html

@@ -374,7 +374,7 @@ <h1>Envío de Facturae a FACe</h1>
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
 !! source digest: sha256:817e060f1babd121176557da4bbcfc06107620aec59a159bf1ff9f0dfb8d59a4
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! -->
-<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/license-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/l10n-spain/tree/18.0/l10n_es_facturae_face"><img alt="OCA/l10n-spain" src="https://img.shields.io/badge/github-OCA%2Fl10n--spain-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/l10n-spain-18-0/l10n-spain-18-0-l10n_es_facturae_face"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/l10n-spain&amp;target_branch=18.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
+<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/license-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/l10n-spain/tree/19.0/l10n_es_facturae_face"><img alt="OCA/l10n-spain" src="https://img.shields.io/badge/github-OCA%2Fl10n--spain-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/l10n-spain-19-0/l10n-spain-19-0-l10n_es_facturae_face"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/l10n-spain&amp;target_branch=19.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
 <p>Este módulo permite la gestión del envío de la facturación electrónica
 española a FACe. La gestión del envío se realiza mediante los
 certificados con los que se firma.</p>
@@ -485,7 +485,7 @@ <h2><a class="toc-backref" href="#toc-entry-6">Bug Tracker</a></h2>
 <p>Bugs are tracked on <a class="reference external" href="https://github.com/OCA/l10n-spain/issues">GitHub Issues</a>.
 In case of trouble, please check there if your issue has already been reported.
 If you spotted it first, help us to smash it by providing a detailed and welcomed
-<a class="reference external" href="https://github.com/OCA/l10n-spain/issues/new?body=module:%20l10n_es_facturae_face%0Aversion:%2018.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
+<a class="reference external" href="https://github.com/OCA/l10n-spain/issues/new?body=module:%20l10n_es_facturae_face%0Aversion:%2019.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
 <p>Do not contact contributors directly about support or help with technical issues.</p>
 </div>
 <div class="section" id="credits">
@@ -503,6 +503,7 @@ <h3><a class="toc-backref" href="#toc-entry-9">Contributors</a></h3>
 <li>Eric Antones &lt;<a class="reference external" href="mailto:eantones&#64;nuobit.com">eantones&#64;nuobit.com</a>&gt;</li>
 <li>Manuel Regidor &lt;<a class="reference external" href="mailto:manuel.regidor&#64;sygel.es">manuel.regidor&#64;sygel.es</a>&gt;</li>
 <li>Valentín Vinagre &lt;<a class="reference external" href="mailto:valentin.vinagre&#64;sygel.es">valentin.vinagre&#64;sygel.es</a>&gt;</li>
+<li>Alex Garcia &lt;<a class="reference external" href="mailto:alex&#64;studio73.es">alex&#64;studio73.es</a>&gt;</li>
 </ul>
 </div>
 <div class="section" id="maintainers">
@@ -516,7 +517,7 @@ <h3><a class="toc-backref" href="#toc-entry-10">Maintainers</a></h3>
 promote its widespread use.</p>
 <p>Current <a class="reference external" href="https://odoo-community.org/page/maintainer-role">maintainer</a>:</p>
 <p><a class="reference external image-reference" href="https://github.com/etobella"><img alt="etobella" src="https://github.com/etobella.png?size=40px" /></a></p>
-<p>This module is part of the <a class="reference external" href="https://github.com/OCA/l10n-spain/tree/18.0/l10n_es_facturae_face">OCA/l10n-spain</a> project on GitHub.</p>
+<p>This module is part of the <a class="reference external" href="https://github.com/OCA/l10n-spain/tree/19.0/l10n_es_facturae_face">OCA/l10n-spain</a> project on GitHub.</p>
 <p>You are welcome to contribute. To learn how please visit <a class="reference external" href="https://odoo-community.org/page/Contribute">https://odoo-community.org/page/Contribute</a>.</p>
 </div>
 </div>