[MIG] l10n_es_facturae: Migration to 19.0

Author: Alexgars73

l10n_es_facturae/README.rst

@@ -21,13 +21,13 @@ Creación de Facturae
     :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html
     :alt: License: AGPL-3
 .. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fl10n--spain-lightgray.png?logo=github
-    :target: https://github.com/OCA/l10n-spain/tree/18.0/l10n_es_facturae
+    :target: https://github.com/OCA/l10n-spain/tree/19.0/l10n_es_facturae
     :alt: OCA/l10n-spain
 .. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png
-    :target: https://translation.odoo-community.org/projects/l10n-spain-18-0/l10n-spain-18-0-l10n_es_facturae
+    :target: https://translation.odoo-community.org/projects/l10n-spain-19-0/l10n-spain-19-0-l10n_es_facturae
     :alt: Translate me on Weblate
 .. |badge5| image:: https://img.shields.io/badge/runboat-Try%20me-875A7B.png
-    :target: https://runboat.odoo-community.org/builds?repo=OCA/l10n-spain&target_branch=18.0
+    :target: https://runboat.odoo-community.org/builds?repo=OCA/l10n-spain&target_branch=19.0
     :alt: Try me on Runboat
 
 |badge1| |badge2| |badge3| |badge4| |badge5|
@@ -133,13 +133,13 @@ cambios.
 
 |usage_07|
 
-.. |usage_01| image:: https://raw.githubusercontent.com/OCA/l10n-spain/18.0/l10n_es_facturae/static/description/usage_01.png
-.. |usage_02| image:: https://raw.githubusercontent.com/OCA/l10n-spain/18.0/l10n_es_facturae/static/description/usage_02.png
-.. |usage_03| image:: https://raw.githubusercontent.com/OCA/l10n-spain/18.0/l10n_es_facturae/static/description/usage_03.png
-.. |usage_04| image:: https://raw.githubusercontent.com/OCA/l10n-spain/18.0/l10n_es_facturae/static/description/usage_04.png
-.. |usage_05| image:: https://raw.githubusercontent.com/OCA/l10n-spain/18.0/l10n_es_facturae/static/description/usage_05.png
-.. |usage_06| image:: https://raw.githubusercontent.com/OCA/l10n-spain/18.0/l10n_es_facturae/static/description/usage_06.png
-.. |usage_07| image:: https://raw.githubusercontent.com/OCA/l10n-spain/18.0/l10n_es_facturae/static/description/usage_07.png
+.. |usage_01| image:: https://raw.githubusercontent.com/OCA/l10n-spain/19.0/l10n_es_facturae/static/description/usage_01.png
+.. |usage_02| image:: https://raw.githubusercontent.com/OCA/l10n-spain/19.0/l10n_es_facturae/static/description/usage_02.png
+.. |usage_03| image:: https://raw.githubusercontent.com/OCA/l10n-spain/19.0/l10n_es_facturae/static/description/usage_03.png
+.. |usage_04| image:: https://raw.githubusercontent.com/OCA/l10n-spain/19.0/l10n_es_facturae/static/description/usage_04.png
+.. |usage_05| image:: https://raw.githubusercontent.com/OCA/l10n-spain/19.0/l10n_es_facturae/static/description/usage_05.png
+.. |usage_06| image:: https://raw.githubusercontent.com/OCA/l10n-spain/19.0/l10n_es_facturae/static/description/usage_06.png
+.. |usage_07| image:: https://raw.githubusercontent.com/OCA/l10n-spain/19.0/l10n_es_facturae/static/description/usage_07.png
 
 Usage
 =====
@@ -164,9 +164,9 @@ electrónica. Si es necesario, firme el archivo antes de descargarlo.
 Finalmente, una vez que tenga el archivo listo, puede subirlo al portal
 **FACe** para completar el proceso.
 
-.. |usage_08| image:: https://raw.githubusercontent.com/OCA/l10n-spain/18.0/l10n_es_facturae/static/description/usage_08.png
-.. |usage_09| image:: https://raw.githubusercontent.com/OCA/l10n-spain/18.0/l10n_es_facturae/static/description/usage_09.png
-.. |usage_10| image:: https://raw.githubusercontent.com/OCA/l10n-spain/18.0/l10n_es_facturae/static/description/usage_10.png
+.. |usage_08| image:: https://raw.githubusercontent.com/OCA/l10n-spain/19.0/l10n_es_facturae/static/description/usage_08.png
+.. |usage_09| image:: https://raw.githubusercontent.com/OCA/l10n-spain/19.0/l10n_es_facturae/static/description/usage_09.png
+.. |usage_10| image:: https://raw.githubusercontent.com/OCA/l10n-spain/19.0/l10n_es_facturae/static/description/usage_10.png
 
 Known issues / Roadmap
 ======================
@@ -202,7 +202,7 @@ Bug Tracker
 Bugs are tracked on `GitHub Issues <https://github.com/OCA/l10n-spain/issues>`_.
 In case of trouble, please check there if your issue has already been reported.
 If you spotted it first, help us to smash it by providing a detailed and welcomed
-`feedback <https://github.com/OCA/l10n-spain/issues/new?body=module:%20l10n_es_facturae%0Aversion:%2018.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
+`feedback <https://github.com/OCA/l10n-spain/issues/new?body=module:%20l10n_es_facturae%0Aversion:%2019.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
 
 Do not contact contributors directly about support or help with technical issues.
 
@@ -236,6 +236,7 @@ Contributors
 - Eric Antones (eantones@nuobit.com>
 - Alberto Martínez (alberto.martinez@sygel.es)
 - Carolina Fernandez (http://www.tecnativa.com)
+- Alex Garcia (alex@studio73.es)
 
 Maintainers
 -----------
@@ -258,6 +259,6 @@ Current `maintainer <https://odoo-community.org/page/maintainer-role>`__:
 
 |maintainer-etobella| 
 
-This module is part of the `OCA/l10n-spain <https://github.com/OCA/l10n-spain/tree/18.0/l10n_es_facturae>`_ project on GitHub.
+This module is part of the `OCA/l10n-spain <https://github.com/OCA/l10n-spain/tree/19.0/l10n_es_facturae>`_ project on GitHub.
 
 You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute.

l10n_es_facturae/__manifest__.py

@@ -12,7 +12,7 @@
 
 {
     "name": "Creación de Facturae",
-    "version": "18.0.1.2.1",
+    "version": "19.0.1.0.0",
     "author": "ASR-OSS, "
     "FactorLibre, "
     "Tecon, "
@@ -24,7 +24,7 @@
     "website": "https://github.com/OCA/l10n-spain",
     "license": "AGPL-3",
     "depends": [
-        "account_payment_partner",
+        "account_payment_mode",
         "l10n_es_partner",
         "l10n_es",
         "base_iso3166",

l10n_es_facturae/models/account_move.py

@@ -157,7 +157,7 @@ def validate_facturae_fields(self):
         for line in lines:
             if not line.tax_ids:
                 raise ValidationError(
-                    self.env._("Taxes not provided in move line %s") % line.name
+                    self.env._("Taxes not provided in move line %s", line.name)
                 )
         if self.state not in self._get_valid_move_statuses():
             raise ValidationError(
@@ -217,7 +217,7 @@ def _get_facturae_move_attachments(self):
                     "data": base64.b64encode(content).decode("utf-8"),
                     "content_type": content_type,
                     "encoding": "BASE64",
-                    "description": self.env._("Invoice %s") % self.name,
+                    "description": self.env._("Invoice %s", self.name),
                     "compression": False,
                 }
             )

l10n_es_facturae/models/res_currency.py

@@ -8,9 +8,10 @@ class ResCurrency(models.Model):
     _inherit = "res.currency"
 
     def get_current_rate(self):
-        date = self._context.get("date") or fields.Datetime.now()
+        date = self.env.context.get("date") or fields.Datetime.now()
         company_id = (
-            self._context.get("company_id") or self.env["res.users"]._get_company().id
+            self.env.context.get("company_id")
+            or self.env["res.users"]._get_company().id
         )
         rate = self.env["res.currency.rate"].search(
             [

l10n_es_facturae/readme/CONTRIBUTORS.md

@@ -12,3 +12,4 @@
 - Eric Antones (<eantones@nuobit.com>\>
 - Alberto Martínez (<alberto.martinez@sygel.es>)
 - Carolina Fernandez (<http://www.tecnativa.com>)
+- Alex Garcia (<alex@studio73.es>)

l10n_es_facturae/reports/report_facturae_signed.py

@@ -69,22 +69,22 @@ def _validate_facturae(self, move, xml_string):
                     "XML Schema Definition. The generated XML file and the "
                     "full error have been written in the server logs. Here "
                     "is the error, which may give you an idea on the cause "
-                    "of the problem : %s"
+                    "of the problem : %s",
+                    str(e),
                 )
-                % str(e)
             ) from e
         return True
 
     def _sign_file(self, move, request, public_cert, private_key):
         rand_min = 1
         rand_max = 99999
-        signature_id = "Signature%05d" % random.randint(rand_min, rand_max)
-        signed_properties_id = signature_id + "-SignedProperties%05d" % random.randint(
-            rand_min, rand_max
+        signature_id = f"Signature{random.randint(rand_min, rand_max):05d}"
+        signed_properties_id = (
+            f"{signature_id}-SignedProperties{random.randint(rand_min, rand_max):05d}"
         )
-        key_info_id = "KeyInfo%05d" % random.randint(rand_min, rand_max)
-        reference_id = "Reference%05d" % random.randint(rand_min, rand_max)
-        object_id = "Object%05d" % random.randint(rand_min, rand_max)
+        key_info_id = f"KeyInfo{random.randint(rand_min, rand_max):05d}"
+        reference_id = f"Reference{random.randint(rand_min, rand_max):05d}"
+        object_id = f"Object{random.randint(rand_min, rand_max):05d}"
         etsi = "http://uri.etsi.org/01903/v1.3.2#"
         sig_policy_identifier = (
             "http://www.facturae.es/"

l10n_es_facturae/static/description/index.html

@@ -374,7 +374,7 @@ <h1>Creación de Facturae</h1>
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
 !! source digest: sha256:a8773bd4dabe44703b1e87c44fc0b7eb4346156120fbf82b807e45b1ff379a7e
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! -->
-<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/license-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/l10n-spain/tree/18.0/l10n_es_facturae"><img alt="OCA/l10n-spain" src="https://img.shields.io/badge/github-OCA%2Fl10n--spain-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/l10n-spain-18-0/l10n-spain-18-0-l10n_es_facturae"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/l10n-spain&amp;target_branch=18.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
+<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/license-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/l10n-spain/tree/19.0/l10n_es_facturae"><img alt="OCA/l10n-spain" src="https://img.shields.io/badge/github-OCA%2Fl10n--spain-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/l10n-spain-19-0/l10n-spain-19-0-l10n_es_facturae"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/l10n-spain&amp;target_branch=19.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
 <p>En virtud de la Ley 25/2013, de 27 de diciembre, de impulso de la
 factura electrónica y creación del registro contable de facturas en el
 Sector Público, desde el día 15 de enero de 2015 todas las facturas
@@ -448,19 +448,19 @@ <h2><a class="toc-backref" href="#toc-entry-3">Configuration</a></h2>
 <strong>Contactos</strong>, seleccione la <strong>ficha del cliente</strong> correspondiente y
 acceda a la sección de <strong>Facturación/Contabilidad</strong>, específicamente al
 apartado de <strong>Facturae</strong>.</p>
-<p><img alt="usage_01" src="https://raw.githubusercontent.com/OCA/l10n-spain/18.0/l10n_es_facturae/static/description/usage_01.png" /> <img alt="usage_02" src="https://raw.githubusercontent.com/OCA/l10n-spain/18.0/l10n_es_facturae/static/description/usage_02.png" /></p>
+<p><img alt="usage_01" src="https://raw.githubusercontent.com/OCA/l10n-spain/19.0/l10n_es_facturae/static/description/usage_01.png" /> <img alt="usage_02" src="https://raw.githubusercontent.com/OCA/l10n-spain/19.0/l10n_es_facturae/static/description/usage_02.png" /></p>
 <p>Aquí debe <strong>activar la casilla</strong> correspondiente, seleccionar la
 <strong>versión de Facturae</strong> que utilizará y añadir los <strong>códigos</strong>
 necesarios para completar esta configuración.</p>
-<p><img alt="usage_03" src="https://raw.githubusercontent.com/OCA/l10n-spain/18.0/l10n_es_facturae/static/description/usage_03.png" /></p>
+<p><img alt="usage_03" src="https://raw.githubusercontent.com/OCA/l10n-spain/19.0/l10n_es_facturae/static/description/usage_03.png" /></p>
 <ol class="arabic simple" start="2">
 <li><strong>Completar la información de la compañía propia:</strong></li>
 </ol>
 <p>Una vez configurados los contactos, es importante asegurarse de que la
 información de su propia compañía esté completa. Para ello, acceda a la
 ficha de su empresa en <strong>ajustes</strong> y añada todos los datos requeridos,
 incluyendo la <strong>versión de Facturae</strong> que utilizará.</p>
-<p><img alt="usage_04" src="https://raw.githubusercontent.com/OCA/l10n-spain/18.0/l10n_es_facturae/static/description/usage_04.png" /> <img alt="usage_05" src="https://raw.githubusercontent.com/OCA/l10n-spain/18.0/l10n_es_facturae/static/description/usage_05.png" /></p>
+<p><img alt="usage_04" src="https://raw.githubusercontent.com/OCA/l10n-spain/19.0/l10n_es_facturae/static/description/usage_04.png" /> <img alt="usage_05" src="https://raw.githubusercontent.com/OCA/l10n-spain/19.0/l10n_es_facturae/static/description/usage_05.png" /></p>
 <p>Este paso es fundamental para que las facturas electrónicas se generen
 correctamente y cumplan con los estándares exigidos.</p>
 <ol class="arabic simple" start="3">
@@ -471,25 +471,25 @@ <h2><a class="toc-backref" href="#toc-entry-3">Configuration</a></h2>
 <strong>Facturación/Contabilidad</strong>, acceda al apartado de <strong>Configuración</strong> y
 seleccione Certificados AEAT.</p>
 <p>En esta pantalla, haga clic en <strong>Nuevo</strong> para crear un registro para su
-certificado. <img alt="usage_06" src="https://raw.githubusercontent.com/OCA/l10n-spain/18.0/l10n_es_facturae/static/description/usage_06.png" /></p>
+certificado. <img alt="usage_06" src="https://raw.githubusercontent.com/OCA/l10n-spain/19.0/l10n_es_facturae/static/description/usage_06.png" /></p>
 <p>Asígnele un nombre y suba el archivo correspondiente. Una vez cargado el
 certificado, haga clic en la opción de <strong>Obtener claves</strong> y guarde los
 cambios.</p>
-<p><img alt="usage_07" src="https://raw.githubusercontent.com/OCA/l10n-spain/18.0/l10n_es_facturae/static/description/usage_07.png" /></p>
+<p><img alt="usage_07" src="https://raw.githubusercontent.com/OCA/l10n-spain/19.0/l10n_es_facturae/static/description/usage_07.png" /></p>
 </div>
 <div class="section" id="usage">
 <h2><a class="toc-backref" href="#toc-entry-4">Usage</a></h2>
 <p><strong>Descargue el archivo de facturae</strong></p>
 <p>Con la configuración lista, ya puede proceder a emitir sus facturas
 electrónicas. Para ello, acceda a <strong>Facturación/Contabilidad</strong>, entre en
-el menú de <strong>Clientes</strong> y seleccione <strong>Facturas</strong>. <img alt="usage_08" src="https://raw.githubusercontent.com/OCA/l10n-spain/18.0/l10n_es_facturae/static/description/usage_08.png" /></p>
+el menú de <strong>Clientes</strong> y seleccione <strong>Facturas</strong>. <img alt="usage_08" src="https://raw.githubusercontent.com/OCA/l10n-spain/19.0/l10n_es_facturae/static/description/usage_08.png" /></p>
 <p>Haga clic en <strong>Nuevo</strong> para crear una nueva factura. Complete toda la
 información necesaria, guarde los datos, y luego seleccione el icono de
 <strong>engranaje de Acción</strong>.</p>
-<p><img alt="usage_09" src="https://raw.githubusercontent.com/OCA/l10n-spain/18.0/l10n_es_facturae/static/description/usage_09.png" /></p>
+<p><img alt="usage_09" src="https://raw.githubusercontent.com/OCA/l10n-spain/19.0/l10n_es_facturae/static/description/usage_09.png" /></p>
 <p>Aquí encontrará la opción para descargar el archivo de la factura
 electrónica. Si es necesario, firme el archivo antes de descargarlo.</p>
-<p><img alt="usage_10" src="https://raw.githubusercontent.com/OCA/l10n-spain/18.0/l10n_es_facturae/static/description/usage_10.png" /></p>
+<p><img alt="usage_10" src="https://raw.githubusercontent.com/OCA/l10n-spain/19.0/l10n_es_facturae/static/description/usage_10.png" /></p>
 <p>Finalmente, una vez que tenga el archivo listo, puede subirlo al portal
 <strong>FACe</strong> para completar el proceso.</p>
 </div>
@@ -525,7 +525,7 @@ <h2><a class="toc-backref" href="#toc-entry-8">Bug Tracker</a></h2>
 <p>Bugs are tracked on <a class="reference external" href="https://github.com/OCA/l10n-spain/issues">GitHub Issues</a>.
 In case of trouble, please check there if your issue has already been reported.
 If you spotted it first, help us to smash it by providing a detailed and welcomed
-<a class="reference external" href="https://github.com/OCA/l10n-spain/issues/new?body=module:%20l10n_es_facturae%0Aversion:%2018.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
+<a class="reference external" href="https://github.com/OCA/l10n-spain/issues/new?body=module:%20l10n_es_facturae%0Aversion:%2019.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
 <p>Do not contact contributors directly about support or help with technical issues.</p>
 </div>
 <div class="section" id="credits">
@@ -558,6 +558,7 @@ <h3><a class="toc-backref" href="#toc-entry-11">Contributors</a></h3>
 <li>Eric Antones (<a class="reference external" href="mailto:eantones&#64;nuobit.com">eantones&#64;nuobit.com</a>&gt;</li>
 <li>Alberto Martínez (<a class="reference external" href="mailto:alberto.martinez&#64;sygel.es">alberto.martinez&#64;sygel.es</a>)</li>
 <li>Carolina Fernandez (<a class="reference external" href="http://www.tecnativa.com">http://www.tecnativa.com</a>)</li>
+<li>Alex Garcia (<a class="reference external" href="mailto:alex&#64;studio73.es">alex&#64;studio73.es</a>)</li>
 </ul>
 </div>
 <div class="section" id="maintainers">
@@ -571,7 +572,7 @@ <h3><a class="toc-backref" href="#toc-entry-12">Maintainers</a></h3>
 promote its widespread use.</p>
 <p>Current <a class="reference external" href="https://odoo-community.org/page/maintainer-role">maintainer</a>:</p>
 <p><a class="reference external image-reference" href="https://github.com/etobella"><img alt="etobella" src="https://github.com/etobella.png?size=40px" /></a></p>
-<p>This module is part of the <a class="reference external" href="https://github.com/OCA/l10n-spain/tree/18.0/l10n_es_facturae">OCA/l10n-spain</a> project on GitHub.</p>
+<p>This module is part of the <a class="reference external" href="https://github.com/OCA/l10n-spain/tree/19.0/l10n_es_facturae">OCA/l10n-spain</a> project on GitHub.</p>
 <p>You are welcome to contribute. To learn how please visit <a class="reference external" href="https://odoo-community.org/page/Contribute">https://odoo-community.org/page/Contribute</a>.</p>
 </div>
 </div>

l10n_es_facturae/views/res_partner_view.xml

@@ -24,7 +24,7 @@
             <xpath expr="/form" position="inside">
                 <field name="facturae" invisible="1" />
             </xpath>
-            <group name="accounting_entries" position="after">
+            <group id="invoice_send_settings" position="after">
                 <group
                     name="group_facturae"
                     string="Facturae"