[MIG] l10n_es_aeat_mod190: Migration to 19.0

EmilioPascual · EmilioPascual · commit 84edfb79aaed · 2026-03-27T13:37:26.000+01:00
diff --git a/l10n_es_aeat_mod190/README.rst b/l10n_es_aeat_mod190/README.rst
@@ -21,13 +21,13 @@ AEAT modelo 190
     :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html
     :alt: License: AGPL-3
 .. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fl10n--spain-lightgray.png?logo=github
-    :target: https://github.com/OCA/l10n-spain/tree/18.0/l10n_es_aeat_mod190
+    :target: https://github.com/OCA/l10n-spain/tree/19.0/l10n_es_aeat_mod190
     :alt: OCA/l10n-spain
 .. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png
-    :target: https://translation.odoo-community.org/projects/l10n-spain-18-0/l10n-spain-18-0-l10n_es_aeat_mod190
+    :target: https://translation.odoo-community.org/projects/l10n-spain-19-0/l10n-spain-19-0-l10n_es_aeat_mod190
     :alt: Translate me on Weblate
 .. |badge5| image:: https://img.shields.io/badge/runboat-Try%20me-875A7B.png
-    :target: https://runboat.odoo-community.org/builds?repo=OCA/l10n-spain&target_branch=18.0
+    :target: https://runboat.odoo-community.org/builds?repo=OCA/l10n-spain&target_branch=19.0
     :alt: Try me on Runboat
 
 |badge1| |badge2| |badge3| |badge4| |badge5|
@@ -125,7 +125,7 @@ Bug Tracker
 Bugs are tracked on `GitHub Issues <https://github.com/OCA/l10n-spain/issues>`_.
 In case of trouble, please check there if your issue has already been reported.
 If you spotted it first, help us to smash it by providing a detailed and welcomed
-`feedback <https://github.com/OCA/l10n-spain/issues/new?body=module:%20l10n_es_aeat_mod190%0Aversion:%2018.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
+`feedback <https://github.com/OCA/l10n-spain/issues/new?body=module:%20l10n_es_aeat_mod190%0Aversion:%2019.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
 
 Do not contact contributors directly about support or help with technical issues.
 
@@ -182,6 +182,6 @@ OCA, or the Odoo Community Association, is a nonprofit organization whose
 mission is to support the collaborative development of Odoo features and
 promote its widespread use.
 
-This module is part of the `OCA/l10n-spain <https://github.com/OCA/l10n-spain/tree/18.0/l10n_es_aeat_mod190>`_ project on GitHub.
+This module is part of the `OCA/l10n-spain <https://github.com/OCA/l10n-spain/tree/19.0/l10n_es_aeat_mod190>`_ project on GitHub.
 
 You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute.
diff --git a/l10n_es_aeat_mod190/__manifest__.py b/l10n_es_aeat_mod190/__manifest__.py
@@ -2,7 +2,7 @@
 
 {
     "name": "AEAT modelo 190",
-    "version": "18.0.1.3.0",
+    "version": "19.0.1.0.0",
     "category": "Localization/Accounting",
     "author": "Punt Sistemes SLU,"
     "Odoo Community Association (OCA),"
diff --git a/l10n_es_aeat_mod190/models/l10n_es_aeat_mod190_report.py b/l10n_es_aeat_mod190/models/l10n_es_aeat_mod190_report.py
@@ -4,7 +4,7 @@
 
 from collections import defaultdict
 
-from odoo import _, api, exceptions, fields, models
+from odoo import api, exceptions, fields, models
 
 from odoo.addons.l10n_es_aeat.models.spanish_states_mapping import SPANISH_STATES
 
@@ -108,7 +108,9 @@ def _check_report_lines(self):
         (partner records) are filled"""
         if any(not item.partner_record_ok for item in self.partner_record_ids):
             raise exceptions.UserError(
-                _("All partner records fields (country, VAT number) " "must be filled.")
+                self.env._(
+                    "All partner records fields (country, VAT number) must be filled."
+                )
             )
 
     def button_confirm(self):
@@ -142,11 +144,11 @@ def calculate(self):
                     tax_line_vals[rp.id][key_id.id][subkey_id.id] = {}
                     if not rp.aeat_perception_key_id:
                         raise exceptions.UserError(
-                            _(
+                            self.env._(
                                 "The perception key of the partner, %(partner)s. "
-                                "Must be filled."
+                                "Must be filled.",
+                                partner=rp.name,
                             )
-                            % ({"partner": rp.name})
                         )
                     values = report._get_line_mod190_vals(rp, key_id, subkey_id)
                     partner_vals.append(values)
@@ -159,7 +161,10 @@ def _get_line_mod190_vals(self, rp, key_id, subkey_id):
         codigo_provincia = SPANISH_STATES.get(rp.state_id.code)
         if not codigo_provincia:
             raise exceptions.UserError(
-                _("The state is not defined in the partner, %s") % rp.name
+                self.env._(
+                    "The state is not defined in the partner, %(partner)s",
+                    partner=rp.name,
+                )
             )
         return {
             "partner_id": rp.id,
@@ -170,12 +175,11 @@ def _get_line_mod190_vals(self, rp, key_id, subkey_id):
     def _get_grouped_data(self, field_number, domain):
         return {
             (
-                item["partner_id"][0],
-                item["aeat_perception_key_id"] and item["aeat_perception_key_id"][0],
-                item["aeat_perception_subkey_id"]
-                and item["aeat_perception_subkey_id"][0],
-            ): item["credit"] - item["debit"]
-            for item in self.env["account.move.line"].read_group(
+                item[0].id if item[0].id else False,  # partner_id
+                item[1].id if item[1] else False,  # aeat_perception_key_id
+                item[2].id if item[2].id else False,  # aeat_perception_subkey_id
+            ): item[3] - item[4]  # credit - debit
+            for item in self.env["account.move.line"]._read_group(
                 self._get_move_line_domain(
                     self.date_start,
                     self.date_end,
@@ -184,9 +188,8 @@ def _get_grouped_data(self, field_number, domain):
                     ).map_line_id,
                 )
                 + domain,
-                ["credit", "debit"],
                 ["partner_id", "aeat_perception_key_id", "aeat_perception_subkey_id"],
-                lazy=False,
+                ["credit:sum", "debit:sum"],
             )
         }
 
@@ -267,7 +270,7 @@ class L10nEsAeatMod190ReportLine(models.Model):
         store=True,
     )
     ingresos_a_cuenta_efectuados_incap = fields.Float(
-        string="Income on account in kind made as a result of incapacity " "for work",
+        string="Income on account in kind made as a result of incapacity for work",
         compute="_compute_percepciones",
         store=True,
     )
@@ -334,8 +337,7 @@ class L10nEsAeatMod190ReportLine(models.Model):
             ("2", "2 - Contract or ratio less than a year"),
             (
                 "3",
-                "3 - Contract or special employment relationship of a dependent "
-                "nature",
+                "3 - Contract or special employment relationship of a dependent nature",
             ),
             ("4", "4 - Sporadic relationship of manual workers"),
         ],
@@ -404,8 +406,7 @@ class L10nEsAeatMod190ReportLine(models.Model):
         store=True,
     )
     hijos_y_desc_discapacidad_entero_33 = fields.Integer(
-        string="Hijos y descendientes con discapacidad del 33%"
-        ", computados por entero",
+        string="Hijos y descendientes con discapacidad del 33%, computados por entero",
         compute="_compute_partner_id_ad_required",
         store=True,
     )
@@ -415,8 +416,7 @@ class L10nEsAeatMod190ReportLine(models.Model):
         store=True,
     )
     hijos_y_desc_discapacidad_entero_66 = fields.Integer(
-        string="Hijos y descendientes con discapacidad del 66%"
-        ", computados por entero",
+        string="Hijos y descendientes con discapacidad del 66%, computados por entero",
         compute="_compute_partner_id_ad_required",
         store=True,
     )
@@ -456,7 +456,7 @@ class L10nEsAeatMod190ReportLine(models.Model):
         store=True,
     )
     ascendientes_discapacidad_entero_mr = fields.Integer(
-        string="Ascendientes con discapacidad de más del 33%" ", computados por entero",
+        string="Ascendientes con discapacidad de más del 33%, computados por entero",
         compute="_compute_partner_id_ad_required",
         store=True,
     )
@@ -466,7 +466,7 @@ class L10nEsAeatMod190ReportLine(models.Model):
         store=True,
     )
     ascendientes_discapacidad_entero_66 = fields.Integer(
-        string="Ascendientes con discapacidad de más del 66%" ", computados por entero",
+        string="Ascendientes con discapacidad de más del 66%, computados por entero",
         compute="_compute_partner_id_ad_required",
         store=True,
     )
@@ -691,7 +691,9 @@ def _compute_visible_key_b01(self):
     def onchange_partner_id(self):
         if self.partner_id:
             if not self.partner_id.state_id:
-                raise exceptions.UserError(_("Provincia no definida en el cliente"))
+                raise exceptions.UserError(
+                    self.env._("Provincia no definida en el cliente")
+                )
             # Cargamos valores establecidos en el tercero.
             self.aeat_perception_key_id = self.partner_id.aeat_perception_key_id
             self.aeat_perception_subkey_id = self.partner_id.aeat_perception_subkey_id
diff --git a/l10n_es_aeat_mod190/security/l10n_es_aeat_mod190_security.xml b/l10n_es_aeat_mod190/security/l10n_es_aeat_mod190_security.xml
@@ -2,14 +2,14 @@
 <odoo>
     <record id="group_aeat_mod190" model="res.groups">
         <field name="name">AEAT Model 190 (with access to sensitive data)</field>
-        <field name="category_id" ref="base.module_category_hidden" />
+        <field name="privilege_id" ref="l10n_es_aeat.res_groups_privilege_aeat" />
         <field
-            name="users"
-            eval="[(4, ref('base.user_root')), (4, ref('base.user_admin'))]"
+            name="user_ids"
+            eval="[Command.link(ref('base.user_root')), Command.link(ref('base.user_admin'))]"
         />
         <field
             name="implied_ids"
-            eval="[(4, ref('l10n_es_aeat.group_account_aeat'))]"
+            eval="[Command.link(ref('l10n_es_aeat.group_account_aeat'))]"
         />
     </record>
     <record id="aeat_190_company_rule" model="ir.rule">
diff --git a/l10n_es_aeat_mod190/static/description/index.html b/l10n_es_aeat_mod190/static/description/index.html
@@ -374,7 +374,7 @@ <h1>AEAT modelo 190</h1>
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
 !! source digest: sha256:0eee8daa1e80496b0a075eac913a46232427ee03b1c0a2fc1519df3334d854f5
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! -->
-<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/license-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/l10n-spain/tree/18.0/l10n_es_aeat_mod190"><img alt="OCA/l10n-spain" src="https://img.shields.io/badge/github-OCA%2Fl10n--spain-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/l10n-spain-18-0/l10n-spain-18-0-l10n_es_aeat_mod190"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/l10n-spain&amp;target_branch=18.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
+<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/license-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/l10n-spain/tree/19.0/l10n_es_aeat_mod190"><img alt="OCA/l10n-spain" src="https://img.shields.io/badge/github-OCA%2Fl10n--spain-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/l10n-spain-19-0/l10n-spain-19-0-l10n_es_aeat_mod190"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/l10n-spain&amp;target_branch=19.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
 <p>Modelo 190 de la AEAT. Retenciones e ingresos a cuenta. Rendimientos del
 trabajo y de actividades económicas, premios y determinadas ganancias
 patrimoniales e imputaciones de Renta. Resumen anual.</p>
@@ -474,7 +474,7 @@ <h2><a class="toc-backref" href="#toc-entry-4">Bug Tracker</a></h2>
 <p>Bugs are tracked on <a class="reference external" href="https://github.com/OCA/l10n-spain/issues">GitHub Issues</a>.
 In case of trouble, please check there if your issue has already been reported.
 If you spotted it first, help us to smash it by providing a detailed and welcomed
-<a class="reference external" href="https://github.com/OCA/l10n-spain/issues/new?body=module:%20l10n_es_aeat_mod190%0Aversion:%2018.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
+<a class="reference external" href="https://github.com/OCA/l10n-spain/issues/new?body=module:%20l10n_es_aeat_mod190%0Aversion:%2019.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
 <p>Do not contact contributors directly about support or help with technical issues.</p>
 </div>
 <div class="section" id="credits">
@@ -528,7 +528,7 @@ <h3><a class="toc-backref" href="#toc-entry-8">Maintainers</a></h3>
 <p>OCA, or the Odoo Community Association, is a nonprofit organization whose
 mission is to support the collaborative development of Odoo features and
 promote its widespread use.</p>
-<p>This module is part of the <a class="reference external" href="https://github.com/OCA/l10n-spain/tree/18.0/l10n_es_aeat_mod190">OCA/l10n-spain</a> project on GitHub.</p>
+<p>This module is part of the <a class="reference external" href="https://github.com/OCA/l10n-spain/tree/19.0/l10n_es_aeat_mod190">OCA/l10n-spain</a> project on GitHub.</p>
 <p>You are welcome to contribute. To learn how please visit <a class="reference external" href="https://odoo-community.org/page/Contribute">https://odoo-community.org/page/Contribute</a>.</p>
 </div>
 </div>
diff --git a/l10n_es_aeat_mod190/tests/test_mod190.py b/l10n_es_aeat_mod190/tests/test_mod190.py
@@ -31,7 +31,7 @@ class TestL10nEsAeatMod190Base(TestL10nEsAeatModBase):
     @classmethod
     def setUpClass(cls):
         super().setUpClass()
-        cls.account_manager.groups_id |= cls.env.ref(
+        cls.account_manager.group_ids |= cls.env.ref(
             "l10n_es_aeat_mod190.group_aeat_mod190"
         ) | cls.env.ref("base.group_partner_manager")
         cls.env = cls.env(
diff --git a/l10n_es_aeat_mod190/uv.lock b/l10n_es_aeat_mod190/uv.lock

Original file line number	Diff line number	Diff line change
`@@ -2,7 +2,7 @@`
`2`	`2`
`3`	`3`	`{`
`4`	`4`	`"name": "AEAT modelo 190",`
`5`		`- "version": "18.0.1.3.0",`
	`5`	`+ "version": "19.0.1.0.0",`
`6`	`6`	`"category": "Localization/Accounting",`
`7`	`7`	`"author": "Punt Sistemes SLU,"`
`8`	`8`	`"Odoo Community Association (OCA),"`