[MIG] maintenance_purchase: Migration to version 18.0

Author: christian-ramos-tecnativa

maintenance_purchase/__manifest__.py

@@ -5,17 +5,17 @@
     "name": "Maintenance Purchase",
     "summary": """
         Create Equipments with purchases""",
-    "version": "16.0.1.0.0",
+    "version": "18.0.1.0.0",
     "license": "AGPL-3",
     "author": "CreuBlanca,Odoo Community Association (OCA)",
     "website": "https://github.com/OCA/maintenance",
     "depends": [
-        "maintenance_account",
-        "purchase_stock",
+        "purchase",
     ],
     "data": [
         "views/purchase_order.xml",
         "views/maintenance_equipment.xml",
+        "views/product_template_view.xml",
     ],
     "demo": [],
 }

maintenance_purchase/migrations/18.0.1.0.0/post-migration.py

@@ -0,0 +1,25 @@
+# Copyright 2026 Tecnativa - Christian Ramos
+# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
+from openupgradelib import openupgrade
+
+
+@openupgrade.migrate()
+def migrate(env, version):
+    # Bring the category data from maintenance_equipment_category to the product
+    if openupgrade.column_exists(
+        env.cr, "maintenance_equipment_category", "product_category_id"
+    ):
+        openupgrade.logged_query(
+            env.cr,
+            """
+            UPDATE product_template pt
+            SET equipment_category_id = sub.equipment_category_id
+            FROM (
+                SELECT mec.product_category_id AS product_category_id,
+                        mec.id AS equipment_category_id
+                FROM maintenance_equipment_category mec
+                WHERE mec.product_category_id IS NOT NULL
+            ) AS sub
+            WHERE pt.categ_id = sub.product_category_id
+                AND pt.equipment_category_id IS NULL""",
+        )

maintenance_purchase/models/__init__.py

@@ -1,2 +1,3 @@
 from . import maintenance_equipment
 from . import purchase_order
+from . import product_template

maintenance_purchase/models/product_template.py

@@ -0,0 +1,12 @@
+# Copyright 2022 Tecnativa - Víctor Martínez
+# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
+from odoo import fields, models
+
+
+class ProductTemplate(models.Model):
+    _inherit = "product.template"
+
+    equipment_category_id = fields.Many2one(
+        comodel_name="maintenance.equipment.category",
+        string="Equipment Category",
+    )

maintenance_purchase/models/purchase_order.py

@@ -1,7 +1,7 @@
 # Copyright 2022 CreuBlanca
 # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
 
-from odoo import api, fields, models
+from odoo import Command, api, fields, models
 
 
 class PurchaseOrder(models.Model):
@@ -24,8 +24,9 @@ def action_view_equipments(self):
         items = self.env["maintenance.equipment"].search(
             [("purchase_id", "=", self.id)]
         )
-        action = self.env.ref("maintenance.hr_equipment_action")
-        action_dict = action.sudo().read()[0]
+        action_dict = self.env["ir.actions.act_window"]._for_xml_id(
+            "maintenance.hr_equipment_action"
+        )
         if len(items) == 1:
             res = self.env.ref("maintenance.hr_equipment_view_form", False)
             action_dict["views"] = [(res and res.id or False, "form")]
@@ -36,29 +37,25 @@ def action_view_equipments(self):
             action_dict = {"type": "ir.actions.act_window_close"}
         return action_dict
 
+    def _get_lines_to_create_equipments(self):
+        return self.order_line.filtered(
+            lambda x: (
+                x.product_qty > len(x.equipment_ids)
+                and x.product_id
+                and x.equipment_category_id
+            )
+        )
+
     def button_approve(self, force=False):
         result = super().button_approve(force=force)
-        equipment_model = self.env["maintenance.equipment"]
-        for order in self.filtered(lambda po: po.state in ("purchase", "done")):
-            for line in order.order_line.filtered(
-                lambda x: (
-                    not x.equipment_ids
-                    and x.product_id
-                    and x.product_id.product_tmpl_id.maintenance_ok
-                )
-            ):
-                if not line.equipment_category_id:
-                    line._set_equipment_category()
-                # Create equipments
-                limit = int(line.product_qty) + 1
-                vals = line._prepare_equipment_vals()
-                equipment_ids = []
-                for _i in range(1, limit):
-                    equipment = equipment_model.create(vals)
-                    equipment_ids.append((4, equipment.id))
-                line.equipment_ids = equipment_ids
+        self._create_equipments()
         return result
 
+    def _create_equipments(self):
+        for order in self.filtered(lambda po: po.state in ("purchase", "done")):
+            for line in order._get_lines_to_create_equipments():
+                line.create_equipments()
+
 
 class PurchaseOrderLine(models.Model):
     _inherit = "purchase.order.line"
@@ -70,8 +67,9 @@ class PurchaseOrderLine(models.Model):
         store=True,
         readonly=False,
     )
-    equipment_ids = fields.Many2many(
+    equipment_ids = fields.One2many(
         comodel_name="maintenance.equipment",
+        inverse_name="purchase_line_id",
         string="Equipments",
         copy=False,
     )
@@ -80,13 +78,11 @@ class PurchaseOrderLine(models.Model):
     @api.depends("product_id")
     def _compute_equipment_category_id(self):
         for item in self:
-            if (
-                item.product_id.maintenance_ok
-                and item.product_id.product_tmpl_id.categ_id.equipment_category_ids
-            ):
-                item.equipment_category_id = fields.first(
-                    item.product_id.product_tmpl_id.categ_id.equipment_category_ids
+            if item.product_id.product_tmpl_id.equipment_category_id:
+                item.equipment_category_id = (
+                    item.product_id.product_tmpl_id.equipment_category_id
                 )
+
             else:
                 item.equipment_category_id = item.equipment_category_id
 
@@ -100,37 +96,28 @@ def _compute_equipment_count(self):
         for item in self:
             item.equipment_count = mapping.get(item.id, 0)
 
-    def _prepare_equipment_category_vals(self):
-        categ = self.product_id.product_tmpl_id.categ_id
-        return {"name": categ.name, "product_category_id": categ.id}
+    def _qty_to_create_equipments(self):
+        return int(self.product_qty - len(self.equipment_ids))
 
-    def _set_equipment_category(self):
-        if not self.equipment_category_id:
-            category_model = self.env["maintenance.equipment.category"].sudo()
-            category = fields.first(
-                self.product_id.product_tmpl_id.categ_id.equipment_category_ids
-            )
-            if not category:
-                category = category_model.create(
-                    self._prepare_equipment_category_vals()
-                )
-            self.equipment_category_id = category.id
+    def create_equipments(self):
+        self.ensure_one()
+        equipment_model = self.env["maintenance.equipment"]
+        equipments = equipment_model.create(
+            [
+                self._prepare_equipment_vals()
+                for _ in range(self._qty_to_create_equipments())
+            ]
+        )
+        self.equipment_ids = [Command.link(eq.id) for eq in equipments]
+        return equipments
 
     def _prepare_equipment_vals(self):
         return {
             "purchase_line_id": self.id,
             "name": self.product_id.name,
-            "product_id": self.product_id.id,
             "category_id": self.equipment_category_id.id,
             "assign_date": self.order_id.date_order,
             "effective_date": self.order_id.date_planned,
             "partner_id": self.order_id.partner_id.id,
             "partner_ref": self.order_id.partner_ref,
         }
-
-    def _prepare_account_move_line(self, move=False):
-        result = super()._prepare_account_move_line(move=move)
-        result["equipment_ids"] = [
-            (4, equipment.id) for equipment in self.equipment_ids
-        ]
-        return result

maintenance_purchase/tests/test_purchase_order.py

@@ -1,11 +1,11 @@
 # Copyright 2024 ACSONE SA/NV
 # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
 
-from odoo import Command
-from odoo.tests.common import TransactionCase
 
+from odoo.addons.base.tests.common import BaseCommon
 
-class TestMaintenanceProject(TransactionCase):
+
+class TestMaintenanceProject(BaseCommon):
     @classmethod
     def setUpClass(cls):
         super().setUpClass()
@@ -35,22 +35,11 @@ def setUpClass(cls):
         cls.product_category01 = cls.ProductCategory.create(
             {
                 "name": "My Product Category 1",
-                "equipment_category_ids": [
-                    Command.set(
-                        [
-                            cls.maintenance_equipment_category1.id,
-                            cls.maintenance_equipment_category2.id,
-                        ]
-                    )
-                ],
             }
         )
         cls.product_category02 = cls.ProductCategory.create(
             {
                 "name": "My Product Category 2",
-                "equipment_category_ids": [
-                    Command.set([cls.maintenance_equipment_category2.id])
-                ],
             }
         )
         cls.product_order_maintenance = cls.ProductProduct.create(
@@ -64,8 +53,8 @@ def setUpClass(cls):
                 "purchase_method": "purchase",
                 "default_code": "PROD_ORDER",
                 "taxes_id": False,
-                "maintenance_ok": True,
                 "categ_id": cls.product_category01.id,
+                "equipment_category_id": cls.maintenance_equipment_category1.id,
             }
         )
         cls.product_order_no_maintenance = cls.ProductProduct.create(
@@ -89,7 +78,7 @@ def setUpClass(cls):
                 "partner_id": cls.partner.id,
             }
         )
-        PurchaseOrderLine = cls.PurchaseOrderLine.with_context(tracking_disable=True)
+        PurchaseOrderLine = cls.PurchaseOrderLine
         cls.purchase_line_order01 = PurchaseOrderLine.create(
             {
                 "name": cls.product_order_maintenance.name,
@@ -145,45 +134,16 @@ def test_equipment_category_id(self):
             self.maintenance_equipment_category1,
         )
         self.assertFalse(self.purchase_line_order02.equipment_category_id)
-        self.product_order_no_maintenance.product_tmpl_id.maintenance_ok = True
+        self.product_order_no_maintenance.product_tmpl_id.equipment_category_id = (
+            self.maintenance_equipment_category2
+        )
         self.assertFalse(self.purchase_line_order02.equipment_category_id)
         self.purchase_line_order02.product_id = self.product_order_maintenance
         self.purchase_line_order02.product_id = self.product_order_no_maintenance
         self.assertEqual(
             self.purchase_line_order02.equipment_category_id,
             self.maintenance_equipment_category2,
         )
-        self.purchase_line_order01.equipment_ids.unlink()
-        self.purchase_line_order01.equipment_category_id = False
-        self.purchase_order.button_approve()
-        self.assertEqual(
-            self.purchase_line_order01.equipment_category_id,
-            self.maintenance_equipment_category1,
-        )
-        self.purchase_line_order01.equipment_ids.unlink()
-        self.purchase_line_order01.equipment_category_id = False
-        product_category_withouth_equipement_category = self.ProductCategory.create(
-            {
-                "name": "My Product Category 2",
-            }
-        )
-        self.purchase_line_order01.product_id.product_tmpl_id.categ_id = (
-            product_category_withouth_equipement_category.id
-        )
-        self.purchase_order.button_approve()
-        self.assertTrue(self.purchase_line_order01.equipment_category_id)
-        self.assertNotEqual(
-            self.purchase_line_order01.equipment_category_id,
-            self.maintenance_equipment_category1,
-        )
-
-    def test_account_move_line(self):
-        self.purchase_order.button_approve()
-        self.purchase_order.action_create_invoice()
-        self.assertEqual(
-            self.purchase_order.order_line.equipment_ids,
-            self.purchase_order.invoice_ids.line_ids.equipment_ids,
-        )
 
     def test_action_view_equipments(self):
         action = self.purchase_order.action_view_equipments()

maintenance_purchase/views/maintenance_equipment.xml

@@ -7,8 +7,11 @@
         <field name="model">maintenance.equipment</field>
         <field name="inherit_id" ref="maintenance.hr_equipment_view_form" />
         <field name="arch" type="xml">
-            <xpath expr="//field[@name='serial_no']" position="after">
-                <field name="purchase_id" />
+            <xpath
+                expr="//page[@name='product_information']//field[@name='serial_no']"
+                position="after"
+            >
+                <field name="purchase_id" groups="purchase.group_purchase_user" />
             </xpath>
         </field>
     </record>

maintenance_purchase/views/product_template_view.xml

@@ -0,0 +1,13 @@
+<?xml version="1.0" encoding="utf-8" ?>
+<odoo>
+    <record id="product_template_form_view" model="ir.ui.view">
+        <field name="name">product.template.common.form</field>
+        <field name="model">product.template</field>
+        <field name="inherit_id" ref="product.product_template_form_view" />
+        <field name="arch" type="xml">
+            <xpath expr="//field[@name='categ_id']" position="after">
+                <field name="equipment_category_id" />
+            </xpath>
+        </field>
+    </record>
+</odoo>

maintenance_purchase/views/purchase_order.xml

@@ -13,7 +13,7 @@
                     type="object"
                     class="oe_stat_button"
                     icon="fa-cubes"
-                    attrs="{'invisible': [('equipment_count', '=', 0)]}"
+                    invisible="not equipment_count"
                 >
                     <field
                         string="Equipment(s)"
@@ -23,7 +23,7 @@
                 </button>
             </xpath>
             <xpath
-                expr="//notebook//field[@name='order_line']/tree/field[@name='product_qty']"
+                expr="//notebook//field[@name='order_line']/list/field[@name='product_qty']"
                 position="before"
             >
                 <field name="equipment_category_id" optional="hide" />