diff --git a/stock_whole_kit_constraint/README.rst b/stock_whole_kit_constraint/README.rst new file mode 100644 index 00000000000..8563b5f4ab5 --- /dev/null +++ b/stock_whole_kit_constraint/README.rst @@ -0,0 +1,104 @@ +========================== +Stock whole kit constraint +========================== + +.. + !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! + !! This file is generated by oca-gen-addon-readme !! + !! changes will be overwritten. !! + !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! + !! source digest: sha256:5120534d732382242fb7c08d6c274d5b30aaf71e9edbd2d7003a2177e436193c + !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! + +.. |badge1| image:: https://img.shields.io/badge/maturity-Beta-yellow.png + :target: https://odoo-community.org/page/development-status + :alt: Beta +.. |badge2| image:: https://img.shields.io/badge/licence-AGPL--3-blue.png + :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html + :alt: License: AGPL-3 +.. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fmanufacture-lightgray.png?logo=github + :target: https://github.com/OCA/manufacture/tree/17.0/stock_whole_kit_constraint + :alt: OCA/manufacture +.. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png + :target: https://translation.odoo-community.org/projects/manufacture-17-0/manufacture-17-0-stock_whole_kit_constraint + :alt: Translate me on Weblate +.. |badge5| image:: https://img.shields.io/badge/runboat-Try%20me-875A7B.png + :target: https://runboat.odoo-community.org/builds?repo=OCA/manufacture&target_branch=17.0 + :alt: Try me on Runboat + +|badge1| |badge2| |badge3| |badge4| |badge5| + +This module allows to configure a product that has a BoM of type kit to +disallow partial deliveries so that the components can't be partially +delivered. + +**Table of contents** + +.. contents:: + :local: + +Configuration +============= + +To allow/disallow the partial delivery of kits: + +1. Go to the kit product template or variant and then to the *Inventory* + tab, *Logistics* group. +2. The "Allow Partial Kit" check controls this. If marked, it will allow + it. +3. By default, the check is marked. + +Usage +===== + +To use this module, you need to: + +1. Make a delivery picking with a kit product. +2. Try to deliver it partially. +3. An error will raise. + +If you want to deliver other items in the picking you can do so and +leave the whole kit components units pending in a backorder. + +Bug Tracker +=========== + +Bugs are tracked on `GitHub Issues `_. +In case of trouble, please check there if your issue has already been reported. +If you spotted it first, help us to smash it by providing a detailed and welcomed +`feedback `_. + +Do not contact contributors directly about support or help with technical issues. + +Credits +======= + +Authors +------- + +* Tecnativa + +Contributors +------------ + +- Tecnativa \_\_ + + - David Vidal + - Pilar Vargas + +Maintainers +----------- + +This module is maintained by the OCA. + +.. image:: https://odoo-community.org/logo.png + :alt: Odoo Community Association + :target: https://odoo-community.org + +OCA, or the Odoo Community Association, is a nonprofit organization whose +mission is to support the collaborative development of Odoo features and +promote its widespread use. + +This module is part of the `OCA/manufacture `_ project on GitHub. + +You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute. diff --git a/stock_whole_kit_constraint/__init__.py b/stock_whole_kit_constraint/__init__.py new file mode 100644 index 00000000000..0650744f6bc --- /dev/null +++ b/stock_whole_kit_constraint/__init__.py @@ -0,0 +1 @@ +from . import models diff --git a/stock_whole_kit_constraint/__manifest__.py b/stock_whole_kit_constraint/__manifest__.py new file mode 100644 index 00000000000..3e490fd2432 --- /dev/null +++ b/stock_whole_kit_constraint/__manifest__.py @@ -0,0 +1,14 @@ +# Copyright 2021 Tecnativa - David Vidal +# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl). +{ + "name": "Stock whole kit constraint", + "summary": "Avoid to deliver a kit partially", + "version": "17.0.1.0.0", + "category": "Stock", + "website": "https://github.com/OCA/manufacture", + "author": "Tecnativa, Odoo Community Association (OCA)", + "license": "AGPL-3", + "installable": True, + "depends": ["mrp"], + "data": ["views/product_template_views.xml"], +} diff --git a/stock_whole_kit_constraint/i18n/es.po b/stock_whole_kit_constraint/i18n/es.po new file mode 100644 index 00000000000..c73315b3c89 --- /dev/null +++ b/stock_whole_kit_constraint/i18n/es.po @@ -0,0 +1,63 @@ +# Translation of Odoo Server. +# This file contains the translation of the following modules: +# * stock_whole_kit_constraint +# +msgid "" +msgstr "" +"Project-Id-Version: Odoo Server 12.0\n" +"Report-Msgid-Bugs-To: \n" +"POT-Creation-Date: 2021-03-19 10:39+0000\n" +"PO-Revision-Date: 2023-07-23 11:08+0000\n" +"Last-Translator: Ivorra78 \n" +"Language-Team: \n" +"Language: es\n" +"MIME-Version: 1.0\n" +"Content-Type: text/plain; charset=UTF-8\n" +"Content-Transfer-Encoding: 8bit\n" +"Plural-Forms: nplurals=2; plural=n != 1;\n" +"X-Generator: Weblate 4.17\n" + +#. module: stock_whole_kit_constraint +#: model:ir.model.fields,field_description:stock_whole_kit_constraint.field_product_product__allow_partial_kit_delivery +#: model:ir.model.fields,field_description:stock_whole_kit_constraint.field_product_template__allow_partial_kit_delivery +#: model:ir.model.fields,field_description:stock_whole_kit_constraint.field_stock_move__allow_partial_kit_delivery +msgid "Allow Partial Kit Delivery" +msgstr "Permitir entrega parcial de kit" + +#. module: stock_whole_kit_constraint +#: model:ir.model.fields,help:stock_whole_kit_constraint.field_product_product__allow_partial_kit_delivery +#: model:ir.model.fields,help:stock_whole_kit_constraint.field_product_template__allow_partial_kit_delivery +msgid "" +"If not set, and this product is delivered with a BoM of type kit, partial " +"deliveries of the components won't be allowed." +msgstr "" +"Si no se establece, y este producto se entrega con una lista de materiales " +"de tipo set, no se permitirán entregas parciales de los componentes." + +#. module: stock_whole_kit_constraint +#: model:ir.model,name:stock_whole_kit_constraint.model_product_template +msgid "Product Template" +msgstr "Plantilla de producto" + +#. module: stock_whole_kit_constraint +#: model:ir.model,name:stock_whole_kit_constraint.model_stock_move +msgid "Stock Move" +msgstr "Movimiento de existencias" + +#. module: stock_whole_kit_constraint +#: model:ir.model,name:stock_whole_kit_constraint.model_stock_picking +msgid "Transfer" +msgstr "Albarán" + +#. module: stock_whole_kit_constraint +#: code:addons/stock_whole_kit_constraint/models/stock_picking.py:0 +#, python-format +msgid "You can't make a partial delivery of components of the %s kit" +msgstr "No puede realizar una entrega parcial de los componentes del kit %s" + +#~ msgid "" +#~ "If not set when a kit product components are delivered, it won't be " +#~ "allowed to do it partially." +#~ msgstr "" +#~ "No no está activo, cuando haya una entrega con un kit, no se permitirá la " +#~ "entrega parcial de sus componentes." diff --git a/stock_whole_kit_constraint/i18n/it.po b/stock_whole_kit_constraint/i18n/it.po new file mode 100644 index 00000000000..deae8190a2f --- /dev/null +++ b/stock_whole_kit_constraint/i18n/it.po @@ -0,0 +1,65 @@ +# Translation of Odoo Server. +# This file contains the translation of the following modules: +# * stock_whole_kit_constraint +# +msgid "" +msgstr "" +"Project-Id-Version: Odoo Server 14.0\n" +"Report-Msgid-Bugs-To: \n" +"PO-Revision-Date: 2023-01-01 13:44+0000\n" +"Last-Translator: mymage \n" +"Language-Team: none\n" +"Language: it\n" +"MIME-Version: 1.0\n" +"Content-Type: text/plain; charset=UTF-8\n" +"Content-Transfer-Encoding: \n" +"Plural-Forms: nplurals=2; plural=n != 1;\n" +"X-Generator: Weblate 4.14.1\n" + +#. module: stock_whole_kit_constraint +#: model:ir.model.fields,field_description:stock_whole_kit_constraint.field_product_product__allow_partial_kit_delivery +#: model:ir.model.fields,field_description:stock_whole_kit_constraint.field_product_template__allow_partial_kit_delivery +#: model:ir.model.fields,field_description:stock_whole_kit_constraint.field_stock_move__allow_partial_kit_delivery +msgid "Allow Partial Kit Delivery" +msgstr "Consenti consegna confezione parziale" + +#. module: stock_whole_kit_constraint +#: model:ir.model.fields,help:stock_whole_kit_constraint.field_product_product__allow_partial_kit_delivery +#: model:ir.model.fields,help:stock_whole_kit_constraint.field_product_template__allow_partial_kit_delivery +msgid "" +"If not set, and this product is delivered with a BoM of type kit, partial " +"deliveries of the components won't be allowed." +msgstr "" +"Se non impostato e il prodotto viene consegnato con una DiBa di tipo " +"confezione, consegne parziali dei componenti non sono consentite." + +#. module: stock_whole_kit_constraint +#: model:ir.model,name:stock_whole_kit_constraint.model_product_template +msgid "Product Template" +msgstr "Modello prodotto" + +#. module: stock_whole_kit_constraint +#: model:ir.model,name:stock_whole_kit_constraint.model_stock_move +msgid "Stock Move" +msgstr "Movimento di magazzino" + +#. module: stock_whole_kit_constraint +#: model:ir.model,name:stock_whole_kit_constraint.model_stock_picking +msgid "Transfer" +msgstr "Trasferimento" + +#. module: stock_whole_kit_constraint +#: code:addons/stock_whole_kit_constraint/models/stock_picking.py:0 +#, python-format +msgid "You can't make a partial delivery of components of the %s kit" +msgstr "" +"Non si può fare una consegna parziale di componenti della confezione %s" + +#~ msgid "Display Name" +#~ msgstr "Nome visualizzato" + +#~ msgid "ID" +#~ msgstr "ID" + +#~ msgid "Last Modified on" +#~ msgstr "Ultima modifica il" diff --git a/stock_whole_kit_constraint/i18n/stock_whole_kit_constraint.pot b/stock_whole_kit_constraint/i18n/stock_whole_kit_constraint.pot new file mode 100644 index 00000000000..187af0b8a9e --- /dev/null +++ b/stock_whole_kit_constraint/i18n/stock_whole_kit_constraint.pot @@ -0,0 +1,50 @@ +# Translation of Odoo Server. +# This file contains the translation of the following modules: +# * stock_whole_kit_constraint +# +msgid "" +msgstr "" +"Project-Id-Version: Odoo Server 15.0\n" +"Report-Msgid-Bugs-To: \n" +"Last-Translator: \n" +"Language-Team: \n" +"MIME-Version: 1.0\n" +"Content-Type: text/plain; charset=UTF-8\n" +"Content-Transfer-Encoding: \n" +"Plural-Forms: \n" + +#. module: stock_whole_kit_constraint +#: model:ir.model.fields,field_description:stock_whole_kit_constraint.field_product_product__allow_partial_kit_delivery +#: model:ir.model.fields,field_description:stock_whole_kit_constraint.field_product_template__allow_partial_kit_delivery +#: model:ir.model.fields,field_description:stock_whole_kit_constraint.field_stock_move__allow_partial_kit_delivery +msgid "Allow Partial Kit Delivery" +msgstr "" + +#. module: stock_whole_kit_constraint +#: model:ir.model.fields,help:stock_whole_kit_constraint.field_product_product__allow_partial_kit_delivery +#: model:ir.model.fields,help:stock_whole_kit_constraint.field_product_template__allow_partial_kit_delivery +msgid "" +"If not set, and this product is delivered with a BoM of type kit, partial " +"deliveries of the components won't be allowed." +msgstr "" + +#. module: stock_whole_kit_constraint +#: model:ir.model,name:stock_whole_kit_constraint.model_product_template +msgid "Product Template" +msgstr "" + +#. module: stock_whole_kit_constraint +#: model:ir.model,name:stock_whole_kit_constraint.model_stock_move +msgid "Stock Move" +msgstr "" + +#. module: stock_whole_kit_constraint +#: model:ir.model,name:stock_whole_kit_constraint.model_stock_picking +msgid "Transfer" +msgstr "" + +#. module: stock_whole_kit_constraint +#: code:addons/stock_whole_kit_constraint/models/stock_picking.py:0 +#, python-format +msgid "You can't make a partial delivery of components of the %s kit" +msgstr "" diff --git a/stock_whole_kit_constraint/models/__init__.py b/stock_whole_kit_constraint/models/__init__.py new file mode 100644 index 00000000000..7e2c2a89193 --- /dev/null +++ b/stock_whole_kit_constraint/models/__init__.py @@ -0,0 +1,3 @@ +from . import product_template +from . import stock_move +from . import stock_picking diff --git a/stock_whole_kit_constraint/models/product_template.py b/stock_whole_kit_constraint/models/product_template.py new file mode 100644 index 00000000000..20716a1b8c8 --- /dev/null +++ b/stock_whole_kit_constraint/models/product_template.py @@ -0,0 +1,23 @@ +# Copyright 2021 Tecnativa - David Vidal +# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl). +from odoo import api, fields, models + + +class ProductTemplate(models.Model): + _inherit = "product.template" + + allow_partial_kit_delivery = fields.Boolean( + default=True, + help="If not set, and this product is delivered with a BoM of type " + "kit, partial deliveries of the components won't be allowed.", + ) + display_allow_partial_kit_delivery = fields.Boolean( + compute="_compute_display_allow_partial_kit_delivery", + ) + + @api.depends("bom_count", "type") + def _compute_display_allow_partial_kit_delivery(self): + for record in self: + record.display_allow_partial_kit_delivery = ( + record.bom_count > 0 and record.type in ["consu", "product"] + ) diff --git a/stock_whole_kit_constraint/models/stock_move.py b/stock_whole_kit_constraint/models/stock_move.py new file mode 100644 index 00000000000..8a0da2ee9f6 --- /dev/null +++ b/stock_whole_kit_constraint/models/stock_move.py @@ -0,0 +1,52 @@ +# Copyright 2021 Tecnativa - David Vidal +# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl). +from odoo import api, fields, models + + +class StockMove(models.Model): + _inherit = "stock.move" + + allow_partial_kit_delivery = fields.Boolean( + compute="_compute_allow_partial_kit_delivery", + compute_sudo=True, + ) + + @api.depends("product_id.product_tmpl_id.allow_partial_kit_delivery", "state") + def _compute_allow_partial_kit_delivery(self): + """Take it from the product only if it's a kit""" + self.write({"allow_partial_kit_delivery": True}) + for move in self.filtered( + lambda x: x.product_id and x.state not in ["done", "cancel"] + ): + # If it isn't a kit it will always be True + if not move.bom_line_id or move.bom_line_id.bom_id.type != "phantom": + move.allow_partial_kit_delivery = True + continue + move.allow_partial_kit_delivery = ( + move.bom_line_id.bom_id.product_tmpl_id.allow_partial_kit_delivery + ) + + def _check_backorder_moves(self): + """Check if there are partial deliveries on any set of moves. The + computing is done in the same way the main picking method does it""" + quantity_todo = {} + quantity_done = {} + for move in self: + quantity_todo.setdefault(move.product_id.id, 0) + quantity_done.setdefault(move.product_id.id, 0) + quantity_todo[move.product_id.id] += move.product_uom_qty + quantity_done[move.product_id.id] += move.quantity + for ops in self.mapped("move_line_ids").filtered( + lambda x: x.package_id and not x.product_id and not x.move_id + ): + for quant in ops.package_id.quant_ids: + quantity_done.setdefault(quant.product_id.id, 0) + quantity_done[quant.product_id.id] += quant.quantity + for pack in self.mapped("move_line_ids").filtered( + lambda x: x.product_id and not x.move_id + ): + quantity_done.setdefault(pack.product_id.id, 0) + quantity_done[pack.product_id.id] += pack.product_uom_id._compute_quantity( + pack.quantity, pack.product_id.uom_id + ) + return any(quantity_done[x] < quantity_todo.get(x, 0) for x in quantity_done) diff --git a/stock_whole_kit_constraint/models/stock_picking.py b/stock_whole_kit_constraint/models/stock_picking.py new file mode 100644 index 00000000000..3d015f00cb7 --- /dev/null +++ b/stock_whole_kit_constraint/models/stock_picking.py @@ -0,0 +1,30 @@ +# Copyright 2021 Tecnativa - David Vidal +# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl). +from odoo import _, models +from odoo.exceptions import ValidationError + + +class StockPicking(models.Model): + _inherit = "stock.picking" + + def _check_backorder(self): + """On the moment of the picking validation, we'll check wether there + are kits that can't be partially delivered or not""" + moves = self.mapped("move_ids").filtered( + lambda x: not x.allow_partial_kit_delivery and x.bom_line_id + ) + boms = moves.mapped("bom_line_id.bom_id") + for bom in boms: + bom_moves = moves.filtered(lambda x, bm=bom: x.bom_line_id.bom_id == bm) + # We can put it in backorder if the whole kit goes + if not sum(bom_moves.mapped("quantity")): + continue + if bom_moves._check_backorder_moves(): + raise ValidationError( + _( + "You can't make a partial delivery of components of the " + "%s kit", + bom.product_tmpl_id.display_name, + ) + ) + return super()._check_backorder() diff --git a/stock_whole_kit_constraint/pyproject.toml b/stock_whole_kit_constraint/pyproject.toml new file mode 100644 index 00000000000..4231d0cccb3 --- /dev/null +++ b/stock_whole_kit_constraint/pyproject.toml @@ -0,0 +1,3 @@ +[build-system] +requires = ["whool"] +build-backend = "whool.buildapi" diff --git a/stock_whole_kit_constraint/readme/CONFIGURE.md b/stock_whole_kit_constraint/readme/CONFIGURE.md new file mode 100644 index 00000000000..4f805587a10 --- /dev/null +++ b/stock_whole_kit_constraint/readme/CONFIGURE.md @@ -0,0 +1,7 @@ +To allow/disallow the partial delivery of kits: + +1. Go to the kit product template or variant and then to the + *Inventory* tab, *Logistics* group. +2. The "Allow Partial Kit" check controls this. If marked, it will + allow it. +3. By default, the check is marked. diff --git a/stock_whole_kit_constraint/readme/CONTRIBUTORS.md b/stock_whole_kit_constraint/readme/CONTRIBUTORS.md new file mode 100644 index 00000000000..03996f30ed2 --- /dev/null +++ b/stock_whole_kit_constraint/readme/CONTRIBUTORS.md @@ -0,0 +1,3 @@ +- Tecnativa \<\>\_\_ + - David Vidal + - Pilar Vargas diff --git a/stock_whole_kit_constraint/readme/DESCRIPTION.md b/stock_whole_kit_constraint/readme/DESCRIPTION.md new file mode 100644 index 00000000000..8f6a9975fda --- /dev/null +++ b/stock_whole_kit_constraint/readme/DESCRIPTION.md @@ -0,0 +1,3 @@ +This module allows to configure a product that has a BoM of type kit to +disallow partial deliveries so that the components can't be partially +delivered. diff --git a/stock_whole_kit_constraint/readme/USAGE.md b/stock_whole_kit_constraint/readme/USAGE.md new file mode 100644 index 00000000000..4f74b1ced01 --- /dev/null +++ b/stock_whole_kit_constraint/readme/USAGE.md @@ -0,0 +1,8 @@ +To use this module, you need to: + +1. Make a delivery picking with a kit product. +2. Try to deliver it partially. +3. An error will raise. + +If you want to deliver other items in the picking you can do so and +leave the whole kit components units pending in a backorder. diff --git a/stock_whole_kit_constraint/static/description/icon.png b/stock_whole_kit_constraint/static/description/icon.png new file mode 100644 index 00000000000..757fd5906ef Binary files /dev/null and b/stock_whole_kit_constraint/static/description/icon.png differ diff --git a/stock_whole_kit_constraint/static/description/index.html b/stock_whole_kit_constraint/static/description/index.html new file mode 100644 index 00000000000..3d2c4f0cca8 --- /dev/null +++ b/stock_whole_kit_constraint/static/description/index.html @@ -0,0 +1,453 @@ + + + + + +Stock whole kit constraint + + + +
+

Stock whole kit constraint

+ + +

Beta License: AGPL-3 OCA/manufacture Translate me on Weblate Try me on Runboat

+

This module allows to configure a product that has a BoM of type kit to +disallow partial deliveries so that the components can’t be partially +delivered.

+

Table of contents

+ +
+

Configuration

+

To allow/disallow the partial delivery of kits:

+
    +
  1. Go to the kit product template or variant and then to the Inventory +tab, Logistics group.
    2. +
  2. The “Allow Partial Kit” check controls this. If marked, it will allow +it.
    3. +
  3. By default, the check is marked.
    4. +
+
+
+

Usage

+

To use this module, you need to:

+
    +
  1. Make a delivery picking with a kit product.
    2. +
  2. Try to deliver it partially.
    3. +
  3. An error will raise.
    4. +
+

If you want to deliver other items in the picking you can do so and +leave the whole kit components units pending in a backorder.

+
+
+

Bug Tracker

+

Bugs are tracked on GitHub Issues. +In case of trouble, please check there if your issue has already been reported. +If you spotted it first, help us to smash it by providing a detailed and welcomed +feedback.

+

Do not contact contributors directly about support or help with technical issues.

+
+
+

Credits

+
+

Authors

+
    +
  • Tecnativa
    • +
+
+
+

Contributors

+ +
+
+

Maintainers

+

This module is maintained by the OCA.

+ +Odoo Community Association + +

OCA, or the Odoo Community Association, is a nonprofit organization whose +mission is to support the collaborative development of Odoo features and +promote its widespread use.

+

This module is part of the OCA/manufacture project on GitHub.

+

You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute.

+
+
+
+ + diff --git a/stock_whole_kit_constraint/tests/__init__.py b/stock_whole_kit_constraint/tests/__init__.py new file mode 100644 index 00000000000..5eb9fbc7cd7 --- /dev/null +++ b/stock_whole_kit_constraint/tests/__init__.py @@ -0,0 +1 @@ +from . import test_stock_whole_kit_constraint diff --git a/stock_whole_kit_constraint/tests/test_stock_whole_kit_constraint.py b/stock_whole_kit_constraint/tests/test_stock_whole_kit_constraint.py new file mode 100644 index 00000000000..85e04295b2a --- /dev/null +++ b/stock_whole_kit_constraint/tests/test_stock_whole_kit_constraint.py @@ -0,0 +1,163 @@ +# Copyright 2021 Tecnativa - David Vidal +# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl). +from odoo.exceptions import ValidationError +from odoo.tests import Form, common + + +class TestStockWholeKitConstraint(common.TransactionCase): + @classmethod + def setUpClass(cls): + super().setUpClass() + cls.customer = cls.env["res.partner"].create({"name": "Mr. Odoo"}) + # Kit 1 that can be partially delivered + cls.product_kit_1 = cls.env["product.product"].create( + {"name": "Product Kit 1", "type": "consu"} + ) + cls.component_1_kit_1 = cls.env["product.product"].create( + {"name": "Component 1 Kit 1", "type": "product"} + ) + cls.component_2_kit_1 = cls.env["product.product"].create( + {"name": "Component 2 Kit 1", "type": "product"} + ) + bom_form = Form(cls.env["mrp.bom"]) + bom_form.product_tmpl_id = cls.product_kit_1.product_tmpl_id + bom_form.product_id = cls.product_kit_1 + bom_form.type = "phantom" + with bom_form.bom_line_ids.new() as line: + line.product_id = cls.component_1_kit_1 + with bom_form.bom_line_ids.new() as line: + line.product_id = cls.component_2_kit_1 + cls.bom_kit_1 = bom_form.save() + # Kit 2 - disallow partial deliveries + cls.product_kit_2 = cls.env["product.product"].create( + { + "name": "Product Kit 2", + "type": "consu", + "allow_partial_kit_delivery": False, + } + ) + cls.component_1_kit_2 = cls.env["product.product"].create( + {"name": "Component 1 Kit 2", "type": "product"} + ) + cls.component_2_kit_2 = cls.env["product.product"].create( + {"name": "Component 2 Kit 2", "type": "product"} + ) + bom_form = Form(cls.env["mrp.bom"]) + bom_form.product_tmpl_id = cls.product_kit_2.product_tmpl_id + bom_form.product_id = cls.product_kit_2 + bom_form.type = "phantom" + with bom_form.bom_line_ids.new() as line: + line.product_id = cls.component_1_kit_2 + with bom_form.bom_line_ids.new() as line: + line.product_id = cls.component_2_kit_2 + cls.bom_kit_2 = bom_form.save() + # Manufactured product as control + cls.product_mrp = cls.env["product.product"].create( + { + "name": "Product Kit 2", + "type": "consu", + # Force the setting in a manufactured product. + # It should not affect it + "allow_partial_kit_delivery": False, + } + ) + bom_form = Form(cls.env["mrp.bom"]) + bom_form.product_tmpl_id = cls.product_mrp.product_tmpl_id + bom_form.product_id = cls.product_mrp + bom_form.type = "normal" + with bom_form.bom_line_ids.new() as line: + line.product_id = cls.component_1_kit_2 + cls.bom_mrp = bom_form.save() + # Not a kit product as control + cls.regular_product = cls.env["product.product"].create( + { + "name": "Regular test product", + "type": "product", + # Force the setting in a regular product. It should not affect it + "allow_partial_kit_delivery": False, + } + ) + # Add stock for components to allow pickings to be 'done' + components = ( + cls.component_1_kit_1 + + cls.component_2_kit_1 + + cls.component_1_kit_2 + + cls.component_2_kit_2 + + cls.regular_product + ) + for component in components: + cls.env["stock.quant"]._update_available_quantity( + component, cls.env.ref("stock.stock_location_stock"), 100 + ) + # Delivery picking + picking_form = Form(cls.env["stock.picking"]) + picking_form.picking_type_id = cls.env.ref("stock.picking_type_out") + picking_form.partner_id = cls.customer + with picking_form.move_ids_without_package.new() as move: + move.product_id = cls.product_kit_1 + move.product_uom_qty = 3.0 + with picking_form.move_ids_without_package.new() as move: + move.product_id = cls.product_kit_2 + move.product_uom_qty = 3.0 + with picking_form.move_ids_without_package.new() as move: + move.product_id = cls.product_mrp + move.product_uom_qty = 3.0 + with picking_form.move_ids_without_package.new() as move: + move.product_id = cls.regular_product + move.product_uom_qty = 3.0 + cls.customer_picking = picking_form.save() + cls.customer_picking.action_confirm() + + def test_01_all_partially_done_but_the_disallow_partial_kit(self): + """No quantity is done for the kit disallowed and only partially for the + others so the backorder wizard raises.""" + self.customer_picking.move_ids.move_line_ids.quantity = 0 + moves_allowed = self.customer_picking.move_ids.filtered( + lambda x: x.bom_line_id.bom_id != self.bom_kit_2 + ) + moves_allowed.move_line_ids.quantity = 1 + response = self.customer_picking.button_validate() + self.assertEqual("stock.backorder.confirmation", response.get("res_model")) + + def test_02_all_done_but_partial_disallow_partial_kit(self): + """We try to deliver partially the disallowed kit""" + self.customer_picking.move_ids.move_line_ids.quantity = 0 + moves_disallowed = self.customer_picking.move_ids.filtered( + lambda x: x.bom_line_id.bom_id == self.bom_kit_2 + ) + moves_disallowed.move_line_ids.quantity = 1 + with self.assertRaises(ValidationError): + self.customer_picking.button_validate() + # We can split the picking if the whole kit components are delivered + moves_disallowed.move_line_ids.quantity = 3 + # We've got a backorder on the rest of the lines + response = self.customer_picking.button_validate() + self.assertEqual("stock.backorder.confirmation", response.get("res_model")) + + def test_03_all_done(self): + """Deliver the whole picking normally""" + for move in self.customer_picking.move_ids: + move.move_line_ids.quantity = move.product_uom_qty + self.customer_picking.button_validate() + self.assertEqual("done", self.customer_picking.state) + + def test_04_manual_move_lines(self): + """If a user adds manual operations, we should consider it as well""" + self.customer_picking.move_ids.move_line_ids.quantity = 0 + for product in (self.bom_kit_1 + self.bom_kit_2).mapped( + "bom_line_ids.product_id" + ): + self.env["stock.move.line"].create( + { + "picking_id": self.customer_picking.id, + "product_id": product.id, + "quantity": 3, + "location_id": self.customer_picking.location_id.id, + "location_dest_id": self.customer_picking.location_dest_id.id, + } + ) + self.customer_picking.move_ids.filtered( + lambda x: x.product_id in (self.product_mrp, self.regular_product) + ).move_line_ids.quantity = 3 + self.customer_picking.button_validate() + self.assertEqual("done", self.customer_picking.state) diff --git a/stock_whole_kit_constraint/views/product_template_views.xml b/stock_whole_kit_constraint/views/product_template_views.xml new file mode 100644 index 00000000000..879cfd584a1 --- /dev/null +++ b/stock_whole_kit_constraint/views/product_template_views.xml @@ -0,0 +1,33 @@ + + + + + product.template + + + + + + + + + + product.product + + + + + + + + + +