correct way to import / use this lib

[legalsylvain]

Hi,

The OCA module pos_pricelist (v10.0) is using this lib since a few days. Even the import is protected, the code is broken any installation that has no this lib installed, even if the module is not installed.

What is the good way to import & use this lib, without breaking such deployment.

OCA/pos#249

kind regard.

[hbrunn]

I think something like

try:
    from oca.decorators import foreach
except ImportError:
    foreach = lambda x: x

could do the trick. For every decorator we import, we declare it to be the identity function if the import fails. Then we don't need the ugly catch all import.

[yajo]

I think that is a good workaround, although it should violate some pylint/flake8 too. By adding a # noqa to the except it should be OK.

[yajo]

However, there's a problem here that we've been struggling all the life: why in the world do we need to fake a requirement? If the addon is not installed and it produces an ImportError... why should Odoo care at all? It's what should happen, because there's actually an import error! We should fix Odoo I think.

[legalsylvain]

Thanks a lot @hbrunn. I think we should add an help in the documentation of this library.

We should fix Odoo I think.

@yajo : 100% agree with you, but an other (big) story I think.

[yajo]

Cool, it seems we're just late to the party.

The fix landed in master some months ago.

I think we could backport it to OCB and merge OCA/pylint-odoo#182 once for all and just stop supporting this precise kind of fixes for non OCB builds.

Would you agree?
cc @pedrobaeza

[pedrobaeza]

Well, as we need to keep the tricks for Odoo part, it's not worth to backport it.

[yajo]

I was talking about providing different kind of fixes:

• if you use OCB, it's fixed out of the box.
• if you use odoo, the fix is to add the dependency.

So both versions are "supported" but we don't care anymore about this.

[hparfr]

I was talking about providing different kind of fixes:
if you use OCB, it's fixed out of the box.
if you use odoo, the fix is to add the dependency.
So both versions are "supported" but we don't care anymore about this.

LGTM 👍

[yajo]

I'm thinking that there's a still easier solution:

1. in versions < 12.0, use @api.one
2. in versions >= 12.0 (when available), use this lib in OCA freely.