[IMP] payroll_contract_advantages: add tests

Author: CristianoMafraJunior

payroll_contract_advantages/README.rst

@@ -70,6 +70,7 @@ Contributors
 ------------
 
 - Nimarosa (Nicolas Rodriguez) <[email protected]>
+- Cristiano Mafra Junior <[email protected]>
 
 Maintainers
 -----------

payroll_contract_advantages/readme/CONTRIBUTORS.md

@@ -1 +1,2 @@
 - Nimarosa (Nicolas Rodriguez) \<[email protected]\>
+- Cristiano Mafra Junior \<[email protected]\>

payroll_contract_advantages/static/description/index.html

@@ -418,6 +418,7 @@ <h2><a class="toc-backref" href="#toc-entry-4">Authors</a></h2>
 <h2><a class="toc-backref" href="#toc-entry-5">Contributors</a></h2>
 <ul class="simple">
 <li>Nimarosa (Nicolas Rodriguez) &lt;<a class="reference external" href="mailto:nicolasrsande&#64;gmail.com">nicolasrsande&#64;gmail.com</a>&gt;</li>
+<li>Cristiano Mafra Junior &lt;<a class="reference external" href="mailto:cristiano.mafra&#64;escodoo.com.br">cristiano.mafra&#64;escodoo.com.br</a>&gt;</li>
 </ul>
 </div>
 <div class="section" id="maintainers">

payroll_contract_advantages/tests/__init__.py

@@ -0,0 +1 @@
+from . import test_payroll_contract_advantages

payroll_contract_advantages/tests/test_payroll_contract_advantages.py

@@ -0,0 +1,116 @@
+# Copyright 2025 - TODAY, Cristiano Mafra Junior <[email protected]>
+# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
+
+from odoo.exceptions import ValidationError
+
+from odoo.addons.payroll.tests.common import TestPayslipBase
+
+
+class TestPayrollContractAdvantages(TestPayslipBase):
+    def setUp(self):
+        super().setUp()
+        self.AdvantageTemplate = self.env["hr.contract.advantage.template"]
+        self.Advantage = self.env["hr.contract.advantage"]
+
+    def _create_template(
+        self,
+        *,
+        lower=0.0,
+        upper=100.0,
+        default=10.0,
+        code="BEN",
+        name="Benefit",
+    ):
+        return self.AdvantageTemplate.create(
+            {
+                "name": name,
+                "code": code,
+                "lower_bound": lower,
+                "upper_bound": upper,
+                "default_value": default,
+            }
+        )
+
+    def test_onchange_advantage_template_sets_default_amount(self):
+        """Onchange should set amount from template default value."""
+        template = self._create_template(default=123.45)
+        advantage = self.Advantage.new(
+            {
+                "contract_id": self.richard_contract.id,
+                "advantage_template_id": template.id,
+            }
+        )
+
+        advantage._onchange_advantage_template_id()
+
+        self.assertEqual(advantage.amount, template.default_value)
+
+    def test_constraint_allows_amount_inside_bounds(self):
+        """Constraint should allow amount inside bounds."""
+        template = self._create_template(lower=0.0, upper=100.0)
+
+        advantage = self.Advantage.create(
+            {
+                "contract_id": self.richard_contract.id,
+                "advantage_template_id": template.id,
+                "amount": 50.0,
+            }
+        )
+
+        self.assertEqual(advantage.amount, 50.0)
+
+    def test_constraint_raises_if_above_upper_bound(self):
+        """Constraint should raise when amount is above upper bound."""
+        template = self._create_template(lower=0.0, upper=100.0)
+
+        with self.assertRaises(ValidationError):
+            self.Advantage.create(
+                {
+                    "contract_id": self.richard_contract.id,
+                    "advantage_template_id": template.id,
+                    "amount": 150.0,
+                }
+            )
+
+    def test_constraint_raises_if_below_lower_bound(self):
+        """Constraint should raise when amount is below lower bound."""
+        template = self._create_template(lower=10.0, upper=100.0)
+
+        with self.assertRaises(ValidationError):
+            self.Advantage.create(
+                {
+                    "contract_id": self.richard_contract.id,
+                    "advantage_template_id": template.id,
+                    "amount": 5.0,
+                }
+            )
+
+    def test_get_current_contract_dict_contains_advantages(self):
+        """get_current_contract_dict should expose advantages by code."""
+        template = self._create_template(
+            lower=0.0,
+            upper=100.0,
+            default=25.0,
+            code="FUEL",
+            name="Fuel Allowance",
+        )
+
+        self.Advantage.create(
+            {
+                "contract_id": self.richard_contract.id,
+                "advantage_template_id": template.id,
+                "amount": 30.0,
+            }
+        )
+
+        self.apply_contract_cron()
+
+        payslip = self.Payslip.create({"employee_id": self.richard_emp.id})
+        payslip.onchange_employee()
+        contracts = payslip._get_employee_contracts()
+
+        res = payslip.get_current_contract_dict(self.richard_contract, contracts)
+        advantages = res.get("advantages")
+
+        self.assertIsNotNone(advantages)
+        self.assertEqual(advantages.FUEL, 30.0)