[MIG] pos_partner_sale_warning: Migration to 17.0

edescalona · edescalona · commit 7f44b0079291 · 2025-05-20T14:55:36.000-05:00
diff --git a/pos_partner_sale_warning/README.rst b/pos_partner_sale_warning/README.rst
@@ -17,13 +17,13 @@ POS Partner Sale Warnings
     :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html
     :alt: License: AGPL-3
 .. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fpos-lightgray.png?logo=github
-    :target: https://github.com/OCA/pos/tree/16.0/pos_partner_sale_warning
+    :target: https://github.com/OCA/pos/tree/17.0/pos_partner_sale_warning
     :alt: OCA/pos
 .. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png
-    :target: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_partner_sale_warning
+    :target: https://translation.odoo-community.org/projects/pos-17-0/pos-17-0-pos_partner_sale_warning
     :alt: Translate me on Weblate
 .. |badge5| image:: https://img.shields.io/badge/runboat-Try%20me-875A7B.png
-    :target: https://runboat.odoo-community.org/builds?repo=OCA/pos&target_branch=16.0
+    :target: https://runboat.odoo-community.org/builds?repo=OCA/pos&target_branch=17.0
     :alt: Try me on Runboat
 
 |badge1| |badge2| |badge3| |badge4| |badge5|
@@ -74,7 +74,7 @@ Bug Tracker
 Bugs are tracked on `GitHub Issues <https://github.com/OCA/pos/issues>`_.
 In case of trouble, please check there if your issue has already been reported.
 If you spotted it first, help us to smash it by providing a detailed and welcomed
-`feedback <https://github.com/OCA/pos/issues/new?body=module:%20pos_partner_sale_warning%0Aversion:%2016.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
+`feedback <https://github.com/OCA/pos/issues/new?body=module:%20pos_partner_sale_warning%0Aversion:%2017.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
 
 Do not contact contributors directly about support or help with technical issues.
 
@@ -89,10 +89,10 @@ Authors
 Contributors
 ------------
 
--  Cetmix <cetmix.com>
+- Cetmix <cetmix.com>
 
-   -  Ivan Sokolov
-   -  Maksim Shurupov
+  - Ivan Sokolov
+  - Maksim Shurupov
 
 Maintainers
 -----------
@@ -107,6 +107,6 @@ OCA, or the Odoo Community Association, is a nonprofit organization whose
 mission is to support the collaborative development of Odoo features and
 promote its widespread use.
 
-This module is part of the `OCA/pos <https://github.com/OCA/pos/tree/16.0/pos_partner_sale_warning>`_ project on GitHub.
+This module is part of the `OCA/pos <https://github.com/OCA/pos/tree/17.0/pos_partner_sale_warning>`_ project on GitHub.
 
 You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute.
diff --git a/pos_partner_sale_warning/__manifest__.py b/pos_partner_sale_warning/__manifest__.py
@@ -3,7 +3,7 @@
 
 {
     "name": "POS Partner Sale Warnings",
-    "version": "16.0.1.0.0",
+    "version": "17.0.1.0.0",
     "category": "Sales/Point of Sale",
     "summary": "Show partner sales warning in POS",
     "depends": ["sale_management", "point_of_sale"],
@@ -12,11 +12,11 @@
     "license": "AGPL-3",
     "data": [],
     "assets": {
-        "point_of_sale.assets": [
+        "point_of_sale._assets_pos": [
             "pos_partner_sale_warning/static/src/js/*.esm.js",
         ],
         "web.assets_tests": [
-            "pos_partner_sale_warning/static/src/tests/tours/PosPartnerSaleWarning.esm.tour.js",
+            "pos_partner_sale_warning/static/src/tests/tours/PosPartnerSaleWarning.esm.js",
         ],
     },
     "installable": True,
diff --git a/pos_partner_sale_warning/static/description/index.html b/pos_partner_sale_warning/static/description/index.html
@@ -1,4 +1,3 @@
-<?xml version="1.0" encoding="utf-8"?>
 <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
 <html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en">
 <head>
@@ -9,10 +8,11 @@
 
 /*
 :Author: David Goodger (goodger@python.org)
-:Id: $Id: html4css1.css 8954 2022-01-20 10:10:25Z milde $
+:Id: $Id: html4css1.css 9511 2024-01-13 09:50:07Z milde $
 :Copyright: This stylesheet has been placed in the public domain.
 
 Default cascading style sheet for the HTML output of Docutils.
+Despite the name, some widely supported CSS2 features are used.
 
 See https://docutils.sourceforge.io/docs/howto/html-stylesheets.html for how to
 customize this style sheet.
@@ -275,7 +275,7 @@
   margin-left: 2em ;
   margin-right: 2em }
 
-pre.code .ln { color: grey; } /* line numbers */
+pre.code .ln { color: gray; } /* line numbers */
 pre.code, code { background-color: #eeeeee }
 pre.code .comment, code .comment { color: #5C6576 }
 pre.code .keyword, code .keyword { color: #3B0D06; font-weight: bold }
@@ -301,7 +301,7 @@
 span.pre {
   white-space: pre }
 
-span.problematic {
+span.problematic, pre.problematic {
   color: red }
 
 span.section-subtitle {
@@ -369,7 +369,7 @@ <h1 class="title">POS Partner Sale Warnings</h1>
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
 !! source digest: sha256:785171ea5bffb78bc4fdbf43155a0614913d7eca35d68963a7416c7264b5613d
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! -->
-<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/licence-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/pos/tree/16.0/pos_partner_sale_warning"><img alt="OCA/pos" src="https://img.shields.io/badge/github-OCA%2Fpos-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_partner_sale_warning"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/pos&amp;target_branch=16.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
+<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/licence-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/pos/tree/17.0/pos_partner_sale_warning"><img alt="OCA/pos" src="https://img.shields.io/badge/github-OCA%2Fpos-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/pos-17-0/pos-17-0-pos_partner_sale_warning"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/pos&amp;target_branch=17.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
 <p>This module shows partner warnings when a partner is selected in POS.</p>
 <p><strong>Table of contents</strong></p>
 <div class="contents local topic" id="contents">
@@ -417,7 +417,7 @@ <h1><a class="toc-backref" href="#toc-entry-5">Bug Tracker</a></h1>
 <p>Bugs are tracked on <a class="reference external" href="https://github.com/OCA/pos/issues">GitHub Issues</a>.
 In case of trouble, please check there if your issue has already been reported.
 If you spotted it first, help us to smash it by providing a detailed and welcomed
-<a class="reference external" href="https://github.com/OCA/pos/issues/new?body=module:%20pos_partner_sale_warning%0Aversion:%2016.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
+<a class="reference external" href="https://github.com/OCA/pos/issues/new?body=module:%20pos_partner_sale_warning%0Aversion:%2017.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
 <p>Do not contact contributors directly about support or help with technical issues.</p>
 </div>
 <div class="section" id="credits">
@@ -441,11 +441,13 @@ <h2><a class="toc-backref" href="#toc-entry-8">Contributors</a></h2>
 <div class="section" id="maintainers">
 <h2><a class="toc-backref" href="#toc-entry-9">Maintainers</a></h2>
 <p>This module is maintained by the OCA.</p>
-<a class="reference external image-reference" href="https://odoo-community.org"><img alt="Odoo Community Association" src="https://odoo-community.org/logo.png" /></a>
+<a class="reference external image-reference" href="https://odoo-community.org">
+<img alt="Odoo Community Association" src="https://odoo-community.org/logo.png" />
+</a>
 <p>OCA, or the Odoo Community Association, is a nonprofit organization whose
 mission is to support the collaborative development of Odoo features and
 promote its widespread use.</p>
-<p>This module is part of the <a class="reference external" href="https://github.com/OCA/pos/tree/16.0/pos_partner_sale_warning">OCA/pos</a> project on GitHub.</p>
+<p>This module is part of the <a class="reference external" href="https://github.com/OCA/pos/tree/17.0/pos_partner_sale_warning">OCA/pos</a> project on GitHub.</p>
 <p>You are welcome to contribute. To learn how please visit <a class="reference external" href="https://odoo-community.org/page/Contribute">https://odoo-community.org/page/Contribute</a>.</p>
 </div>
 </div>
diff --git a/pos_partner_sale_warning/static/src/js/PartnerListScreen.esm.js b/pos_partner_sale_warning/static/src/js/PartnerListScreen.esm.js
@@ -1,29 +1,33 @@
 /** @odoo-module **/
 
-import PartnerListScreen from "point_of_sale.PartnerListScreen";
-import Registries from "point_of_sale.Registries";
-import {sprintf} from "web.utils";
+import {ErrorPopup} from "@point_of_sale/app/errors/popups/error_popup";
+import {PartnerListScreen} from "@point_of_sale/app/screens/partner_list/partner_list";
+import {_t} from "@web/core/l10n/translation";
+import {patch} from "@web/core/utils/patch";
+import {sprintf} from "@web/core/utils/strings";
+import {useService} from "@web/core/utils/hooks";
 
-export const PartnerListScreenWarning = (PartnerListScreen) =>
-    class extends PartnerListScreen {
-        clickPartner(partner) {
-            if (
-                this.state.selectedPartner &&
-                this.state.selectedPartner.id === partner.id
-            ) {
-                return super.clickPartner(partner);
-            }
-            if (partner && partner.sale_warn && partner.sale_warn !== "no-message") {
-                this.showPopup("ErrorPopup", {
-                    title: sprintf(this.env._t("Warning for %s"), partner.name),
-                    body: partner.sale_warn_msg,
-                });
-                if (partner.sale_warn === "block") {
-                    return;
-                }
-            }
+patch(PartnerListScreen.prototype, {
+    setup() {
+        super.setup();
+        this.popup = useService("popup");
+    },
+    clickPartner(partner) {
+        if (
+            this.state.selectedPartner &&
+            this.state.selectedPartner.id === partner.id
+        ) {
             return super.clickPartner(partner);
         }
-    };
-
-Registries.Component.extend(PartnerListScreen, PartnerListScreenWarning);
+        if (partner && partner.sale_warn && partner.sale_warn !== "no-message") {
+            this.popup.add(ErrorPopup, {
+                title: sprintf(_t("Warning for %s"), partner.name),
+                body: partner.sale_warn_msg,
+            });
+            if (partner.sale_warn === "block") {
+                return;
+            }
+        }
+        return super.clickPartner(partner);
+    },
+});
diff --git a/pos_partner_sale_warning/static/src/tests/tours/PosPartnerSaleWarning.esm.js b/pos_partner_sale_warning/static/src/tests/tours/PosPartnerSaleWarning.esm.js
@@ -0,0 +1,102 @@
+/** @odoo-module */
+import {registry} from "@web/core/registry";
+
+const startSteps = [
+    {
+        content: "Test pos_partner_sale_warning: Waiting for loading to finish",
+        trigger: "body:not(:has(.loader))",
+        // eslint-disable-next-line no-empty-function
+        run: () => {},
+    },
+    {
+        content: "Test pos_partner_sale_warning: Close Opening cashbox popup",
+        trigger: "div.opening-cash-control .button:contains('Open session')",
+    },
+    {
+        content: "Test pos_partner_sale_warning: Click on 'Customer' Button",
+        trigger: "button.set-partner",
+    },
+    {
+        content: "Test pos_partner_sale_warning: Search partner 'Test Partner #1'",
+        trigger: ".pos-search-bar input",
+        run: "text 'Test Partner'",
+    },
+];
+
+const endSteps = [
+    {
+        content: "Test pos_partner_sale_warning: Open menu Point of Sale",
+        trigger: "div.navbar-button.menu-button",
+        run: "click",
+    },
+    {
+        content:
+            "Test pos_partner_sale_warning: Open modal confirm closing Point of Sale",
+        trigger: "li.close-button",
+        run: "click",
+    },
+    {
+        content: "Test pos_partner_sale_warning: Confirm closing the frontend",
+        extra_trigger: "div.popup.close-pos-popup",
+        trigger: "button.button.highlight",
+        run: "click",
+    },
+];
+
+registry.category("web_tour.tours").add("PosPartnerSaleWarning", {
+    test: true,
+    url: "/pos/ui",
+    steps: () =>
+        [
+            ...startSteps,
+            {
+                content: "Test pos_partner_sale_warning: Click in partner",
+                trigger: "tr.partner-line:has(td b:contains('Test Partner #1'))",
+                run: "click",
+            },
+            {
+                content: "Test pos_partner_sale_warning: Check warning text",
+                extra_trigger: ".modal-dialog",
+                trigger: ".modal-dialog .title:contains('Warning for Test Partner #1')",
+            },
+            {
+                content: "Test pos_partner_sale_warning: Check warning text",
+                extra_trigger: ".modal-dialog",
+                trigger: "main.modal-body:contains('Error Message Test Message')",
+                // eslint-disable-next-line no-empty-function
+                run: () => {},
+            },
+            {
+                content:
+                    "Test pos_partner_sale_warning: Confirm popup click on 'Ok' Button",
+                trigger: ".modal-dialog .modal-footer .button:contains('Ok')",
+                run: "click",
+            },
+            {
+                content: "Test pos_partner_sale_warning: Click on 'Test Partner #2'",
+                trigger: "tr.partner-line:has(td b:contains('Test Partner #2'))",
+                run: "click",
+            },
+            {
+                content: "Test pos_partner_sale_warning: Check warning text",
+                extra_trigger: ".modal-dialog",
+                trigger: ".modal-dialog .title:contains('Warning for Test Partner #2')",
+                // eslint-disable-next-line no-empty-function
+                run: () => {},
+            },
+            {
+                content: "Test pos_partner_sale_warning: Check warning text",
+                extra_trigger: ".modal-dialog",
+                trigger: "main.modal-body:contains('Warning Message Test Message')",
+                // eslint-disable-next-line no-empty-function
+                run: () => {},
+            },
+            {
+                content: "Test pos_partner_sale_warning: Click on 'Customer' Button",
+                trigger: "button.set-partner:contains('Test Partner #2')",
+                // eslint-disable-next-line no-empty-function
+                run: () => {},
+            },
+            ...endSteps,
+        ].flat(),
+});
diff --git a/pos_partner_sale_warning/static/src/tests/tours/PosPartnerSaleWarning.esm.tour.js b/pos_partner_sale_warning/static/src/tests/tours/PosPartnerSaleWarning.esm.tour.js
