[MIG] pos_session_pay_invoice: Migration to 18.0

Author: Tisho99

pos_session_pay_invoice/__manifest__.py

@@ -3,7 +3,7 @@
 
 {
     "name": "POS Session Pay invoice",
-    "version": "16.0.1.0.3",
+    "version": "18.0.1.0.0",
     "category": "Point Of Sale",
     "author": "Creu Blanca, Odoo Community Association (OCA)",
     "website": "https://github.com/OCA/pos",

pos_session_pay_invoice/tests/test_pay_invoice.py

@@ -14,8 +14,8 @@
 @odoo.tests.tagged("post_install", "-at_install")
 class TestSessionPayInvoice(TestPointOfSaleCommon):
     @classmethod
-    def setUpClass(cls, chart_template_ref=None):
-        super().setUpClass(chart_template_ref=chart_template_ref)
+    def setUpClass(cls):
+        super().setUpClass()
         cls.env = cls.env(context=dict(cls.env.context, **DISABLED_MAIL_CONTEXT))
         cls.pos_config.cash_control = True
         cls.new_journal = cls.env["account.journal"].create(
@@ -68,14 +68,22 @@ def setUpClass(cls, chart_template_ref=None):
             }
         )
         cls.invoice_in.action_post()
+        cls.invoice_out2 = cls.invoice_out.copy()
+        cls.invoice_out2.action_post()
+        payment_register = Form(
+            cls.env["account.payment.register"].with_context(
+                active_model="account.move", active_ids=cls.invoice_out2.ids
+            )
+        )
+        cls.payment = payment_register.save()._create_payments()
         refund_wizard = (
             cls.env["account.move.reversal"]
             .with_context(
-                active_ids=cls.invoice_out.ids,
-                active_id=cls.invoice_out.id,
-                active_model=cls.invoice_out._name,
+                active_ids=cls.invoice_out2.ids,
+                active_id=cls.invoice_out2.id,
+                active_model=cls.invoice_out2._name,
             )
-            .create({"journal_id": cls.invoice_out.journal_id.id})
+            .create({"journal_id": cls.invoice_out2.journal_id.id})
             .reverse_moves()
         )
         cls.refund = cls.env[refund_wizard["res_model"]].browse(refund_wizard["res_id"])
@@ -87,7 +95,7 @@ def test_pos_in_invoice(self):
         session = self.pos_config.current_session_id
         self.assertTrue(session.cash_control)
         self.assertTrue(session.cash_journal_id)
-        session.set_cashbox_pos(0, notes="Initial cash")
+        session.set_opening_control(0, notes="Initial cash")
         wizard_context = session.button_show_wizard_pay_in_invoice()["context"]
         cash_in = self.env["cash.pay.invoice"].with_context(**wizard_context)
         with Form(cash_in, view=WIZARD_PAY_INVOICE_VIEW) as form:
@@ -113,7 +121,7 @@ def test_pos_out_invoice(self):
         self.assertEqual(self.invoice_out.amount_residual, 100.0)
         self.pos_config._action_to_open_ui()
         session = self.pos_config.current_session_id
-        session.set_cashbox_pos(0, notes="Initial cash")
+        session.set_opening_control(0, notes="Initial cash")
         wizard_context = session.button_show_wizard_pay_out_invoice()["context"]
         cash_out = self.env["cash.pay.invoice"].with_context(**wizard_context)
         with Form(cash_out, view=WIZARD_PAY_INVOICE_VIEW) as form:
@@ -136,7 +144,7 @@ def test_pos_invoice_refund(self):
         self.assertEqual(self.refund.amount_residual, 100.0)
         self.pos_config._action_to_open_ui()
         session = self.pos_config.current_session_id
-        session.set_cashbox_pos(0, notes="Initial cash")
+        session.set_opening_control(0, notes="Initial cash")
         wizard_context = session.button_show_wizard_pay_out_refund()["context"]
         cash_out = self.env["cash.pay.invoice"].with_context(**wizard_context)
         with Form(cash_out, view=WIZARD_PAY_INVOICE_VIEW) as form:

pos_session_pay_invoice/views/pos_session.xml

@@ -26,7 +26,7 @@
                     name="button_show_wizard_pay_out_refund"
                     type="object"
                     icon="fa-level-up"
-                    attrs="{'invisible':['|',('cash_control', '=', False), ('state', 'not in', ['opened', 'closing_control'])]}"
+                    invisible="not cash_control or state not in ['opened', 'closing_control']"
                 >
                     <div class="o_form_field o_stat_info">
                         <span class="o_stat_text">Pay</span>
@@ -38,7 +38,7 @@
                     name="button_show_wizard_pay_in_invoice"
                     type="object"
                     icon="fa-level-up"
-                    attrs="{'invisible':['|',('cash_control', '=', False), ('state', 'not in', ['opened', 'closing_control'])]}"
+                    invisible="not cash_control or state not in ['opened', 'closing_control']"
                 >
                     <div class="o_form_field o_stat_info">
                         <span class="o_stat_text">Pay Supplier</span>
@@ -50,7 +50,7 @@
                     name="button_show_wizard_pay_out_invoice"
                     type="object"
                     icon="fa-level-down"
-                    attrs="{'invisible':['|',('cash_control', '=', False), ('state', 'not in', ['opened', 'closing_control'])]}"
+                    invisible="not cash_control or state not in ['opened', 'closing_control']"
                 >
                     <div class="o_form_field o_stat_info">
                         <span class="o_stat_text">Get Payment</span>

pos_session_pay_invoice/wizard/cash_pay_invoice.py

@@ -89,13 +89,14 @@ def action_pay_invoice(self):
         pos_order.write({"name": pos_order._compute_order_name()})
         pos_order.add_payment(self._prepare_pos_payment_vals(pos_order))
         pos_order._apply_invoice_payments()
+        pos_order.write({"state": "invoiced"})
 
     def _prepare_pos_order_vals(self):
         return {
             "amount_total": self.amount,
             "partner_id": self.invoice_id.partner_id.id,
             "account_move": self.invoice_id.id,
-            "state": "invoiced",
+            "state": "draft",
             "to_invoice": False,
             "session_id": self.pos_session_id.id,
             "amount_tax": 0,