[ADD] product_barcode_sequence: generate product barcodes (fixup)

Author: dreispt

product_barcode_sequence/__manifest__.py

@@ -9,13 +9,10 @@
     "license": "AGPL-3",
     "category": "Product",
     "summary": "Automatically assign EAN barcodes to products by category",
-    "depends": ["product"],
+    "depends": ["product", "stock"],
     "data": [
         "views/product_category.xml",
         "data/ir_actions_server.xml",
     ],
     "installable": True,
-    "auto_install": False,
-    "application": False,
-    "demo": [],
 }

product_barcode_sequence/models/product_category.py

@@ -11,19 +11,23 @@ class ProductCategory(models.Model):
     barcode_prefix = fields.Char(
         help="Prefix used to generate EAN barcodes for products "
         "created with this category. Should be 1-12 digits.",
+        compute="_compute_barcode_fields",
+        inverse="_inverse_barcode_prefix",
         size=12,
+        store=True,
     )
     barcode_sequence_id = fields.Many2one(
         comodel_name="ir.sequence",
         help="Sequence used to generate unique barcode numbers for products "
         "in this category.",
+        compute="_compute_barcode_fields",
+        inverse="_inverse_barcode_sequence_prefix",
+        store=True,
         copy=False,
-        readonly=True,
     )
     auto_generate_barcode = fields.Boolean(
         help="Automatically generate EAN barcode when creating products "
         "in this category.",
-        default=False,
     )
 
     @api.constrains("barcode_prefix")
@@ -37,51 +41,45 @@ def _check_barcode_prefix(self):
             if len(category.barcode_prefix) == 0:
                 raise UserError(_("Barcode prefix cannot be empty"))
 
+    @api.depends("barcode_sequence_id.prefix")
+    def _compute_barcode_fields(self):
+        """Compute barcode_prefix from barcode_sequence_id and vice versa."""
+        for category in self:
+            category.barcode_prefix = category.barcode_sequence_id.prefix
+
+    @api.depends("barcode_prefix")
+    def _inverse_barcode_prefix(self):
+        """When barcode_prefix is set, find or create corresponding sequence."""
+        for category in self:
+            if category.barcode_prefix:
+                category.barcode_sequence_id = (
+                    category._create_or_update_barcode_sequence()
+                )
+
+    def _create_or_update_barcode_sequence(self):
+        if not self.prefix:
+            return False
+        existing_sequence = self.env["ir.sequence"].search(
+            [
+                ("prefix", "=", self.prefix),
+                ("code", "like", "product.barcode"),
+                ("company_id", "=", False),
+            ],
+            limit=1,
+        )
+        if existing_sequence:
+            return existing_sequence
+        else:
+            seq_vals = self._prepare_barcode_sequence(self.prefix)
+            return self.env["ir.sequence"].create(seq_vals)
+
     @api.model
     def _prepare_barcode_sequence(self, prefix):
-        """Prepare the vals for creating the barcode sequence
-        :param prefix: a string with the prefix of the barcode.
-        :return: a dict with the values.
-        """
         vals = {
             "name": "Barcode " + prefix,
             "code": "product.barcode - " + prefix,
             "padding": 12 - len(prefix),  # Total 13 digits for EAN-13
             "prefix": prefix,
             "company_id": False,
-            "implementation": "no_gap",
         }
         return vals
-
-    def _create_or_update_barcode_sequence(self, prefix):
-        """Create or update barcode sequence for given prefix"""
-        seq_vals = self._prepare_barcode_sequence(prefix)
-        if self.barcode_sequence_id:
-            self.sudo().barcode_sequence_id.write(
-                {
-                    "prefix": prefix,
-                    "padding": 12 - len(prefix),
-                }
-            )
-        else:
-            self.barcode_sequence_id = self.env["ir.sequence"].create(seq_vals)
-
-    def write(self, vals):
-        prefix = vals.get("barcode_prefix", False)
-        if prefix:
-            for rec in self:
-                rec._create_or_update_barcode_sequence(prefix)
-        return super().write(vals)
-
-    @api.model_create_multi
-    def create(self, vals_list):
-        vals_list_updated = []
-        for vals in vals_list:
-            prefix = vals.get("barcode_prefix", False)
-            if prefix:
-                seq_vals = self._prepare_barcode_sequence(prefix)
-                sequence = self.env["ir.sequence"].create(seq_vals)
-                vals_list_updated.append(dict(vals, barcode_sequence_id=sequence.id))
-            else:
-                vals_list_updated.append(vals)
-        return super().create(vals_list_updated)

product_barcode_sequence/tests/test_product_barcode_sequence.py

@@ -331,3 +331,56 @@ def test_workflow_10_force_barcode_regeneration(self):
         self.assertIn(
             product, generated_products, "Product should be in generated products"
         )
+
+    def test_workflow_11_bidirectional_sync_sequence_to_prefix(self):
+        """Workflow: Barcode prefix updates when sequence is set."""
+        # Step 1: Create category without prefix
+        category = self._create_category_with_barcode_config("Sync Test", "", False)
+
+        # Step 2: Create a sequence manually
+        sequence = self.env["ir.sequence"].create(
+            {
+                "name": "Test Sequence",
+                "code": "product.barcode - 333333",
+                "prefix": "333333",
+                "padding": 6,
+                "company_id": False,
+            }
+        )
+
+        # Step 3: Set the sequence on category
+        category.write({"barcode_sequence_id": sequence.id})
+
+        # Step 4: Verify prefix was updated from sequence
+        self.assertEqual(category.barcode_prefix, "333333")
+        self.assertEqual(category.barcode_sequence_id, sequence)
+
+    def test_workflow_12_sequence_reuse_across_categories(self):
+        """Workflow: Multiple categories reuse the same sequence when prefix matches."""
+        # Step 1: Create first category with prefix
+        category1 = self._create_category_with_barcode_config("Category 1", "444444")
+        sequence1_id = category1.barcode_sequence_id.id
+
+        # Step 2: Create second category with same prefix
+        category2 = self._create_category_with_barcode_config("Category 2", "444444")
+
+        # Step 3: Verify same sequence is reused
+        self.assertEqual(
+            category1.barcode_sequence_id.id,
+            category2.barcode_sequence_id.id,
+            "Same sequence should be reused for same prefix",
+        )
+        self.assertEqual(sequence1_id, category2.barcode_sequence_id.id)
+
+    def test_workflow_13_clear_barcode_configuration(self):
+        """Workflow: Clear barcode prefix and sequence."""
+        # Step 1: Create category with barcode configuration
+        category = self._create_category_with_barcode_config("Clear Test", "555555")
+        self.assertTrue(category.barcode_sequence_id, "Sequence should exist")
+
+        # Step 2: Clear the prefix
+        category.write({"barcode_prefix": ""})
+
+        # Step 3: Verify both fields are cleared
+        self.assertFalse(category.barcode_prefix, "Prefix should be cleared")
+        self.assertFalse(category.barcode_sequence_id, "Sequence should be cleared")

product_barcode_sequence/views/product_category.xml

@@ -4,22 +4,15 @@
     <record id="product_category_form_view" model="ir.ui.view">
         <field name="name">product.category.form - product_barcode_sequence</field>
         <field name="model">product.category</field>
-        <field name="inherit_id" ref="product.product_category_form_view" />
+        <field name="inherit_id" ref="stock.product_category_form_view_inherit" />
         <field name="arch" type="xml">
-            <field name="parent_id" position="after">
-                <group string="Barcode Configuration">
+
+            <group name="logistics" position="inside">
                     <field name="auto_generate_barcode" />
-                    <label for="barcode_prefix" />
-                    <div>
-                        <field
-                            name="barcode_prefix"
-                            style="padding-right: 1.0em"
-                            class="oe_inline"
-                        />
-                        <field name="barcode_sequence_id" groups="base.group_no_one" />
-                    </div>
-                </group>
-            </field>
+                    <field name="barcode_prefix" />
+                    <field name="barcode_sequence_id" groups="base.group_no_one" />
+            </group>
+
         </field>
     </record>
 </odoo>