[MIG] product_packaging_level_salable: Migration to 18.0

Author: trisdoan

product_packaging_level_salable/README.rst

@@ -73,11 +73,13 @@ Contributors
 ------------
 
 -  Duong (Tran Quoc) <duongtq@trobz.com>
+-  Tris Doan <tridm@trobz.com>
 
 Other credits
 -------------
 
-The development of this module has been financially supported by:
+The development and migration of this module has been financially
+supported by:
 
 -  Camptocamp
 

product_packaging_level_salable/__manifest__.py

@@ -3,7 +3,7 @@
 {
     "name": "Product Packaging level salable",
     "summary": "",
-    "version": "17.0.1.0.0",
+    "version": "18.0.1.0.0",
     "development_status": "Alpha",
     "category": "Product",
     "website": "https://github.com/OCA/product-attribute",

product_packaging_level_salable/models/sale_order_line.py

@@ -1,7 +1,7 @@
 # Copyright 2023 Camptocamp SA
 # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl)
 
-from odoo import _, api, models
+from odoo import api, models
 from odoo.exceptions import ValidationError
 
 
@@ -17,23 +17,21 @@ def _check_product_packaging_can_be_sold(self):
         for line in self:
             if line._can_be_sold_error_condition():
                 raise ValidationError(
-                    _(
+                    self.env._(
                         "Packaging %(packaging)s on product %(product)s must be"
-                        " set as 'Sales' in order to be used on a sale order."
+                        " set as 'Sales' in order to be used on a sale order.",
+                        packaging=line.product_packaging_id.name,
+                        product=line.product_id.name,
                     )
-                    % {
-                        "packaging": line.product_packaging_id.name,
-                        "product": line.product_id.name,
-                    }
                 )
 
     @api.onchange("product_packaging_id")
     def _onchange_product_packaging_id(self):
         if self._can_be_sold_error_condition():
             return {
                 "warning": {
-                    "title": _("Warning"),
-                    "message": _(
+                    "title": self.env._("Warning"),
+                    "message": self.env._(
                         "This product packaging must be set as 'Sales' in"
                         " order to be used on a sale order."
                     ),

product_packaging_level_salable/readme/CONTRIBUTORS.md

@@ -1 +1,2 @@
 - Duong (Tran Quoc) \<<duongtq@trobz.com>\>
+- Tris Doan \<<tridm@trobz.com>\>

product_packaging_level_salable/readme/CREDITS.md

@@ -1,4 +1,4 @@
-The development of this module has been financially supported by:
+The development and migration of this module has been financially supported by:
 
 - Camptocamp
 

product_packaging_level_salable/static/description/index.html

@@ -422,11 +422,13 @@ <h2><a class="toc-backref" href="#toc-entry-4">Authors</a></h2>
 <h2><a class="toc-backref" href="#toc-entry-5">Contributors</a></h2>
 <ul class="simple">
 <li>Duong (Tran Quoc) &lt;<a class="reference external" href="mailto:duongtq&#64;trobz.com">duongtq&#64;trobz.com</a>&gt;</li>
+<li>Tris Doan &lt;<a class="reference external" href="mailto:tridm&#64;trobz.com">tridm&#64;trobz.com</a>&gt;</li>
 </ul>
 </div>
 <div class="section" id="other-credits">
 <h2><a class="toc-backref" href="#toc-entry-6">Other credits</a></h2>
-<p>The development of this module has been financially supported by:</p>
+<p>The development and migration of this module has been financially
+supported by:</p>
 <ul class="simple">
 <li>Camptocamp</li>
 </ul>

product_packaging_level_salable/tests/common.py

@@ -1,20 +1,19 @@
 # Copyright 2023 Camptocamp SA
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl)
 
-from odoo.tests.common import Form, TransactionCase
+from odoo.tests import Form, tagged
+
+from odoo.addons.base.tests.common import BaseCommon
 
 TU_PRODUCT_QTY = 20
 PL_PRODUCT_QTY = TU_PRODUCT_QTY * 30
 
 
-class Common(TransactionCase):
-    at_install = False
-    post_install = True
-
+@tagged("post_install", "-at_install")
+class Common(BaseCommon):
     @classmethod
     def setUpClass(cls):
         super().setUpClass()
-        cls.env = cls.env(context=dict(cls.env.context, tracking_disable=True))
         cls.setUpClassPartner()
         cls.setUpClassProduct()
         cls.setUpClassPackagingLevel()

product_packaging_level_salable/tests/test_packaging_level_can_be_sold.py

@@ -16,7 +16,7 @@ def setUpClassSaleOrder(cls):
 
     def test_packaging_level_can_be_sold(self):
         self.order_line.write({"product_packaging_id": self.packaging_tu.id})
-        with self.assertRaises(ValidationError):
+        with self.assertRaisesRegex(ValidationError):
             self.order_line.write(
                 {"product_packaging_id": self.packaging_cannot_be_sold.id}
             )
@@ -29,7 +29,7 @@ def test_onchange_product_packaging_id(self):
     def test_product_packaging_can_be_sold(self):
         """Check that a product.packaging can be independently set as can be sold."""
         exception_msg = (
-            f"Packaging Test packaging cannot be sold on product {self.product.name} must be set "
+            f"Test packaging cannot be sold on product {self.product.name} must be set "
             "as 'Sales' in order to be used on a sale order."
         )
         with self.assertRaisesRegex(ValidationError, exception_msg):

product_packaging_level_salable/views/product_packaging_level.xml

@@ -13,11 +13,11 @@
         </field>
     </record>
 
-    <record id="view_product_packaging_level_tree" model="ir.ui.view">
+    <record id="view_product_packaging_level_list" model="ir.ui.view">
         <field name="model">product.packaging.level</field>
         <field
             name="inherit_id"
-            ref="product_packaging_level.view_product_packaging_level_tree"
+            ref="product_packaging_level.view_product_packaging_level_list"
         />
         <field name="arch" type="xml">
             <field name="code" position="after">