[MIG] product_assortment: Migration to 17.0

Author: dalonsod

product_assortment/README.rst

@@ -17,13 +17,13 @@ Product Assortment
     :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html
     :alt: License: AGPL-3
 .. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fproduct--attribute-lightgray.png?logo=github
-    :target: https://github.com/OCA/product-attribute/tree/18.0/product_assortment
+    :target: https://github.com/OCA/product-attribute/tree/17.0/product_assortment
     :alt: OCA/product-attribute
 .. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png
-    :target: https://translation.odoo-community.org/projects/product-attribute-18-0/product-attribute-18-0-product_assortment
+    :target: https://translation.odoo-community.org/projects/product-attribute-17-0/product-attribute-17-0-product_assortment
     :alt: Translate me on Weblate
 .. |badge5| image:: https://img.shields.io/badge/runboat-Try%20me-875A7B.png
-    :target: https://runboat.odoo-community.org/builds?repo=OCA/product-attribute&target_branch=18.0
+    :target: https://runboat.odoo-community.org/builds?repo=OCA/product-attribute&target_branch=17.0
     :alt: Try me on Runboat
 
 |badge1| |badge2| |badge3| |badge4| |badge5|
@@ -78,7 +78,7 @@ Bug Tracker
 Bugs are tracked on `GitHub Issues <https://github.com/OCA/product-attribute/issues>`_.
 In case of trouble, please check there if your issue has already been reported.
 If you spotted it first, help us to smash it by providing a detailed and welcomed
-`feedback <https://github.com/OCA/product-attribute/issues/new?body=module:%20product_assortment%0Aversion:%2018.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
+`feedback <https://github.com/OCA/product-attribute/issues/new?body=module:%20product_assortment%0Aversion:%2017.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
 
 Do not contact contributors directly about support or help with technical issues.
 
@@ -114,6 +114,6 @@ OCA, or the Odoo Community Association, is a nonprofit organization whose
 mission is to support the collaborative development of Odoo features and
 promote its widespread use.
 
-This module is part of the `OCA/product-attribute <https://github.com/OCA/product-attribute/tree/18.0/product_assortment>`_ project on GitHub.
+This module is part of the `OCA/product-attribute <https://github.com/OCA/product-attribute/tree/17.0/product_assortment>`_ project on GitHub.
 
 You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute.

product_assortment/__manifest__.py

@@ -6,7 +6,7 @@
     "name": "Product Assortment",
     "summary": """
         Adds the ability to manage products assortment""",
-    "version": "18.0.1.0.0",
+    "version": "17.0.1.0.0",
     "license": "AGPL-3",
     "development_status": "Production/Stable",
     "author": "ACSONE SA/NV,Odoo Community Association (OCA)",

product_assortment/models/ir_filters.py

@@ -142,15 +142,11 @@ def _compute_record_count(self):
             record.record_count = self.env[record.model_id].search_count(domain)
 
     @api.model
-    def _get_action_domain(
-        self, action_id=None, embedded_action_id=None, embedded_parent_res_id=None
-    ):
+    def _get_action_domain(self, action_id=None):
         # tricky way to act on get_filter method to prevent returning
         # assortment in search view filters
         domain = super()._get_action_domain(
             action_id=action_id,
-            embedded_action_id=embedded_action_id,
-            embedded_parent_res_id=embedded_parent_res_id,
         )
         domain = expression.AND([[("is_assortment", "=", False)], domain])
 

product_assortment/static/description/index.html

@@ -369,7 +369,7 @@ <h1 class="title">Product Assortment</h1>
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
 !! source digest: sha256:af159859935f84f06b57cebf020961a03ba724fd1033627f9796e1843fca60f9
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! -->
-<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Production/Stable" src="https://img.shields.io/badge/maturity-Production%2FStable-green.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/licence-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/product-attribute/tree/18.0/product_assortment"><img alt="OCA/product-attribute" src="https://img.shields.io/badge/github-OCA%2Fproduct--attribute-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/product-attribute-18-0/product-attribute-18-0-product_assortment"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/product-attribute&amp;target_branch=18.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
+<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Production/Stable" src="https://img.shields.io/badge/maturity-Production%2FStable-green.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/licence-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/product-attribute/tree/17.0/product_assortment"><img alt="OCA/product-attribute" src="https://img.shields.io/badge/github-OCA%2Fproduct--attribute-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/product-attribute-17-0/product-attribute-17-0-product_assortment"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/product-attribute&amp;target_branch=17.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
 <p>This addon intends to manage product assortment. In Odoo you can only
 define some filters defined by a domain but it can be sometimes really
 complicated. With this addon you will be able to define a domain but
@@ -437,7 +437,7 @@ <h1><a class="toc-backref" href="#toc-entry-7">Bug Tracker</a></h1>
 <p>Bugs are tracked on <a class="reference external" href="https://github.com/OCA/product-attribute/issues">GitHub Issues</a>.
 In case of trouble, please check there if your issue has already been reported.
 If you spotted it first, help us to smash it by providing a detailed and welcomed
-<a class="reference external" href="https://github.com/OCA/product-attribute/issues/new?body=module:%20product_assortment%0Aversion:%2018.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
+<a class="reference external" href="https://github.com/OCA/product-attribute/issues/new?body=module:%20product_assortment%0Aversion:%2017.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
 <p>Do not contact contributors directly about support or help with technical issues.</p>
 </div>
 <div class="section" id="credits">
@@ -470,7 +470,7 @@ <h2><a class="toc-backref" href="#toc-entry-11">Maintainers</a></h2>
 <p>OCA, or the Odoo Community Association, is a nonprofit organization whose
 mission is to support the collaborative development of Odoo features and
 promote its widespread use.</p>
-<p>This module is part of the <a class="reference external" href="https://github.com/OCA/product-attribute/tree/18.0/product_assortment">OCA/product-attribute</a> project on GitHub.</p>
+<p>This module is part of the <a class="reference external" href="https://github.com/OCA/product-attribute/tree/17.0/product_assortment">OCA/product-attribute</a> project on GitHub.</p>
 <p>You are welcome to contribute. To learn how please visit <a class="reference external" href="https://odoo-community.org/page/Contribute">https://odoo-community.org/page/Contribute</a>.</p>
 </div>
 </div>

product_assortment/tests/test_product_assortment.py

@@ -91,7 +91,7 @@ def test_product_assortment_view(self):
         included_product = self.env.ref("product.product_product_7")
         self.assortment.write({"whitelist_product_ids": [(4, included_product.id)]})
         res = self.assortment.show_products()
-        self.assertEqual(res["domain"], [(1, "=", 1)])
+        self.assertEqual(res["domain"], [("id", "in", [included_product.id])])
 
     def test_product_assortment_view_with_black_list(self):
         excluded_product = self.env.ref("product.product_product_7")
@@ -113,7 +113,8 @@ def test_product_assortment_mixed_view(self):
             }
         )
         res = self.assortment.show_products()
-        self.assertEqual(res["domain"], [("id", "not in", excluded_product.ids)])
+        self.assertEqual(res["domain"][1], ("id", "not in", excluded_product.ids))
+        self.assertEqual(res["domain"][2], ("id", "in", included_product.ids))
 
     def test_record_count(self):
         products = self.product_obj.search([])

product_assortment/views/product_assortment.xml

@@ -12,12 +12,12 @@
             </search>
         </field>
     </record>
-    <record id="product_assortment_view_list" model="ir.ui.view">
+    <record id="product_assortment_view_tree" model="ir.ui.view">
         <field name="model">ir.filters</field>
         <field name="arch" type="xml">
-            <list>
+            <tree>
                 <field name="name" />
-            </list>
+            </tree>
         </field>
     </record>
 
@@ -106,15 +106,15 @@
                                 name="whitelist_product_ids"
                                 nolabel="1"
                                 colspan="2"
-                                context="{'list_view_ref': 'product_assortment.product_product_view_list'}"
+                                context="{'tree_view_ref': 'product_assortment.product_product_view_tree'}"
                             />
                         </group>
                         <group name="to_exclude" string="Products to exclude">
                             <field
                                 name="blacklist_product_ids"
                                 nolabel="1"
                                 colspan="2"
-                                context="{'list_view_ref': 'product_assortment.product_product_view_list'}"
+                                context="{'tree_view_ref': 'product_assortment.product_product_view_tree'}"
                             />
                         </group>
                     </group>
@@ -125,12 +125,12 @@
             </form>
         </field>
     </record>
-    <record id="product_product_view_list" model="ir.ui.view">
+    <record id="product_product_view_tree" model="ir.ui.view">
         <field name="model">product.product</field>
         <field name="arch" type="xml">
-            <list>
+            <tree>
                 <field name="display_name" string="Product" />
-            </list>
+            </tree>
         </field>
     </record>
     <record id="actions_product_assortment_view" model="ir.actions.act_window">
@@ -143,7 +143,7 @@
         <field
             name="view_ids"
             eval="[(5, 0, 0),
-                          (0, 0, {'view_mode': 'list', 'view_id': ref('product_assortment_view_list')}),
+                          (0, 0, {'view_mode': 'tree', 'view_id': ref('product_assortment_view_tree')}),
                           (0, 0, {'view_mode': 'form', 'view_id': ref('product_assortment_view_form')})]"
         />
     </record>