[MIG] product_lot_sequence: Migration to 17.0

Author: fredericgrall

product_lot_sequence/README.rst

@@ -127,6 +127,10 @@ Contributors
 
    -  Yoshi Tashiro
 
+-  `Apik <https://www.apik.cloud>`__:
+
+   -  Frederic Grall
+
 Maintainers
 -----------
 

product_lot_sequence/__manifest__.py

@@ -5,7 +5,7 @@
     "name": "Product Lot Sequence",
     "summary": """
         Adds ability to define a lot sequence from the product""",
-    "version": "16.0.1.0.2",
+    "version": "17.0.1.0.0",
     "license": "AGPL-3",
     "author": "ForgeFlow S.L., Odoo Community Association (OCA)",
     "website": "https://github.com/OCA/product-attribute",

product_lot_sequence/models/stock_lot.py

@@ -52,7 +52,7 @@ def create(self, vals_list):
                         lot_vals["name"] = self.env["ir.sequence"].next_by_code(
                             "stock.lot.serial"
                         )
-        return super(StockLot, self).create(vals_list)
+        return super().create(vals_list)
 
     @api.model
     def _get_next_serial(self, company, product):

product_lot_sequence/models/stock_move.py

@@ -9,11 +9,16 @@ class StockMove(models.Model):
     def action_show_details(self):
         """Avoid calling and incrementing the sequence if not needed or already done"""
         seq_policy = self.env["stock.lot"]._get_sequence_policy()
+
         if seq_policy in ("product", "global"):
             # If move is not supposed to assign serial pass empty string for next serial
             if not self.display_assign_serial:
                 self = self.with_context(force_next_serial="")
             # If the sequence was already called once, avoid calling it another time
             elif self.next_serial:
                 self = self.with_context(force_next_serial=self.next_serial)
-        return super(StockMove, self).action_show_details()
+            elif self.product_id.tracking == "serial" and self.state == "assigned":
+                self.next_serial = self.env["stock.lot"]._get_next_serial(
+                    self.company_id, self.product_id
+                )
+        return super().action_show_details()

product_lot_sequence/readme/CONTRIBUTORS.md

@@ -5,3 +5,5 @@
   - Vincent Van Rossem \<<vincent.vanrossem@camptocamp.com>\>
 - [Quartile](https://www.quartile.co):
   - Yoshi Tashiro
+- [Apik](https://www.apik.cloud):
+  - Frederic Grall

product_lot_sequence/static/description/index.html

@@ -477,6 +477,10 @@ <h2><a class="toc-backref" href="#toc-entry-9">Contributors</a></h2>
 <li>Yoshi Tashiro</li>
 </ul>
 </li>
+<li><a class="reference external" href="https://www.apik.cloud">Apik</a>:<ul>
+<li>Frederic Grall</li>
+</ul>
+</li>
 </ul>
 </div>
 <div class="section" id="maintainers">

product_lot_sequence/tests/test_product_lot_sequence.py

@@ -1,12 +1,16 @@
+import logging
+
 from odoo.tests import Form
 from odoo.tests.common import TransactionCase
 
+_logger = logging.getLogger(__name__)
+
 
 class TestProductLotSequence(TransactionCase):
     """Test product lot sequence."""
 
     def setUp(self):
-        super(TestProductLotSequence, self).setUp()
+        super().setUp()
         self.product_product = self.env["product.product"]
         self.stock_production_lot = self.env["stock.lot"]
         self.receipt_type = self.env.ref("stock.picking_type_in")

product_lot_sequence/views/product_views.xml

@@ -10,19 +10,20 @@
                 <field name="display_lot_sequence_fields" invisible="1" />
                 <field
                     name="lot_sequence_prefix"
-                    attrs="{'invisible': ['|', '|', ('tracking', 'not in', ['lot', 'serial']), ('display_lot_sequence_fields', '=', False), ('lot_sequence_id', '!=', False)]}"
+                    invisible="tracking not in ['lot', 'serial'] or not display_lot_sequence_fields or lot_sequence_id"
                 />
                 <field
                     name="lot_sequence_padding"
-                    attrs="{'invisible': ['|', '|', ('tracking', 'not in', ['lot', 'serial']), ('display_lot_sequence_fields', '=', False), ('lot_sequence_id', '!=', False)]}"
+                    invisible="tracking not in ['lot', 'serial'] or not display_lot_sequence_fields or lot_sequence_id"
                 />
                 <field
                     name="lot_sequence_number_next"
-                    attrs="{'readonly': [('lot_sequence_id', '!=', False)], 'invisible': ['|', ('tracking', 'not in', ['lot', 'serial']), ('display_lot_sequence_fields', '=', False)]}"
+                    readonly="lot_sequence_id"
+                    invisible="tracking not in ['lot', 'serial'] or not display_lot_sequence_fields"
                 />
                 <field
                     name="lot_sequence_id"
-                    attrs="{'invisible': ['|', ('tracking', 'not in', ['lot', 'serial']), ('display_lot_sequence_fields', '=', False)]}"
+                    invisible="tracking not in ['lot', 'serial'] or not display_lot_sequence_fields"
                 />
             </field>
         </field>

product_lot_sequence/views/res_config_settings_views.xml

@@ -5,7 +5,7 @@
         <field name="model">res.config.settings</field>
         <field name="inherit_id" ref="stock.res_config_settings_view_form" />
         <field name="arch" type="xml">
-            <xpath expr="//div[@id='production_lot_info']" position="inside">
+            <xpath expr="//block[@id='production_lot_info']" position="inside">
                 <div class="col-12 col-lg-6 o_setting_box">
                     <div class="o_setting_right_pane">
                         <label for="lot_sequence_padding" />