[MIG] product_packaging_level: Migration to 17.0

Author: bizzappdev

product_packaging_level/__manifest__.py

@@ -3,7 +3,7 @@
 
 {
     "name": "Product Packaging Level",
-    "version": "16.0.1.2.0",
+    "version": "17.0.1.0.0",
     "development_status": "Beta",
     "category": "Product",
     "summary": "This module binds a product packaging to a packaging level",

product_packaging_level/hooks.py

@@ -5,9 +5,9 @@
 from odoo import SUPERUSER_ID, api
 
 
-def pre_init_hook(cr):
-    if openupgrade.table_exists(cr, "product_packaging_type"):
-        env = api.Environment(cr, SUPERUSER_ID, {})
+def pre_init_hook(env):
+    if openupgrade.table_exists(env.cr, "product_packaging_type"):
+        env = api.Environment(env.cr, SUPERUSER_ID, {})
         # Former version of the module is present
         models = [("product.packaging.type", "product.packaging.level")]
         openupgrade.rename_models(env.cr, models)

product_packaging_level/models/product_packaging_level.py

@@ -10,7 +10,7 @@ class ProductPackagingLevel(models.Model):
     _order = "sequence, code"
 
     def _default_language(self):
-        lang_code = self.env["ir.default"].get("res.partner", "lang")
+        lang_code = self.env["ir.default"]._get("res.partner", "lang")
         def_lang_id = self.env["res.lang"]._lang_get_id(lang_code)
         return def_lang_id or self._active_languages()[0]
 
@@ -66,8 +66,8 @@ def _check_is_default(self):
         if msg:
             raise ValidationError(msg)
 
-    def name_get(self):
-        result = []
-        for record in self:
-            result.append((record.id, f"{record.name} ({record.code})"))
-        return result
+    @api.depends("name", "code")
+    def _compute_display_name(self):
+        for product_packaging_level in self:
+            name = f"{product_packaging_level.name} ({product_packaging_level.code})"
+            product_packaging_level.display_name = name

product_packaging_level/tests/test_product_packaging_level.py

@@ -31,16 +31,26 @@ def setUpClass(cls):
         )
         cls.level_fr.with_context(lang="fr_FR").name = "Packaging Level Test France"
         cls.packaging_default = cls.env["product.packaging"].create(
-            {"name": "Packaging Default", "qty": 1.0}
+            {
+                "name": "Packaging Default",
+                "qty": 1.0,
+                "product_id": cls.env.ref("product.product_product_5").id,
+            }
         )
         cls.packaging = cls.env["product.packaging"].create(
-            {"name": "Packaging Test", "packaging_level_id": cls.level.id, "qty": 1.0}
+            {
+                "name": "Packaging Test",
+                "packaging_level_id": cls.level.id,
+                "qty": 1.0,
+                "product_id": cls.env.ref("product.product_product_5").id,
+            }
         )
         cls.packaging_fr = cls.env["product.packaging"].create(
             {
                 "name": "Packaging Test",
                 "packaging_level_id": cls.level_fr.id,
                 "qty": 1.0,
+                "product_id": cls.env.ref("product.product_product_5").id,
             }
         )
         cls.product = cls.env["product.template"].create(

product_packaging_level/views/product_packaging_view.xml

@@ -15,12 +15,10 @@
                 <field name="barcode_required_for_gtin" invisible="1" />
             </field>
             <xpath expr="//field[@name='barcode']" position="attributes">
-                <attribute
-                    name="attrs"
-                >{'required': [('barcode_required_for_gtin', '=', True)]}</attribute>
+                <attribute name="required">barcode_required_for_gtin</attribute>
             </xpath>
             <field name="name" position="attributes">
-                <attribute name="invisible">1</attribute>
+                <attribute name="column_invisible">1</attribute>
             </field>
 
         </field>
@@ -46,15 +44,11 @@
                 <field name="barcode_required_for_gtin" invisible="1" />
             </xpath>
             <xpath expr="//field[@name='barcode']" position="attributes">
-                <attribute
-                    name="attrs"
-                >{'required': [('barcode_required_for_gtin', '=', True)]}</attribute>
+                <attribute name="required">barcode_required_for_gtin</attribute>
             </xpath>
             <field name="name" position="attributes">
                 <attribute name="force_save">1</attribute>
-                <attribute
-                    name="attrs"
-                >{'readonly': [('name_policy', '!=', 'user_defined')]}</attribute>
+                <attribute name="readonly">name_policy != 'user_defined'</attribute>
             </field>
 
         </field>