[MIG] sale_variant_configurator: Migration to version 19.0

TT61966

Author: Andrii9090-tecnativa

sale_variant_configurator/README.rst

@@ -1,3 +1,7 @@
+.. image:: https://odoo-community.org/readme-banner-image
+   :target: https://odoo-community.org/get-involved?utm_source=readme
+   :alt: Odoo Community Association
+
 =======================
 Sale - Product variants
 =======================
@@ -13,22 +17,25 @@ Sale - Product variants
 .. |badge1| image:: https://img.shields.io/badge/maturity-Production%2FStable-green.png
     :target: https://odoo-community.org/page/development-status
     :alt: Production/Stable
-.. |badge2| image:: https://img.shields.io/badge/licence-AGPL--3-blue.png
+.. |badge2| image:: https://img.shields.io/badge/license-AGPL--3-blue.png
     :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html
     :alt: License: AGPL-3
 .. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fproduct--variant-lightgray.png?logo=github
-    :target: https://github.com/OCA/product-variant/tree/18.0/sale_variant_configurator
+    :target: https://github.com/OCA/product-variant/tree/19.0/sale_variant_configurator
     :alt: OCA/product-variant
 .. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png
-    :target: https://translation.odoo-community.org/projects/product-variant-18-0/product-variant-18-0-sale_variant_configurator
+    :target: https://translation.odoo-community.org/projects/product-variant-19-0/product-variant-19-0-sale_variant_configurator
     :alt: Translate me on Weblate
 .. |badge5| image:: https://img.shields.io/badge/runboat-Try%20me-875A7B.png
-    :target: https://runboat.odoo-community.org/builds?repo=OCA/product-variant&target_branch=18.0
+    :target: https://runboat.odoo-community.org/builds?repo=OCA/product-variant&target_branch=19.0
     :alt: Try me on Runboat
 
 |badge1| |badge2| |badge3| |badge4| |badge5|
 
-
+This module allows you to create the product variant when a sale order
+is confirmed. It adds to the sale line a product configurator, so that
+selecting a product and its attributes can serve for creating/selecting
+the product variant.
 
 **Table of contents**
 
@@ -41,7 +48,7 @@ Bug Tracker
 Bugs are tracked on `GitHub Issues <https://github.com/OCA/product-variant/issues>`_.
 In case of trouble, please check there if your issue has already been reported.
 If you spotted it first, help us to smash it by providing a detailed and welcomed
-`feedback <https://github.com/OCA/product-variant/issues/new?body=module:%20sale_variant_configurator%0Aversion:%2018.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
+`feedback <https://github.com/OCA/product-variant/issues/new?body=module:%20sale_variant_configurator%0Aversion:%2019.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
 
 Do not contact contributors directly about support or help with technical issues.
 
@@ -58,6 +65,14 @@ Authors
 Contributors
 ------------
 
+- Oihane Crucelaegui oihanecrucelaegi@avanzosc.es
+- `Tecnativa <https://www.tecnativa.com>`__:
+
+  - Pedro M. Baeza
+  - David Vidal
+  - Andrii Kompaniiets
+
+- Ana Juaristi ajuaristio@gmail.com
 - [Heliconia Solutions Pvt. Ltd.](https://www.heliconia.io)
 
   - Bhavesh Heliconia
@@ -75,6 +90,6 @@ OCA, or the Odoo Community Association, is a nonprofit organization whose
 mission is to support the collaborative development of Odoo features and
 promote its widespread use.
 
-This module is part of the `OCA/product-variant <https://github.com/OCA/product-variant/tree/18.0/sale_variant_configurator>`_ project on GitHub.
+This module is part of the `OCA/product-variant <https://github.com/OCA/product-variant/tree/19.0/sale_variant_configurator>`_ project on GitHub.
 
 You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute.

sale_variant_configurator/__manifest__.py

@@ -7,7 +7,7 @@
 {
     "name": "Sale - Product variants",
     "summary": "Product variants in sale management",
-    "version": "18.0.1.0.0",
+    "version": "19.0.1.0.0",
     "development_status": "Production/Stable",
     "license": "AGPL-3",
     "depends": ["sale", "product_variant_configurator"],

sale_variant_configurator/models/sale_order.py

@@ -9,14 +9,17 @@
 class SaleOrder(models.Model):
     _inherit = "sale.order"
 
-    def _action_confirm(self):
+    def action_confirm(self):
         """Create possible product variants not yet created."""
         lines_without_product = self.mapped("order_line").filtered(
             lambda x: not x.product_id and x.product_tmpl_id
         )
         for line in lines_without_product:
-            line.create_variant_if_needed()
-        return super()._action_confirm()
+            if bool(line.product_attribute_ids.mapped("value_id")):
+                line.create_variant_if_needed()
+            else:
+                line.product_template_id = line.product_tmpl_id
+        return super().action_confirm()
 
 
 class SaleOrderLine(models.Model):
@@ -30,25 +33,19 @@ class SaleOrderLine(models.Model):
         related=False,
         string="Product Template (no related)",
     )
-    product_id = fields.Many2one(required=False)
 
-    _sql_constraints = [
-        (
-            "accountable_required_fields",
-            "CHECK(display_type IS NOT NULL OR "
-            "((product_id IS NOT NULL OR product_tmpl_id IS NOT NULL) AND "
-            "product_uom IS NOT NULL))",
-            "Missing required fields on accountable sale order line.",
-        ),
-        (
-            "non_accountable_null_fields",
-            "CHECK(display_type IS NULL OR "
-            "(product_id IS NULL AND product_tmpl_id IS NULL AND "
-            "price_unit = 0 AND product_uom_qty = 0 AND "
-            "product_uom IS NULL AND customer_lead = 0))",
-            "Forbidden values on non-accountable sale order line",
-        ),
-    ]
+    _accountable_required_fields = models.Constraint(
+        "CHECK(display_type IS NOT NULL OR is_downpayment OR "
+        "(product_tmpl_id IS NOT NULL OR product_id IS NOT NULL AND "
+        "product_uom_id IS NOT NULL))",
+        "Missing required fields on accountable sale order line.",
+    )
+    _non_accountable_null_fields = models.Constraint(
+        "CHECK(display_type IS NULL OR (product_tmpl_id IS NULL AND "
+        "product_id IS NULL AND price_unit = 0 AND product_uom_qty = 0 "
+        "AND product_uom_id IS NULL AND customer_lead = 0))",
+        "Forbidden values on non-accountable sale order line",
+    )
 
     @api.model_create_multi
     def create(self, vals_list):
@@ -78,3 +75,13 @@ def _get_product_description(self, template, product, product_attributes):
     def _compute_price_unit(self):
         """Add the proper dependency to compute the price correctly."""
         return super()._compute_price_unit()
+
+    def _get_sale_order_line_multiline_description_variants(self):
+        # It needs to correctly show the name of the sale.order.line with attributes
+        name = super()._get_sale_order_line_multiline_description_variants()
+        if not self.product_attribute_ids:
+            return name
+        for attribute in self.product_attribute_ids:
+            if attribute.value_id.display_name:
+                name += "\n" + attribute.value_id.display_name
+        return name

sale_variant_configurator/readme/CONTRIBUTORS.md

@@ -1,2 +1,8 @@
+- Oihane Crucelaegui <oihanecrucelaegi@avanzosc.es>
+- [Tecnativa](https://www.tecnativa.com):
+  - Pedro M. Baeza 
+  - David Vidal
+  - Andrii Kompaniiets
+- Ana Juaristi <ajuaristio@gmail.com>
 - \[Heliconia Solutions Pvt. Ltd.\](<https://www.heliconia.io>)
   - Bhavesh Heliconia

sale_variant_configurator/readme/DESCRIPTION.md

@@ -1 +1,3 @@
-
+This module allows you to create the product variant when a sale order 
+is confirmed. It adds to the sale line a product configurator, 
+so that selecting a product and its attributes can serve for creating/selecting the product variant.

sale_variant_configurator/static/description/index.html

@@ -3,7 +3,7 @@
 <head>
 <meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
 <meta name="generator" content="Docutils: https://docutils.sourceforge.io/" />
-<title>Sale - Product variants</title>
+<title>README.rst</title>
 <style type="text/css">
 
 /*
@@ -360,16 +360,25 @@
 </style>
 </head>
 <body>
-<div class="document" id="sale-product-variants">
-<h1 class="title">Sale - Product variants</h1>
+<div class="document">
 
+
+<a class="reference external image-reference" href="https://odoo-community.org/get-involved?utm_source=readme">
+<img alt="Odoo Community Association" src="https://odoo-community.org/readme-banner-image" />
+</a>
+<div class="section" id="sale-product-variants">
+<h1>Sale - Product variants</h1>
 <!-- !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
 !! This file is generated by oca-gen-addon-readme !!
 !! changes will be overwritten.                   !!
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
 !! source digest: sha256:967bca3a7e441cfaf105a13a9d73ed4e07faf7af4692d93d0de454830ae76e69
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! -->
-<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Production/Stable" src="https://img.shields.io/badge/maturity-Production%2FStable-green.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/licence-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/product-variant/tree/18.0/sale_variant_configurator"><img alt="OCA/product-variant" src="https://img.shields.io/badge/github-OCA%2Fproduct--variant-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/product-variant-18-0/product-variant-18-0-sale_variant_configurator"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/product-variant&amp;target_branch=18.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
+<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Production/Stable" src="https://img.shields.io/badge/maturity-Production%2FStable-green.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/license-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/product-variant/tree/19.0/sale_variant_configurator"><img alt="OCA/product-variant" src="https://img.shields.io/badge/github-OCA%2Fproduct--variant-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/product-variant-19-0/product-variant-19-0-sale_variant_configurator"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/product-variant&amp;target_branch=19.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
+<p>This module allows you to create the product variant when a sale order
+is confirmed. It adds to the sale line a product configurator, so that
+selecting a product and its attributes can serve for creating/selecting
+the product variant.</p>
 <p><strong>Table of contents</strong></p>
 <div class="contents local topic" id="contents">
 <ul class="simple">
@@ -383,45 +392,54 @@ <h1 class="title">Sale - Product variants</h1>
 </ul>
 </div>
 <div class="section" id="bug-tracker">
-<h1><a class="toc-backref" href="#toc-entry-1">Bug Tracker</a></h1>
+<h2><a class="toc-backref" href="#toc-entry-1">Bug Tracker</a></h2>
 <p>Bugs are tracked on <a class="reference external" href="https://github.com/OCA/product-variant/issues">GitHub Issues</a>.
 In case of trouble, please check there if your issue has already been reported.
 If you spotted it first, help us to smash it by providing a detailed and welcomed
-<a class="reference external" href="https://github.com/OCA/product-variant/issues/new?body=module:%20sale_variant_configurator%0Aversion:%2018.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
+<a class="reference external" href="https://github.com/OCA/product-variant/issues/new?body=module:%20sale_variant_configurator%0Aversion:%2019.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
 <p>Do not contact contributors directly about support or help with technical issues.</p>
 </div>
 <div class="section" id="credits">
-<h1><a class="toc-backref" href="#toc-entry-2">Credits</a></h1>
+<h2><a class="toc-backref" href="#toc-entry-2">Credits</a></h2>
 <div class="section" id="authors">
-<h2><a class="toc-backref" href="#toc-entry-3">Authors</a></h2>
+<h3><a class="toc-backref" href="#toc-entry-3">Authors</a></h3>
 <ul class="simple">
 <li>OdooMRP team</li>
 <li>AvanzOSC</li>
 <li>Tecnativa</li>
 </ul>
 </div>
 <div class="section" id="contributors">
-<h2><a class="toc-backref" href="#toc-entry-4">Contributors</a></h2>
+<h3><a class="toc-backref" href="#toc-entry-4">Contributors</a></h3>
 <ul class="simple">
+<li>Oihane Crucelaegui <a class="reference external" href="mailto:oihanecrucelaegi&#64;avanzosc.es">oihanecrucelaegi&#64;avanzosc.es</a></li>
+<li><a class="reference external" href="https://www.tecnativa.com">Tecnativa</a>:<ul>
+<li>Pedro M. Baeza</li>
+<li>David Vidal</li>
+<li>Andrii Kompaniiets</li>
+</ul>
+</li>
+<li>Ana Juaristi <a class="reference external" href="mailto:ajuaristio&#64;gmail.com">ajuaristio&#64;gmail.com</a></li>
 <li>[Heliconia Solutions Pvt. Ltd.](<a class="reference external" href="https://www.heliconia.io">https://www.heliconia.io</a>)<ul>
 <li>Bhavesh Heliconia</li>
 </ul>
 </li>
 </ul>
 </div>
 <div class="section" id="maintainers">
-<h2><a class="toc-backref" href="#toc-entry-5">Maintainers</a></h2>
+<h3><a class="toc-backref" href="#toc-entry-5">Maintainers</a></h3>
 <p>This module is maintained by the OCA.</p>
 <a class="reference external image-reference" href="https://odoo-community.org">
 <img alt="Odoo Community Association" src="https://odoo-community.org/logo.png" />
 </a>
 <p>OCA, or the Odoo Community Association, is a nonprofit organization whose
 mission is to support the collaborative development of Odoo features and
 promote its widespread use.</p>
-<p>This module is part of the <a class="reference external" href="https://github.com/OCA/product-variant/tree/18.0/sale_variant_configurator">OCA/product-variant</a> project on GitHub.</p>
+<p>This module is part of the <a class="reference external" href="https://github.com/OCA/product-variant/tree/19.0/sale_variant_configurator">OCA/product-variant</a> project on GitHub.</p>
 <p>You are welcome to contribute. To learn how please visit <a class="reference external" href="https://odoo-community.org/page/Contribute">https://odoo-community.org/page/Contribute</a>.</p>
 </div>
 </div>
 </div>
+</div>
 </body>
 </html>

sale_variant_configurator/tests/test_sale_order.py

@@ -77,7 +77,7 @@ def test_onchange_product_tmpl_id(self):
                 "name": "Line 1",
                 "product_tmpl_id": self.product_template_yes.id,
                 "price_unit": 100,
-                "product_uom": self.product_template_yes.uom_id.id,
+                "product_uom_id": self.product_template_yes.uom_id.id,
                 "product_uom_qty": 1,
             }
         )
@@ -135,7 +135,7 @@ def _test_can_create_product_variant(self):
                 "product_tmpl_id": self.product_template_yes.id,
                 "price_unit": 100,
                 "name": "Line 1",
-                "product_uom": self.product_template_yes.uom_id.id,
+                "product_uom_id": self.product_template_yes.uom_id.id,
             }
         )
         self.assertFalse(line.can_create_product)
@@ -182,7 +182,7 @@ def test_onchange_product_id(self):
                             "price_unit": 100,
                             "name": "Line 1",
                             "product_uom_qty": 1,
-                            "product_uom": product.uom_id.id,
+                            "product_uom_id": product.uom_id.id,
                         },
                     )
                 ],
@@ -203,7 +203,7 @@ def _test_action_confirm(self):
                 "price_unit": 100,
                 "name": "Line 1",
                 "product_uom_qty": 1,
-                "product_uom": self.product_template_yes.uom_id.id,
+                "product_uom_id": self.product_template_yes.uom_id.id,
                 "product_attribute_ids": [
                     Command.create(
                         {
@@ -221,7 +221,7 @@ def _test_action_confirm(self):
             {
                 "order_id": order.id,
                 "product_tmpl_id": self.product_template_no.id,
-                "product_uom": self.product_template_no.uom_id.id,
+                "product_uom_id": self.product_template_no.uom_id.id,
                 "product_uom_qty": 1,
                 "price_unit": 200,
                 "name": "Line 2",

sale_variant_configurator/views/sale_view.xml

@@ -69,6 +69,39 @@
                     </list>
                 </field>
             </xpath>
+            <xpath
+                expr="//field[@name='order_line']/list//field[@name='product_id']"
+                position="attributes"
+            >
+                <attribute name="required">0</attribute>
+            </xpath>
+
+            <xpath
+                expr="//field[@name='order_line']/list//field[@name='product_uom_id']"
+                position="attributes"
+            >
+                <attribute name="required">0</attribute>
+            </xpath>
+            <xpath
+                expr="//field[@name='order_line']/list//field[@name='product_template_id']"
+                position="attributes"
+            >
+                <attribute name="required">0</attribute>
+            </xpath>
+            <!-- Order line form / popup -->
+            <xpath
+                expr="//field[@name='order_line']/form//field[@name='product_id']"
+                position="attributes"
+            >
+                <attribute name="required">0</attribute>
+            </xpath>
+
+            <xpath
+                expr="//field[@name='order_line']/form//field[@name='product_uom_id']"
+                position="attributes"
+            >
+                <attribute name="required">0</attribute>
+            </xpath>
         </field>
     </record>
     <record model="ir.ui.view" id="view_order_line_tree">