Skip to content

Commit 5fd4930

Browse files
committed
[FIX] purchase_duplicate_check: Code review fixing
1 parent 87d453b commit 5fd4930

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

purchase_duplicate_check/models/purchase_order.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -20,12 +20,12 @@ def _prepare_pending_orders_message(self, product_id):
2020
)
2121
type_ = order.state in ["draft", "sent"] and "RFQ" or "PO"
2222
message_parts.append(
23-
f"{type_}: {order_href} date: {order.create_date.date()} Qty: {line.product_qty}<br/>" # noqa
23+
f"{type_}: {order_href}; date: {order.create_date.date()}; Qty: {line.product_qty};<br/>" # noqa
2424
)
2525
return "".join(message_parts)
2626

2727
def _is_activity_enabled(self) -> bool:
28-
"""Check if activity for repeating orders is enabled"""
28+
"""Check if activity for duplicated orders is enabled"""
2929
return (
3030
self.env["ir.config_parameter"]
3131
.sudo()

purchase_duplicate_check/tests/test_purchase_order.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ def test_prepare_pending_orders_message(self):
4242
"""Test flow where prepare message for purchase order"""
4343
message = self.order1._prepare_pending_orders_message(self.product_2.id)
4444
self.assertFalse(message, "Message must be empty")
45-
expected_message = f"RFQ: <a href='/web#id={self.order1.id}&model=purchase.order'>{self.order1.name}</a> date: {self.order1.create_date.date()} Qty: 10.0<br/>" # noqa
45+
expected_message = f"RFQ: <a href='/web#id={self.order1.id}&model=purchase.order'>{self.order1.name}</a>; date: {self.order1.create_date.date()}; Qty: 10.0;<br/>" # noqa
4646
message = self.order1._prepare_pending_orders_message(self.product_1.id)
4747
self.assertEqual(message, expected_message, "Messages must be the same")
4848

0 commit comments

Comments
 (0)