[MIG] purchase_manual_currency: Migration to 17.0

Author: ArnauCForgeFlow

purchase_manual_currency/__manifest__.py

@@ -3,7 +3,7 @@
 
 {
     "name": "Purchase - Manual Currency",
-    "version": "15.0.1.0.0",
+    "version": "17.0.1.0.0",
     "category": "Purchase Management",
     "summary": "Allows to manual currency of Purchase",
     "author": "Ecosoft, Odoo Community Association (OCA)",

purchase_manual_currency/models/purchase.py

@@ -10,22 +10,15 @@
 class PurchaseOrder(models.Model):
     _inherit = "purchase.order"
 
-    manual_currency = fields.Boolean(
-        readonly=True,
-        states={"draft": [("readonly", False)]},
-    )
+    manual_currency = fields.Boolean()
     is_manual = fields.Boolean(compute="_compute_currency")
     type_currency = fields.Selection(
         selection=lambda self: self._get_label_currency_name(),
         default=lambda self: self._get_label_currency_name()[0][0],
-        readonly=True,
-        states={"draft": [("readonly", False)]},
     )
     manual_currency_rate = fields.Float(
         digits="Manual Currency",
         tracking=True,
-        readonly=True,
-        states={"draft": [("readonly", False)]},
         help="Set new currency rate to apply on the invoice\n."
         "This rate will be taken in order to convert amounts between the "
         "currency on the purchase order and last currency",

purchase_manual_currency/tests/test_purchase_manual_currency.py

@@ -28,6 +28,11 @@ def test_01_purchase_manual_currency(self):
             self.purchase_order.order_line[0].subtotal_company_currency,
         )
         self.assertFalse(self.purchase_order.currency_diff)
+
+        # Activate Multi Currency Group
+        multi_currency_group = self.env.ref("base.group_multi_currency")
+        self.env.user.groups_id |= multi_currency_group
+
         # Change currency
         self.assertEqual(self.purchase_order.manual_currency_rate, 0.0)
         with Form(self.purchase_order) as p:

purchase_manual_currency/views/purchase_views.xml

@@ -10,29 +10,27 @@
                 <label
                     for="manual_currency"
                     groups="base.group_multi_currency"
-                    attrs="{'invisible': [('is_manual', '=', False)]}"
+                    invisible="not is_manual"
                 />
-                <div
-                    groups="base.group_multi_currency"
-                    attrs="{'invisible': [('is_manual', '=', False)]}"
-                >
-                    <field name="manual_currency" />
+                <div groups="base.group_multi_currency" invisible="not is_manual">
+                    <field name="manual_currency" readonly="state != 'draft'" />
                     <label for="manual_currency_rate" invisible='1' />
-                    <div
-                        class="o_row"
-                        attrs="{'invisible': [('manual_currency', '=', False)]}"
-                    >
-                        <field name="manual_currency_rate" />
+                    <div class="o_row" invisible="not manual_currency">
+                        <field
+                            name="manual_currency_rate"
+                            readonly="state != 'draft'"
+                        />
                         <field
                             name="type_currency"
-                            attrs="{'required': [('manual_currency', '=', True)]}"
+                            required="manual_currency"
+                            readonly="state != 'draft'"
                         />
                         <button
                             aria-label="Opened"
                             type="object"
                             name="action_refresh_currency"
                             class="btn-link"
-                            states="draft"
+                            invisible="state != 'draft'"
                         >
                             <i title="Update Currency" class="fa fa-fw fa-refresh" />
                         </button>
@@ -46,11 +44,8 @@
                 <field name="subtotal_company_currency" />
                 <field name="company_currency_id" invisible="1" />
             </xpath>
-            <xpath expr="//field[@name='tax_totals_json']" position="before">
-                <field
-                    name="total_company_currency"
-                    attrs="{'invisible': [('currency_diff', '=', False)]}"
-                />
+            <xpath expr="//field[@name='tax_totals']" position="before">
+                <field name="total_company_currency" invisible="not currency_diff" />
                 <field name="company_currency_id" invisible="1" />
                 <field name="currency_diff" invisible="1" />
             </xpath>

purchase_manual_currency/views/res_config_settings_views.xml

@@ -8,22 +8,18 @@
             ref="purchase.res_config_settings_view_form_purchase"
         />
         <field name="arch" type="xml">
-            <xpath expr="//div[@name='invoicing_settings_container']" position="inside">
+            <xpath
+                expr="//block[@name='invoicing_settings_container']"
+                position="inside"
+            >
                 <div class="col-xs-12 col-md-6 o_setting_box">
-                    <div class="o_setting_left_pane" />
-                    <div class="o_setting_right_pane">
-                        <label
-                            for="manual_currency_po_inv"
-                            string="Bill Manual Currency"
-                        />
-                        <div class="text-muted">
+                    <setting title="Bill Manual Currency" id="bill_manual_currency">
                             <field
-                                name="manual_currency_po_inv"
-                                class="o_light_label mt16"
-                                widget="radio"
-                            />
-                        </div>
-                    </div>
+                            name="manual_currency_po_inv"
+                            class="o_light_label mt16"
+                            widget="radio"
+                        />
+                    </setting>
                 </div>
             </xpath>
         </field>