[MIG] purchase_invoice_new_picking_line: Migration to 16.0

Signed-off-by: Carmen Bianca BAKKER <[email protected]>

Author: carmenbianca

purchase_invoice_new_picking_line/__manifest__.py

@@ -4,7 +4,7 @@
 {
     "name": "Purchase Invoice New Picking Line",
     "summary": "When creating an invoice from incoming picking, also adds invoice lines for product that were not in the purchase order",
-    "version": "15.0.1.0.0",
+    "version": "16.0.1.0.0",
     "author": "Coop IT Easy SCRLfs, Odoo Community Association (OCA)",
     "category": "Purchase",
     "license": "AGPL-3",

purchase_invoice_new_picking_line/models/__init__.py

@@ -1 +1 @@
-from . import account_invoice
+from . import purchase_order

purchase_invoice_new_picking_line/models/account_invoice.py

@@ -0,0 +1,81 @@
+# SPDX-FileCopyrightText: 2024 Coop IT Easy
+#
+# SPDX-License-Identifier: AGPL-3.0-or-later
+
+from odoo import api, fields, models
+from odoo.fields import Command
+from odoo.tools.float_utils import float_compare, float_round
+
+
+class PurchaseOrder(models.Model):
+    _inherit = "purchase.order"
+
+    def _prepare_account_move_lines_from_stock_move(
+        self, stock_move_id, account_move_id
+    ):
+        self.ensure_one()
+
+        qty = max(stock_move_id.quantity_done, 0)
+        date = stock_move_id.date or fields.Date.today()
+        supplierinfo = self.env["product.supplierinfo"]
+        price_unit = 0.0
+        if self.partner_id:
+            supplierinfo = stock_move_id.product_id._select_seller(
+                partner_id=self.partner_id,
+                quantity=qty,
+                date=date,
+                uom_id=stock_move_id.product_uom,
+                params={"order_id": self},
+            )
+        if supplierinfo:
+            price_unit = supplierinfo.price
+        else:
+            price_unit = stock_move_id.product_id.lst_price
+        taxes = stock_move_id.product_id.supplier_taxes_id.filtered(
+            lambda tax: tax.company_id == self.company_id
+        )
+        tax_ids = self.fiscal_position_id.map_tax(taxes)  # TODO not sure about this
+
+        data = {
+            "display_type": "product",
+            # Normally the name is '{order_name}: {order_line_name}'.
+            "name": "%s: %s" % (stock_move_id.picking_id.name, stock_move_id.name),
+            "product_id": stock_move_id.product_id.id,
+            "product_uom_id": stock_move_id.product_uom.id,
+            "quantity": qty,
+            "price_unit": self.currency_id._convert(
+                price_unit,
+                self.company_id.currency_id,
+                self.company_id,
+                date,
+                round=False,
+            ),
+            "tax_ids": [Command.set(tax_ids.ids)],
+        }
+
+        return data
+
+    def add_missing_picking_products_to_account_move(self, account_move_id):
+        stock_moves = self.env["stock.move"]
+        for picking in self.picking_ids.filtered(lambda x: x.state == "done"):
+            stock_moves |= picking.move_ids.filtered(
+                lambda move: move.state == "done" and not move.purchase_line_id
+            )
+        new_lines_data = [
+            self._prepare_account_move_lines_from_stock_move(
+                stock_move, account_move_id
+            )
+            for stock_move in stock_moves
+        ]
+        account_move_id.write(
+            {"invoice_line_ids": [Command.create(line) for line in new_lines_data]}
+        )
+
+    def action_create_invoice(self):
+        result = super().action_create_invoice()
+        res_id = result.get("res_id")
+        if not res_id:
+            return result
+        invoice_id = self.env["account.move"].browse(res_id)
+        self.add_missing_picking_products_to_account_move(invoice_id)
+        return result

purchase_invoice_new_picking_line/models/purchase_order.py

@@ -18,7 +18,7 @@ def test_move_line_product_is_added_to_invoice(self):
         purchase_order.button_confirm()
         picking = purchase_order.picking_ids
         moves = picking.move_ids_without_package
-        self.assertEquals(len(purchase_order.order_line), len(moves))
+        self.assertEqual(len(purchase_order.order_line), len(moves))
 
         moves[0].quantity_done = moves[0].product_qty
         moves[1].quantity_done = moves[1].product_qty
@@ -37,17 +37,20 @@ def test_move_line_product_is_added_to_invoice(self):
         )
 
         wizard = picking.button_validate()
-        backorder_confirmation = self.env[wizard["res_model"]].browse(
-            wizard["res_id"]
+        # TODO: this doesn't seem right to me. Previously, button_validate()
+        # created a stock.backorder.confirmation. Now, only the defaults are put
+        # in the context, meaning we have to manually create it.
+        backorder_confirmation = (
+            self.env[wizard["res_model"]].with_context(wizard["context"]).create({})
         )
         backorder_confirmation.process_cancel_backorder()
 
-        res = purchase_order.with_context(
-            create_bill=True
-        ).action_view_invoice()
+        res = purchase_order.with_context(create_bill=True).action_view_invoice()
+        # TODO: There is no key 'context' here. In fact, res is empty, because
+        # purchase_order.invoice_ids is an empty recordset.
         ctx = res.get("context")
         f = Form(
-            self.env["account.invoice"].with_context(ctx),
+            self.env["account.move"].with_context(ctx),
             view="account.invoice_supplier_form",
         )
         invoice = f.save()