[IMP] repair_preparation: skip preparation flow for customer location repairs

Author: sbejaoui

repair_preparation/models/repair_order.py

@@ -29,9 +29,17 @@ class RepairOrder(models.Model):
         "stock.picking", compute="_compute_preparation_picking_ids"
     )
     repair_preparation_enabled = fields.Boolean(
-        related="warehouse_id.repair_preparation_enabled"
+        compute="_compute_repair_preparation_enabled"
     )
 
+    @api.depends("warehouse_id.repair_preparation_enabled", "location_id.usage")
+    def _compute_repair_preparation_enabled(self):
+        for rec in self:
+            rec.repair_preparation_enabled = bool(
+                rec.warehouse_id.repair_preparation_enabled
+                and rec.location_id.usage != "customer"
+            )
+
     @api.depends("warehouse_id", "repair_preparation_enabled")
     def _compute_preparation_picking_type_id(self):
         for rec in self:
@@ -106,11 +114,23 @@ def _run_preparation_procurements(self, operations):
         )
 
     def action_validate(self):
-        res = super().action_validate()
-        for rec in self:
-            if not rec.repair_preparation_enabled:
+        """repairs performed at a customer location don't require a preparation flow
+        and do not need to check available quantities (handled in super)"""
+        customer_repairs = self.filtered(
+            lambda repair: repair.location_id.usage == "customer"
+        )
+        non_customer_repairs = self.filtered(
+            lambda repair: repair.location_id.usage != "customer"
+        )
+        res = customer_repairs.action_repair_confirm()
+        if not non_customer_repairs:
+            return res
+        res = super(RepairOrder, non_customer_repairs).action_validate()
+        for repair in non_customer_repairs:
+            if not repair.repair_preparation_enabled:
                 continue
-            rec._run_preparation_procurements(rec.operations)
+            repair._run_preparation_procurements(repair.operations)
+
         return res
 
     def action_repair_end(self):

repair_preparation/tests/test_repair_preparation.py

@@ -212,3 +212,16 @@ def test_update_repair_line_after_preparation(self):
         self._do_picking(self.repair.preparation_picking_ids)
         self.assertEqual(self.line.location_id, self.prep_loc)
         self.assertEqual(self.line.lot_id, self.lot)
+
+    def test_preparation_disabled_when_reparation_location_is_customer(self):
+        """If the repair location is a customer location,
+        products are consumed without a preparation picking"""
+        self.warehouse.repair_preparation_enabled = True
+        self.assertTrue(self.repair.repair_preparation_enabled)
+        customer_location = self.env.ref("stock.stock_location_customers")
+        self.repair.location_id = customer_location
+        self.assertFalse(self.repair.repair_preparation_enabled)
+        self.repair.action_validate()
+        self.assertFalse(self.repair.preparation_picking_ids)
+        self.repair.action_repair_start()
+        self.assertFalse(self.line.preparation_move_ids)