[IMP] repair_preparation: update repair line after preparation move done

update repair line location and lot after preparation is done

Author: sbejaoui

repair_preparation/models/stock_move.py

@@ -17,3 +17,22 @@ def _prepare_procurement_values(self):
         if self.repair_line_id:
             res["repair_line_id"] = self.repair_line_id.id
         return res
+
+    def _action_done(self, cancel_backorder=False):
+        res = super()._action_done(cancel_backorder=cancel_backorder)
+        for rec in self:
+            if not rec.repair_line_id or not rec.state == "done":
+                continue
+            vals = {}
+            move_lines = rec.move_line_ids
+            lot_id = move_lines.lot_id[0].id if move_lines.lot_id else False
+            vals["lot_id"] = lot_id
+            location_id = (
+                move_lines.location_dest_id[0].id
+                if move_lines.location_dest_id
+                else rec.location_dest_id.id
+            )
+            if location_id:
+                vals["location_id"] = location_id
+            rec.repair_line_id.write(vals)
+        return res

repair_preparation/tests/test_repair_preparation.py

@@ -15,11 +15,14 @@ def setUpClass(cls):
             {"name": "product to repair", "type": "product"}
         )
         cls.product_c = cls.env["product.product"].create(
-            {"name": "product to consume", "type": "product"}
+            {"name": "product to consume", "type": "product", "tracking": "lot"}
         )
         cls.product_c_2 = cls.env["product.product"].create(
             {"name": "product to consume 2", "type": "product"}
         )
+        cls.lot = cls.env["stock.lot"].create(
+            {"name": "lot", "product_id": cls.product_c.id}
+        )
         cls.warehouse = cls.env["stock.warehouse"].create(
             {"name": "WH", "code": "wh_test"}
         )
@@ -75,7 +78,7 @@ def setUpClass(cls):
             cls.product, cls.prep_loc, 1.0
         )
         cls.env["stock.quant"]._update_available_quantity(
-            cls.product_c, cls.stock_loc, 10.0
+            cls.product_c, cls.stock_loc, 10.0, lot_id=cls.lot
         )
         cls.env["stock.quant"]._update_available_quantity(
             cls.product_c_2, cls.stock_loc, 10.0
@@ -146,7 +149,7 @@ def test_write_done_move_not_allowed(self):
         self.test_validate_runs_procurement()
         self._do_picking(self.repair.preparation_picking_ids)
         self.assertEqual(self.repair.preparation_picking_ids.state, "done")
-        with self.assertRaisesRegexp(
+        with self.assertRaisesRegex(
             ValidationError,
             "You cannot modify product/quantity for preparation lines "
             "because some linked moves are already done",
@@ -171,14 +174,14 @@ def test_write_repair_line_cancels_and_reprocures(self):
 
     def test_action_repair_end_checks(self):
 
-        with self.assertRaisesRegexp(
+        with self.assertRaisesRegex(
             ValidationError,
             "Preparation picking not found. Please procure/prepare parts first",
         ):
             self.repair.action_repair_end()
         self.repair.action_validate()
         self.repair.action_repair_start()
-        with self.assertRaisesRegexp(
+        with self.assertRaisesRegex(
             ValidationError, "Preparation picking is not done yet"
         ):
             self.repair.action_repair_end()
@@ -198,8 +201,14 @@ def test_preparation_disabled(self):
         self.repair.action_validate()
         self.assertFalse(self.repair.preparation_picking_ids)
         self.repair.action_repair_start()
-        self.repair.action_repair_end()
-        self.repair.action_repair_done()
-        self.assertEqual(self.repair.state, "done")
         self.assertFalse(self.line.preparation_move_ids)
-        self.assertTrue(self.line.move_id)
+
+    def test_update_repair_line_after_preparation(self):
+        self.test_validate_runs_procurement()
+        self.line.location_id = self.stock_loc
+        self.assertFalse(self.line.lot_id)
+        move_line = self.repair.preparation_picking_ids.move_line_ids
+        self.assertEqual(move_line.lot_id, self.lot)
+        self._do_picking(self.repair.preparation_picking_ids)
+        self.assertEqual(self.line.location_id, self.prep_loc)
+        self.assertEqual(self.line.lot_id, self.lot)