[FIX] repair_stock_consumption_step: preserve lot_id on preparation picking

Author: nicolas-delbovier-acsone

repair_stock_consumption_step/models/repair_order.py

@@ -48,12 +48,26 @@ def action_repair_done(self):
                     "location_dest_id": moves[0].location_dest_id.id,
                 }
             )
+
+            # Preserve lot info before unlink the move lines
+            move_id_lots_ids_map = {}
+            for move in moves:
+                move_id_lots_ids_map[move.id] = move.move_line_ids.mapped("lot_id").ids
+
             moves.picking_id = picking.id
             moves.move_line_ids.unlink()
-            moves._do_unreserve()
             moves._action_confirm()
             moves._action_assign()
-            moves.move_line_ids.picking_id = picking.id
+
+            # Reset lot_id on the new move lines
+            for move in moves:
+                lot_ids = move_id_lots_ids_map.get(move.id)
+                if not lot_ids:
+                    continue
+                for line in move.move_line_ids:
+                    if not line.lot_id:
+                        line.lot_id = lot_ids.pop(0)
+
             rec.consumption_picking_id = picking
             rec.state = "consumption"
         return res

repair_stock_consumption_step/tests/test_repair_stock_consumption_step.py

@@ -48,6 +48,9 @@ def setUpClass(cls):
                 "product_id": cls.product_c.id,
                 "product_uom_qty": 2.0,
                 "location_id": cls.repair_loc.id,
+                "lot_id": cls.env["stock.lot"]
+                .create({"name": "Test Lot", "product_id": cls.product_c.id})
+                .id,
             }
         )
         cls.env["stock.quant"]._update_available_quantity(
@@ -81,6 +84,7 @@ def test_repair_done_with_consumption_step(self):
         self.assertTrue(self.repair.consumption_picking_id)
         moves = self.env["stock.move"].search([("repair_id", "=", self.repair.id)])
         pick = self.repair.consumption_picking_id
+        self.assertEqual(self.repair.operations.lot_id, pick.move_line_ids.lot_id)
         self.assertTrue(moves)
         self.assertEqual(pick.move_ids, moves)
         self.assertSetEqual(set(moves.mapped("state")), {"assigned"})