[runbot_gitlab] warnings are errors

[hbrunn]

In https://github.com/OCA/runbot-addons/blob/11.0/runbot_gitlab/models/runbot_build.py#L49 we fail if the build's state is warning.

Some googling set me up to https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5004/diffs#5492807eeff7d8f64b722d397811464b1becdf97_119_122 which seems to be what we want here even though it's not mentioned in the docs: https://docs.gitlab.com/ee/api/commits.html#post-the-build-status-to-a-commit

@moylop260 did you try this and it didn't work? Otherwise, I'll provide a patch to use this some of the coming days.

[moylop260]

Hi @hbrunn
I didn't see the success_with_warnings status before.

If gitlab has a "yellow" state could be so good since that travis-ci ignored my comments about:

• [FEATURE REQUEST] Add yellow state for warnings travis-ci/travis-ci#4730

[moylop260]

@ruiztulio FYI

[ap-wtioit]

I tested this today on our system (gitlab version 11.1.0) and we cannot post success_with_warnings to the commits api (getting a 400 with invalid state)

it seems this new "meta" state should be state success with a flag has_warnings which i couldn't find in the source code or in the documentation of gitlab api for statuses

I could not find how to set the has_warnings for a gitlab commit over the api.