[MIG] sale_order_secondary_unit: Continue migration to 18.0

TT54291

Author: pilarvargas-tecnativa

sale_order_secondary_unit/README.rst

@@ -86,6 +86,7 @@ Contributors
    -  Sergio Teruel
    -  Ernesto Tejeda
    -  Pedro M. Baeza
+   -  Pilar Vargas
 
 Maintainers
 -----------

sale_order_secondary_unit/models/product_template.py

@@ -1,6 +1,6 @@
 # Copyright 2018-2020 Tecnativa - Sergio Teruel
 # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
-from odoo import _, api, fields, models
+from odoo import api, fields, models
 
 
 class ProductTemplate(models.Model):
@@ -44,8 +44,8 @@ def onchange_sale_secondary_uom_id(self):
         if len(self.product_variant_ids.sale_secondary_uom_id) > 1:
             return {
                 "warning": {
-                    "title": _("Warning"),
-                    "message": _(
+                    "title": self.env._("Warning"),
+                    "message": self.env._(
                         "Product variants have distinct sale secondary uom:"
                         "\n{secondary_uom}\n"
                         "All variants will be written with new secondary uom"

sale_order_secondary_unit/readme/CONTRIBUTORS.md

@@ -6,3 +6,4 @@
   - Sergio Teruel
   - Ernesto Tejeda
   - Pedro M. Baeza
+  - Pilar Vargas

sale_order_secondary_unit/report/sale_report_templates.xml

@@ -8,12 +8,12 @@
             expr="//table[hasclass('o_has_total_table','table','o_main_table')]//th[@name='th_quantity']"
             position="before"
         >
-            <th name="th_secondary_uom_id" class="text-right" groups="uom.group_uom">
+            <th name="th_secondary_uom_id" class="text-end" groups="uom.group_uom">
                 <span>Second. Qty</span>
             </th>
         </xpath>
         <xpath expr="//span[@t-field='line.product_uom_qty']/.." position="before">
-            <td name="td_secondary_uom_id" class="text-right" groups="uom.group_uom">
+            <td name="td_secondary_uom_id" class="text-end" groups="uom.group_uom">
                 <t t-if="line.secondary_uom_id">
                     <span t-field="line.secondary_uom_qty" />
                     <span

sale_order_secondary_unit/static/description/index.html

@@ -433,6 +433,7 @@ <h2><a class="toc-backref" href="#toc-entry-6">Contributors</a></h2>
 <li>Sergio Teruel</li>
 <li>Ernesto Tejeda</li>
 <li>Pedro M. Baeza</li>
+<li>Pilar Vargas</li>
 </ul>
 </li>
 </ul>

sale_order_secondary_unit/tests/test_product_template.py

@@ -1,5 +1,6 @@
 # Copyright 2018-2020 Tecnativa - Carlos Dauden
 # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
+from odoo import Command
 from odoo.tests import tagged
 
 from odoo.addons.base.tests.common import BaseCommon
@@ -52,17 +53,13 @@ def setUpClass(cls):
             {
                 "name": "Test Product 2",
                 "attribute_line_ids": [
-                    (
-                        0,
-                        0,
+                    Command.create(
                         {
                             "attribute_id": cls.color_attribute.id,
                             "value_ids": [(6, 0, cls.color_values.ids)],
                         },
                     ),
-                    (
-                        0,
-                        0,
+                    Command.create(
                         {
                             "attribute_id": cls.size_attribute.id,
                             "value_ids": [(6, 0, cls.size_values.ids)],

sale_order_secondary_unit/tests/test_sale_order.py

@@ -1,5 +1,6 @@
 # Copyright 2018-2020 Tecnativa - Carlos Dauden
 # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
+from odoo import Command
 from odoo.tests import Form, tagged
 
 from odoo.addons.base.tests.common import BaseCommon
@@ -27,9 +28,7 @@ def setUpClass(cls):
         cls.product.product_tmpl_id.write(
             {
                 "secondary_uom_ids": [
-                    (
-                        0,
-                        0,
+                    Command.create(
                         {
                             "name": "unit-500",
                             "uom_id": cls.product_uom_unit.id,

sale_order_secondary_unit/views/product_secondary_unit_views.xml

@@ -17,7 +17,8 @@
                     <filter
                         string="Product Variant"
                         name="product_id"
-                        context="{'group_by':'product_tmpl_id'}"
+                        context="{'group_by':'product_id'}"
+                        groups="product.group_product_variant"
                     />
                     <filter
                         string="UoM"
@@ -35,7 +36,10 @@
         <field name="arch" type="xml">
             <list editable="top" multi_edit="1">
                 <field name="product_tmpl_id" />
-                <field name="product_id" />
+                <field
+                    name="product_id"
+                    domain="[('product_tmpl_id', '=', product_tmpl_id)]"
+                />
                 <field name="code" />
                 <field name="name" />
                 <field name="uom_id" />