[MIG] sale_product_set: Migration to 17.0

Author: NICO-SOLUTIONS

sale_product_set/README.rst

@@ -95,6 +95,7 @@ Contributors
 -  Adria Gil Sorribes <adria.gil@forgeflow.com>
 -  Phuc (Tran Thanh) <phuc@trobz.com>
 -  Manuel Regidor <manuel.regidor@sygel.es>
+-  Nils Coenen <nils.coenen@nico-solutions.de>
 
 Other credits
 -------------

sale_product_set/__manifest__.py

@@ -6,7 +6,7 @@
     "category": "Sale",
     "license": "AGPL-3",
     "author": "Anybox, Odoo Community Association (OCA)",
-    "version": "16.0.2.0.0",
+    "version": "17.0.1.0.0",
     "website": "https://github.com/OCA/sale-workflow",
     "depends": ["sale", "sale_management", "product_set"],
     "data": [

sale_product_set/readme/CONTRIBUTORS.md

@@ -6,3 +6,4 @@
 - Adria Gil Sorribes \<<adria.gil@forgeflow.com>\>
 - Phuc (Tran Thanh) \<<phuc@trobz.com>\>
 - Manuel Regidor \<<manuel.regidor@sygel.es>\>
+- Nils Coenen \<<nils.coenen@nico-solutions.de>\>

sale_product_set/static/description/index.html

@@ -437,6 +437,7 @@ <h2><a class="toc-backref" href="#toc-entry-5">Contributors</a></h2>
 <li>Adria Gil Sorribes &lt;<a class="reference external" href="mailto:adria.gil&#64;forgeflow.com">adria.gil&#64;forgeflow.com</a>&gt;</li>
 <li>Phuc (Tran Thanh) &lt;<a class="reference external" href="mailto:phuc&#64;trobz.com">phuc&#64;trobz.com</a>&gt;</li>
 <li>Manuel Regidor &lt;<a class="reference external" href="mailto:manuel.regidor&#64;sygel.es">manuel.regidor&#64;sygel.es</a>&gt;</li>
+<li>Nils Coenen &lt;<a class="reference external" href="mailto:nils.coenen&#64;nico-solutions.de">nils.coenen&#64;nico-solutions.de</a>&gt;</li>
 </ul>
 </div>
 <div class="section" id="other-credits">

sale_product_set/tests/test_product_set.py

@@ -57,7 +57,7 @@ def test_add_set(self):
         # check all lines are included
         for line in self.product_set.set_line_ids:
             order_line = so.order_line.filtered(
-                lambda x: x.product_id == line.product_id
+                lambda x, line=line: x.product_id == line.product_id
             )
             order_line.ensure_one()
             self.assertEqual(order_line.product_uom_qty, line.quantity * wiz.quantity)

sale_product_set/views/sale_order.xml

@@ -11,7 +11,7 @@
                     type="action"
                     name="%(act_open_wizard_product_set_add_from_order)d"
                     icon="fa-cubes"
-                    attrs="{'invisible': [('state','not in',('draft','sent'))]}"
+                    invisible="state not in ('draft', 'sent')"
                     groups="base.group_user"
                     string="Add set"
                 />

sale_product_set/wizard/product_set_add.py

@@ -51,7 +51,7 @@ def _compute_product_set_line_ids(self):
                 # Passed on creation
                 continue
             lines = lines_from_ctx.filtered(
-                lambda x: x.product_set_id == rec.product_set_id
+                lambda x, rec=rec: x.product_set_id == rec.product_set_id
             )
             if lines:
                 # Use the ones from ctx but make sure they belong to the same set.

sale_product_set/wizard/product_set_add.xml

@@ -31,7 +31,7 @@
                             <field
                                 name="product_id"
                                 options="{'no_open': True, 'no_create': True}"
-                                attrs="{'required': [('display_type', '=', False)]}"
+                                required="display_type == 'False'"
                             />
                             <field name="display_type" />
                             <field name="name" widget="section_and_note_text" />

test-requirements.txt

@@ -0,0 +1 @@
+odoo17-addon-product_set @ git+https://github.com/OCA/product-attribute@refs/pull/1493/head