[IMP] sale_automatic_workflow: manage 'in payment' state and no entry payments

Make sure payments that dont generate an entry are properly related to the invoice.
Also, make sure no duplicate payments are created when using odoo enterprise having the
'in_payment' state

Author: JordiMForgeFlow

sale_automatic_workflow/data/automatic_workflow_data.xml

@@ -40,7 +40,7 @@
         <field name="model_id">account.move</field>
         <field
             name="domain"
-        >[('state', '=', 'posted'), ('move_type', '=', 'out_invoice'), ('payment_state','!=','paid')]</field>
+        >[('state', '=', 'posted'), ('move_type', '=', 'out_invoice'), ('payment_state','=','not_paid')]</field>
         <field name="user_ids" eval="[(4, ref('base.user_root'))]" />
     </record>
     <record id="automatic_validation" model="sale.workflow.process">

sale_automatic_workflow/models/automatic_workflow_job.py

@@ -166,7 +166,11 @@ def _register_payment_invoice(self, invoice):
         payment.action_post()
 
         domain = [
-            ("account_type", "in", ("asset_receivable", "liability_payable")),
+            (
+                "account_type",
+                "in",
+                self.env["account.payment"]._get_valid_payment_account_types(),
+            ),
             ("reconciled", "=", False),
         ]
         payment_lines = payment.move_id.line_ids.filtered_domain(domain)
@@ -175,6 +179,7 @@ def _register_payment_invoice(self, invoice):
             (payment_lines + lines).filtered_domain(
                 [("account_id", "=", account.id), ("reconciled", "=", False)]
             ).reconcile()
+        lines.move_id.matched_payment_ids += payment
         return payment
 
     @api.model

sale_automatic_workflow/tests/test_automatic_workflow.py

@@ -214,6 +214,7 @@ def test_create_payment_with_invoice_currency_id(self):
         )
         self.assertTrue(payment_id)
         self.assertEqual(invoice.currency_id.id, payment_id.currency_id.id)
+        self.assertEqual(invoice.payment_state, invoice._get_invoice_in_payment_state())
 
     def test_create_payment_with_specified_payment_journal(self):
         workflow = self.create_full_automatic()