[FIX] sale_invoice_plan: Pre-commit fixes

Author: rquevedo

sale_invoice_plan/models/sale.py

@@ -44,7 +44,7 @@ def _compute_invoice_plan_total(self):
     def _compute_invoice_plan_process(self):
         for rec in self:
             has_invoice_plan = rec.use_invoice_plan and rec.invoice_plan_ids
-            to_invoice = rec.invoice_plan_ids.filtered(lambda l: not l.invoiced)
+            to_invoice = rec.invoice_plan_ids.filtered(lambda plan: not plan.invoiced)
             inv_or_adv = rec.invoice_status == "to invoice" or (
                 rec.invoice_status == "no"
                 and "advance" in to_invoice.mapped("invoice_type")
@@ -65,7 +65,7 @@ def _check_invoice_plan_total_percent(self):
     def _check_invoice_plan(self):
         for rec in self:
             if rec.state != "draft":
-                if rec.invoice_plan_ids.filtered(lambda l: not l.percent):
+                if rec.invoice_plan_ids.filtered(lambda plan: not plan.percent):
                     raise ValidationError(
                         _("Please fill percentage for all invoice plan lines")
                     )

sale_invoice_plan/models/sale_invoice_plan.py

@@ -102,7 +102,7 @@ def _compute_amount(self):
             # For last line, amount is the left over
             if rec.last:
                 installments = rec.sale_id.invoice_plan_ids.filtered(
-                    lambda l: l.invoice_type == "installment"
+                    lambda plan: plan.invoice_type == "installment"
                 )
                 prev_amount = sum((installments - rec).mapped("amount"))
                 rec.amount = amount_untaxed - prev_amount
@@ -115,7 +115,7 @@ def _inverse_amount(self):
             if rec.sale_id.amount_untaxed != 0:
                 if rec.last:
                     installments = rec.sale_id.invoice_plan_ids.filtered(
-                        lambda l: l.invoice_type == "installment"
+                        lambda plan: plan.invoice_type == "installment"
                     )
                     prev_percent = sum((installments - rec).mapped("percent"))
                     rec.percent = 100 - prev_percent
@@ -147,7 +147,7 @@ def _get_amount_invoice(self, invoices):
         )
         if deposit_product_id:
             lines = invoices.mapped("invoice_line_ids").filtered(
-                lambda l: l.product_id.id != int(deposit_product_id)
+                lambda line: line.product_id.id != int(deposit_product_id)
             )
             amount_invoiced = sum(lines.mapped("price_subtotal"))
         return amount_invoiced
@@ -156,7 +156,7 @@ def _get_amount_invoice(self, invoices):
     def _compute_invoiced(self):
         for rec in self:
             invoiced = rec.invoice_move_ids.filtered(
-                lambda l: l.state in ("draft", "posted")
+                lambda invoice: invoice.state in ("draft", "posted")
             )
             rec.invoiced = True if invoiced else False
             rec.amount_invoiced = (

sale_invoice_plan/tests/test_sale_invoice_plan.py

@@ -59,9 +59,11 @@ def setUpClass(cls):
                 "code": "SJT0",
             }
         )
-        cls.default_pricelist = cls.env['product.pricelist'].create({
-            'name': 'Default Pricelist',
-        })
+        cls.default_pricelist = cls.env["product.pricelist"].create(
+            {
+                "name": "Default Pricelist",
+            }
+        )
 
         cls.setUpClassicProducts()
 
@@ -244,7 +246,7 @@ def test_02_invoice_plan_with_advance(self):
         with self.assertRaises(ValidationError):
             self.so_service.action_confirm()
         advance_line = self.so_service.invoice_plan_ids.filtered(
-            lambda l: l.invoice_type == "advance"
+            lambda plan: plan.invoice_type == "advance"
         )
         self.assertEqual(len(advance_line), 1, "No one advance line")
         # Add 10% to advance
@@ -262,7 +264,7 @@ def test_02_invoice_plan_with_advance(self):
         # Valid total quantity of invoices (exclude Advance line)
         quantity = sum(
             invoices.mapped("invoice_line_ids")
-            .filtered(lambda l: l.product_id == self.product_order)
+            .filtered(lambda line: line.product_id == self.product_order)
             .mapped("quantity")
         )
         self.assertEqual(quantity, 1, "Wrong number of total invoice quantity")
@@ -326,7 +328,8 @@ def test_invoice_plan_so_edit(self):
                 ],
             }
         )
-        # Overall amount changed to 3080, install amount not changed, only percent changed.
+        # Overall amount changed to 3080, install amount not
+        #  changed, only percent changed.
         self.assertEqual(self.so_service.amount_total, 3080.0)
         self.so_service.invoice_plan_ids._compute_amount()
         self.assertEqual(first_install.amount, 280.0)

sale_invoice_plan/views/sale_view.xml

@@ -7,28 +7,11 @@
             <tree editable="bottom">
                 <field name="no_edit" column_invisible="1" />
                 <field name="analytic_account_id" />
-                <field
-                    name="installment"
-                    readonly="no_edit"
-                />
-                <field
-                    name="plan_date"
-                    readonly="no_edit"
-                />
-                <field
-                    name="invoice_type"
-                    readonly="no_edit"
-                />
-                <field
-                    name="percent"
-                    optional="show"
-                    readonly="no_edit"
-                />
-                <field
-                    name="amount"
-                    optional="show"
-                    readonly="no_edit"
-                />
+                <field name="installment" readonly="no_edit" />
+                <field name="plan_date" readonly="no_edit" />
+                <field name="invoice_type" readonly="no_edit" />
+                <field name="percent" optional="show" readonly="no_edit" />
+                <field name="amount" optional="show" readonly="no_edit" />
                 <field name="amount_invoiced" optional="hide" sum="Amount" />
                 <field name="to_invoice" />
                 <field name="invoiced" />
@@ -58,14 +41,15 @@
                         <field name="percent" />
                         <field name="amount" />
                         <field name="invoiced" />
-                        <field name="invoice_move_ids" widget="many2many_tags" readonly="1"/>
+                        <field
+                            name="invoice_move_ids"
+                            widget="many2many_tags"
+                            readonly="1"
+                        />
                     </group>
                 </group>
-                <separator
-                    string="Related Invoices"
-                    invisible="not invoice_move_ids"
-                />
-                <field name="invoice_move_ids" widget="many2many_tags" readonly="1"/>
+                <separator string="Related Invoices" invisible="not invoice_move_ids" />
+                <field name="invoice_move_ids" widget="many2many_tags" readonly="1" />
             </form>
         </field>
     </record>
@@ -107,10 +91,7 @@
                 >invoice_plan_process or invoice_status != 'no' or state != 'sale'</attribute>
             </xpath>
             <xpath expr="/form/sheet/notebook/page" position="after">
-                <page
-                    string="Invoice Plan"
-                    invisible="not use_invoice_plan"
-                >
+                <page string="Invoice Plan" invisible="not use_invoice_plan">
                     <button
                         name="%(action_sale_create_invoice_plan)d"
                         string="⇒ Create Invoice Plan"

sale_invoice_plan/wizard/sale_make_planned_invoice.py

@@ -13,7 +13,7 @@ def create_invoices_by_plan(self):
         MakeInvoice = self.env["sale.advance.payment.inv"]
         invoice_plans = (
             self._context.get("all_remain_invoices")
-            and sale.invoice_plan_ids.filtered(lambda l: not l.invoiced)
+            and sale.invoice_plan_ids.filtered(lambda plan: not plan.invoiced)
             or sale.invoice_plan_ids.filtered("to_invoice")
         )
         for plan in invoice_plans.sorted("installment"):