[MIG] sale_planner_calendar: Migration to 18.0

TT54296

Author: victoralmau

sale_planner_calendar/README.rst

@@ -123,6 +123,7 @@ Contributors
    -  Carlos Dauden
    -  Carlos Roca
    -  Pilar Vargas
+   -  Víctor Martínez
 
 Maintainers
 -----------

sale_planner_calendar/__manifest__.py

@@ -3,7 +3,7 @@
 {
     "name": "Sale planner calendar",
     "summary": "Sale planner calendar",
-    "version": "16.0.3.0.0",
+    "version": "18.0.1.0.0",
     "development_status": "Beta",
     "category": "Sale",
     "website": "https://github.com/OCA/sale-workflow",
@@ -34,7 +34,6 @@
         "web.assets_backend": [
             "sale_planner_calendar/static/src/xml/categ_icons_widget_template.xml",
             "sale_planner_calendar/static/src/xml/sale_planner_calendar_event_sales.xml",
-            "sale_planner_calendar/static/src/xml/activity_menu_view.xml",
             "sale_planner_calendar/static/src/scss/sale_planner_calendar.scss",
             "sale_planner_calendar/static/src/js/*.js",
         ],

sale_planner_calendar/data/sale_planner_calendar_cron.xml

@@ -12,9 +12,7 @@
         <field name="user_id" ref="base.user_root" />
         <field name="interval_number">1</field>
         <field name="interval_type">days</field>
-        <field name="numbercall">-1</field>
         <field name="active" eval="True" />
-        <field name="doall" eval="False" />
     </record>
     <record forcecreate="True" id="cron_update_dynamic_final_date" model="ir.cron">
         <field
@@ -26,8 +24,6 @@
         <field name="user_id" ref="base.user_root" />
         <field name="interval_number">1</field>
         <field name="interval_type">months</field>
-        <field name="numbercall">-1</field>
         <field name="active" eval="True" />
-        <field name="doall" eval="False" />
     </record>
 </odoo>

sale_planner_calendar/i18n/it.po

@@ -1224,46 +1224,3 @@ msgstr "Giorno della settimana"
 #: model_terms:ir.ui.view,arch_db:sale_planner_calendar.view_sale_planner_calendar_kanban
 msgid "Whatsapp"
 msgstr "Whatsapp"
-
-#~ msgid "Assign new commercial to selected lines"
-#~ msgstr "Assegna nuovo commerciale alle righe selezionate"
-
-#~ msgid "Partner User"
-#~ msgstr "Utente partner"
-
-#~ msgid "Planned user"
-#~ msgstr "Utente pianificato"
-
-#~ msgid "Responsible"
-#~ msgstr "Responsabile"
-
-#~ msgid ""
-#~ "<i class=\"fa fa-pencil-square-o\"/>\n"
-#~ "                                        <span>Event</span>"
-#~ msgstr ""
-#~ "<i class=\"fa fa-pencil-square-o\"/>\n"
-#~ "                                        <span>Evento</span>"
-
-#~ msgid "Calendar Event Date"
-#~ msgstr "Data evento calendario"
-
-#~ msgid "Calendar Event Profile"
-#~ msgstr "Profilo evento calendario"
-
-#~ msgid "Event Planner State"
-#~ msgstr "Stato pianificatore evento"
-
-#~ msgid "Event Profile"
-#~ msgstr "Profilo evento"
-
-#~ msgid "Event schedule"
-#~ msgstr "Schedulazione evento"
-
-#~ msgid "Planner event"
-#~ msgstr "Evento pianificatore"
-
-#~ msgid "Process"
-#~ msgstr "Elabora"
-
-#~ msgid "Sale Planner Calendar Event Profile"
-#~ msgstr "Profilo evento calendario pianificatore vendite"

sale_planner_calendar/migrations/16.0.2.0.0/post-migration.py

@@ -126,10 +126,10 @@ def _compute_invoice_amount_residual(self):
                 ("payment_state", "!=", "paid"),
                 ("partner_id", "in", partner_ids),
             ],
-            fields=["amount_residual_signed"],
+            aggregates=["amount_residual_signed:sum"],
             groupby=["partner_id"],
         )
-        invoice_dic = {g["partner_id"][0]: g["amount_residual_signed"] for g in groups}
+        invoice_dic = {partner.id: data for partner, data in groups}
         for rec in self:
             amount_residual = invoice_dic.get(
                 rec.target_partner_id.commercial_partner_id.id, 0.0
@@ -179,10 +179,10 @@ def _compute_sanitized_partner_mobile(self):
     @api.depends("target_partner_id")
     def _compute_location_url(self):
         # The url is built to access the location from a google link. This will be done
-        # taking into account the location of the calendar event associated with the calendar
-        # planner event. If this location is not defined, the client's coordinates will
-        # be taken into account if they are defined, otherwise the client's address
-        # will be taken into account.
+        # taking into account the location of the calendar event associated with the
+        # calendar planner event. If this location is not defined, the client's
+        # coordinates will be taken into account if they are defined, otherwise the
+        # client's address will be taken into account.
         self.location_url = False
         for event in self:
             event_location = event.location
@@ -241,10 +241,11 @@ def _onchange_duration(self):
             )
         )
         if max_duration and self.duration > max_duration:
+            msg = f"Max duration set in config parameters is {max_duration} hours"
             return {
                 "warning": {
                     "title": "Max duration exceeded",
-                    "message": f"Max duration set in config parameters is {max_duration} hours",
+                    "message": msg,
                     "type": "notification",
                 }
             }

sale_planner_calendar/migrations/16.0.2.0.0/pre-migration.py

@@ -4,7 +4,7 @@
 
 from dateutil.relativedelta import relativedelta
 
-from odoo import _, fields, models
+from odoo import Command, fields, models
 from odoo.exceptions import ValidationError
 
 
@@ -20,10 +20,13 @@ def action_calendar_planner(self):
         )
         sale_planner_forward_months = self.env.company.sale_planner_forward_months
         # TODO: Get default values from res.config.settings
+        f_name_day_of_week = fields.Date.today().strftime("%A")[:3].lower()
         action["context"] = {
             "default_target_partner_id": self.id,
-            "default_categ_ids": [(4, categ.id)],
-            # Passing True omits the partner name, ensuring precise calculation of GPS location.
+            "default_categ_ids": [Command.link(categ.id)],
+            # Passing True omits the partner name, ensuring precise calculation of GPS
+            # location.
+            "default_active": True,
             "default_location": self._display_address(True).replace("\n", " "),
             "default_duration": categ.duration,
             "default_name": categ.name,
@@ -32,19 +35,17 @@ def action_calendar_planner(self):
             + timedelta(minutes=round((categ.duration or 1.0) * 60)),
             "default_recurrency": True,
             "default_rrule_type": "weekly",
+            "default_rrule_type_ui": "weekly",
+            f"default_{f_name_day_of_week}": True,
+            "default_interval": 1,
             "default_end_type": "end_date",
             "default_until": fields.Date.today()
             + relativedelta(months=sale_planner_forward_months),
             "default_is_dynamic_end_date": True,
             "default_user_id": self.user_id.id or self.env.user.id,
             "default_partner_ids": [
-                (
-                    6,
-                    0,
-                    [
-                        self.id,
-                        self.user_id.partner_id.id or self.env.user.partner_id.id,
-                    ],
+                Command.set(
+                    (self + (self.user_id.partner_id or self.env.user.partner_id)).ids
                 )
             ],
             "choose_unlink_method": True,
@@ -56,7 +57,7 @@ def action_calendar_planner(self):
                     "dont_notify": True,
                 }
             )
-        action["view_mode"] = "tree,form"
+        action["view_mode"] = "list,form"
         action["view_id"] = False
         action["views"] = []
         action["domain"] = [
@@ -82,7 +83,7 @@ def write(self, vals):
                 ]
             )
             if calendar_events:
-                msg = _(
+                msg = self.env._(
                     "This partner has sale planned events\n"
                     "You must change salesperson from the planner wizard"
                 )

sale_planner_calendar/models/calendar_event.py

@@ -1,11 +1,10 @@
 # Copyright 2024 Tecnativa - Carlos Roca
 # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
-import json
 from datetime import datetime
 
 import pytz
 
-from odoo import _, api, fields, models, modules
+from odoo import api, fields, models, modules
 
 
 class ResUsers(models.Model):
@@ -25,8 +24,8 @@ def get_action_sale_planner_calendar_event(self):
         )
 
     @api.model
-    def systray_get_activities(self):
-        res = super().systray_get_activities()
+    def _get_activity_groups(self):
+        res = super()._get_activity_groups()
         # Get user timezone or UTC if not set
         user_tz = pytz.timezone(self.env.user.tz or "UTC")
         # Get current time in user's timezone
@@ -57,7 +56,7 @@ def systray_get_activities(self):
                 {
                     "id": self.env["ir.model"]._get("calendar.event").id,
                     "type": "activity",
-                    "name": _("Sale planner calendar events"),
+                    "name": self.env._("Sale planner calendar events"),
                     "model": "calendar.event",
                     "icon": modules.module.get_module_icon(
                         self.env["calendar.event"]._original_module
@@ -67,7 +66,6 @@ def systray_get_activities(self):
                     "overdue_count": events_overdue_count,
                     "planned_count": events_planned_count,
                     "is_planner": True,
-                    "domain": json.dumps(domain),
                 }
             )
         return res