Skip to content

Commit a6bb2d8

Browse files
committed
[FIX] sale_order_revision: wrong revision list if user has a fav filter
If the user created a default afvorite filter on the Sales Order list, it will override the default filter set by the Revisons button. So, the Sale Order menu Action should not be reused for this.
1 parent 1aaf59f commit a6bb2d8

3 files changed

Lines changed: 17 additions & 7 deletions

File tree

sale_order_revision/README.rst

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ Sale order revisions
77
!! This file is generated by oca-gen-addon-readme !!
88
!! changes will be overwritten. !!
99
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
10-
!! source digest: sha256:b0e8b598479388b8dd3c07820ec6ee7d5363bd0420cc2521f8b3041e9a39e3b3
10+
!! source digest: sha256:acade735e80e4d45eb2bd16323b5faa402d223962f79449028812760bb1b0742
1111
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
1212
1313
.. |badge1| image:: https://img.shields.io/badge/maturity-Beta-yellow.png
@@ -84,6 +84,7 @@ Contributors
8484
* Raf Ven <raf.ven@dynapps.be>
8585
* Jeroen Evens <jeroen.evens@dynapps.be>
8686
* Kitti U. <kittiu@ecosoft.co.th>
87+
* Daniel Reis <dreis@opensourceintegrators.com>
8788

8889
Maintainers
8990
~~~~~~~~~~~

sale_order_revision/models/sale_order.py

Lines changed: 13 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
# Copyright 2020 Ecosoft Co., Ltd. (<http://ecosoft.co.th>)
55
# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
66

7-
from odoo import fields, models
7+
from odoo import _, fields, models
88

99

1010
class SaleOrder(models.Model):
@@ -34,14 +34,22 @@ def _prepare_revision_data(self, new_revision):
3434

3535
def action_view_revisions(self):
3636
self.ensure_one()
37-
result = self.env["ir.actions.actions"]._for_xml_id("sale.action_orders")
38-
result["domain"] = ["|", ("active", "=", False), ("active", "=", True)]
39-
result["context"] = {
37+
domain = ["|", ("active", "=", False), ("active", "=", True)]
38+
context = {
4039
"active_test": 0,
4140
"search_default_current_revision_id": self.id,
4241
"default_current_revision_id": self.id,
4342
}
44-
return result
43+
search_view = self.env.ref("sale.sale_order_view_search_inherit_sale")
44+
return {
45+
"name": _("Previous Revisions"),
46+
"view_mode": "tree,form",
47+
"res_model": "sale.order",
48+
"type": "ir.actions.act_window",
49+
"search_view_id": search_view.id,
50+
"domain": domain,
51+
"context": context,
52+
}
4553

4654
def action_cancel_create_revision(self):
4755
for sale in self:

sale_order_revision/static/description/index.html

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -367,7 +367,7 @@ <h1 class="title">Sale order revisions</h1>
367367
!! This file is generated by oca-gen-addon-readme !!
368368
!! changes will be overwritten. !!
369369
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
370-
!! source digest: sha256:b0e8b598479388b8dd3c07820ec6ee7d5363bd0420cc2521f8b3041e9a39e3b3
370+
!! source digest: sha256:acade735e80e4d45eb2bd16323b5faa402d223962f79449028812760bb1b0742
371371
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! -->
372372
<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/licence-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/sale-workflow/tree/14.0/sale_order_revision"><img alt="OCA/sale-workflow" src="https://img.shields.io/badge/github-OCA%2Fsale--workflow-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_order_revision"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/sale-workflow&amp;target_branch=14.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
373373
<p>On cancelled orders, you can click on the “New copy of Quotation” button. This
@@ -428,6 +428,7 @@ <h2><a class="toc-backref" href="#toc-entry-5">Contributors</a></h2>
428428
<li>Raf Ven &lt;<a class="reference external" href="mailto:raf.ven&#64;dynapps.be">raf.ven&#64;dynapps.be</a>&gt;</li>
429429
<li>Jeroen Evens &lt;<a class="reference external" href="mailto:jeroen.evens&#64;dynapps.be">jeroen.evens&#64;dynapps.be</a>&gt;</li>
430430
<li>Kitti U. &lt;<a class="reference external" href="mailto:kittiu&#64;ecosoft.co.th">kittiu&#64;ecosoft.co.th</a>&gt;</li>
431+
<li>Daniel Reis &lt;<a class="reference external" href="mailto:dreis&#64;opensourceintegrators.com">dreis&#64;opensourceintegrators.com</a>&gt;</li>
431432
</ul>
432433
</div>
433434
<div class="section" id="maintainers">

0 commit comments

Comments
 (0)