[MIG] sale_block_no_stock: Migration to 17.0

bizzappdev · bizzappdev · commit a9acd030d8cf · 2025-09-03T16:14:56.000+05:30
diff --git a/sale_block_no_stock/README.rst b/sale_block_no_stock/README.rst
@@ -17,13 +17,13 @@ Sale Block no Stock
     :target: http://www.gnu.org/licenses/lgpl-3.0-standalone.html
     :alt: License: LGPL-3
 .. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fsale--workflow-lightgray.png?logo=github
-    :target: https://github.com/OCA/sale-workflow/tree/16.0/sale_block_no_stock
+    :target: https://github.com/OCA/sale-workflow/tree/17.0/sale_block_no_stock
     :alt: OCA/sale-workflow
 .. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png
-    :target: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_block_no_stock
+    :target: https://translation.odoo-community.org/projects/sale-workflow-17-0/sale-workflow-17-0-sale_block_no_stock
     :alt: Translate me on Weblate
 .. |badge5| image:: https://img.shields.io/badge/runboat-Try%20me-875A7B.png
-    :target: https://runboat.odoo-community.org/builds?repo=OCA/sale-workflow&target_branch=16.0
+    :target: https://runboat.odoo-community.org/builds?repo=OCA/sale-workflow&target_branch=17.0
     :alt: Try me on Runboat
 
 |badge1| |badge2| |badge3| |badge4| |badge5|
@@ -78,10 +78,10 @@ To configure this module, you need to:
 2. Fill *Field to compare against the quantity demanded*. Possible
    values:
 
--  *virtual_available_at_date*: Planned quantity to be in stock on the
-   day of delivery
--  *qty_available_today*: Quantity available in stock today
--  *free_qty_today*: Quantity available without reserve in stock
+- *virtual_available_at_date*: Planned quantity to be in stock on the
+  day of delivery
+- *qty_available_today*: Quantity available in stock today
+- *free_qty_today*: Quantity available without reserve in stock
 
 3. Fill *Groups allowed to bypass the block*
 
@@ -114,7 +114,7 @@ Bug Tracker
 Bugs are tracked on `GitHub Issues <https://github.com/OCA/sale-workflow/issues>`_.
 In case of trouble, please check there if your issue has already been reported.
 If you spotted it first, help us to smash it by providing a detailed and welcomed
-`feedback <https://github.com/OCA/sale-workflow/issues/new?body=module:%20sale_block_no_stock%0Aversion:%2016.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
+`feedback <https://github.com/OCA/sale-workflow/issues/new?body=module:%20sale_block_no_stock%0Aversion:%2017.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
 
 Do not contact contributors directly about support or help with technical issues.
 
@@ -129,15 +129,15 @@ Authors
 Contributors
 ------------
 
--  Eduardo de Miguel (`Moduon <https://www.moduon.team/>`__)
--  Rafael Blasco (`Moduon <https://www.moduon.team/>`__)
+- Eduardo de Miguel (`Moduon <https://www.moduon.team/>`__)
+- Rafael Blasco (`Moduon <https://www.moduon.team/>`__)
 
 Other credits
 -------------
 
 The development of this module has been financially supported by:
 
--  Ulzama
+- Ulzama
 
 Maintainers
 -----------
@@ -160,6 +160,6 @@ Current `maintainer <https://odoo-community.org/page/maintainer-role>`__:
 
 |maintainer-Shide| 
 
-This module is part of the `OCA/sale-workflow <https://github.com/OCA/sale-workflow/tree/16.0/sale_block_no_stock>`_ project on GitHub.
+This module is part of the `OCA/sale-workflow <https://github.com/OCA/sale-workflow/tree/17.0/sale_block_no_stock>`_ project on GitHub.
 
 You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute.
diff --git a/sale_block_no_stock/__manifest__.py b/sale_block_no_stock/__manifest__.py
@@ -3,8 +3,9 @@
 
 {
     "name": "Sale Block no Stock",
-    "summary": "Block Sales if products has not enough Quantity based on a chosen field",
-    "version": "16.0.2.0.0",
+    "summary": """Block Sales if products has not enough
+    Quantity based on a chosen field""",
+    "version": "17.0.1.0.0",
     "development_status": "Alpha",
     "category": "Sales/Sales",
     "website": "https://github.com/OCA/sale-workflow",
diff --git a/sale_block_no_stock/models/sale_order.py b/sale_block_no_stock/models/sale_order.py
@@ -28,10 +28,8 @@ def action_confirm(self):
                 if line.product_uom_qty > line[field_to_check.name]:
                     blocked_lines |= line
             if blocked_lines:
-                action = (
-                    self.env.ref("sale_block_no_stock.sale_order_block_wizard_action")
-                    .sudo()
-                    .read()[0]
+                action = self.env["ir.actions.actions"]._for_xml_id(
+                    "sale_block_no_stock.sale_order_block_wizard_action"
                 )
                 action["context"] = {
                     "default_sale_line_block_ids": [
diff --git a/sale_block_no_stock/static/description/index.html b/sale_block_no_stock/static/description/index.html
@@ -8,10 +8,11 @@
 
 /*
 :Author: David Goodger (goodger@python.org)
-:Id: $Id: html4css1.css 8954 2022-01-20 10:10:25Z milde $
+:Id: $Id: html4css1.css 9511 2024-01-13 09:50:07Z milde $
 :Copyright: This stylesheet has been placed in the public domain.
 
 Default cascading style sheet for the HTML output of Docutils.
+Despite the name, some widely supported CSS2 features are used.
 
 See https://docutils.sourceforge.io/docs/howto/html-stylesheets.html for how to
 customize this style sheet.
@@ -274,7 +275,7 @@
   margin-left: 2em ;
   margin-right: 2em }
 
-pre.code .ln { color: grey; } /* line numbers */
+pre.code .ln { color: gray; } /* line numbers */
 pre.code, code { background-color: #eeeeee }
 pre.code .comment, code .comment { color: #5C6576 }
 pre.code .keyword, code .keyword { color: #3B0D06; font-weight: bold }
@@ -300,7 +301,7 @@
 span.pre {
   white-space: pre }
 
-span.problematic {
+span.problematic, pre.problematic {
   color: red }
 
 span.section-subtitle {
@@ -368,7 +369,7 @@ <h1 class="title">Sale Block no Stock</h1>
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
 !! source digest: sha256:408792731be049ad77a018ccc6404bc72e66f817d177fa1cb510301be225d759
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! -->
-<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Alpha" src="https://img.shields.io/badge/maturity-Alpha-red.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/lgpl-3.0-standalone.html"><img alt="License: LGPL-3" src="https://img.shields.io/badge/licence-LGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/sale-workflow/tree/16.0/sale_block_no_stock"><img alt="OCA/sale-workflow" src="https://img.shields.io/badge/github-OCA%2Fsale--workflow-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_block_no_stock"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/sale-workflow&amp;target_branch=16.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
+<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Alpha" src="https://img.shields.io/badge/maturity-Alpha-red.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/lgpl-3.0-standalone.html"><img alt="License: LGPL-3" src="https://img.shields.io/badge/licence-LGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/sale-workflow/tree/17.0/sale_block_no_stock"><img alt="OCA/sale-workflow" src="https://img.shields.io/badge/github-OCA%2Fsale--workflow-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/sale-workflow-17-0/sale-workflow-17-0-sale_block_no_stock"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/sale-workflow&amp;target_branch=17.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
 <p>This module extends the functionality of Sales to support blocking sales
 and to allow you to ensure you are capable to send product you have in
 stock.</p>
@@ -460,7 +461,7 @@ <h1><a class="toc-backref" href="#toc-entry-4">Bug Tracker</a></h1>
 <p>Bugs are tracked on <a class="reference external" href="https://github.com/OCA/sale-workflow/issues">GitHub Issues</a>.
 In case of trouble, please check there if your issue has already been reported.
 If you spotted it first, help us to smash it by providing a detailed and welcomed
-<a class="reference external" href="https://github.com/OCA/sale-workflow/issues/new?body=module:%20sale_block_no_stock%0Aversion:%2016.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
+<a class="reference external" href="https://github.com/OCA/sale-workflow/issues/new?body=module:%20sale_block_no_stock%0Aversion:%2017.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
 <p>Do not contact contributors directly about support or help with technical issues.</p>
 </div>
 <div class="section" id="credits">
@@ -488,13 +489,15 @@ <h2><a class="toc-backref" href="#toc-entry-8">Other credits</a></h2>
 <div class="section" id="maintainers">
 <h2><a class="toc-backref" href="#toc-entry-9">Maintainers</a></h2>
 <p>This module is maintained by the OCA.</p>
-<a class="reference external image-reference" href="https://odoo-community.org"><img alt="Odoo Community Association" src="https://odoo-community.org/logo.png" /></a>
+<a class="reference external image-reference" href="https://odoo-community.org">
+<img alt="Odoo Community Association" src="https://odoo-community.org/logo.png" />
+</a>
 <p>OCA, or the Odoo Community Association, is a nonprofit organization whose
 mission is to support the collaborative development of Odoo features and
 promote its widespread use.</p>
 <p>Current <a class="reference external" href="https://odoo-community.org/page/maintainer-role">maintainer</a>:</p>
 <p><a class="reference external image-reference" href="https://github.com/Shide"><img alt="Shide" src="https://github.com/Shide.png?size=40px" /></a></p>
-<p>This module is part of the <a class="reference external" href="https://github.com/OCA/sale-workflow/tree/16.0/sale_block_no_stock">OCA/sale-workflow</a> project on GitHub.</p>
+<p>This module is part of the <a class="reference external" href="https://github.com/OCA/sale-workflow/tree/17.0/sale_block_no_stock">OCA/sale-workflow</a> project on GitHub.</p>
 <p>You are welcome to contribute. To learn how please visit <a class="reference external" href="https://odoo-community.org/page/Contribute">https://odoo-community.org/page/Contribute</a>.</p>
 </div>
 </div>
diff --git a/sale_block_no_stock/tests/test_sale_block_no_stock.py b/sale_block_no_stock/tests/test_sale_block_no_stock.py
@@ -100,7 +100,7 @@ def setUpClass(cls):
                 ],
             }
         )
-        cls.in_picking.move_ids[0].quantity_done = 11.0
+        cls.in_picking.move_ids[0].quantity = 11.0
 
     def _get_wizard(self, wizard_user, wizard_action):
         """Returns a new wizard instance from the given action."""
@@ -189,6 +189,8 @@ def test_sale_blocking_virtual_available_at_date(self):
         self.assertEqual(len(wizard.sale_line_block_ids), 1)
         self.assertFalse(wizard.confirmation_allowed)
         self.sale.commitment_date = "2024-01-05"
+        # Ensure incoming picking is in 'assigned' so forecast includes it
+        self.in_picking.action_assign()
         # No Block: 1 Dozen on 2024-01-05
         self.sale.with_user(self.saleblock_user.id).action_confirm()
         self.assertNotEqual(self.sale.state, "draft")
diff --git a/sale_block_no_stock/views/res_config_settings_views.xml b/sale_block_no_stock/views/res_config_settings_views.xml
@@ -5,47 +5,41 @@
         <field name="model">res.config.settings</field>
         <field name="inherit_id" ref="sale.res_config_settings_view_form" />
         <field name="arch" type="xml">
-            <xpath expr="//div[@id='no_edit_order']" position="after">
-                <div class="col-12 col-lg-6 o_setting_box">
-					<div class="o_setting_right_pane">
-						<label for="sale_line_field_block" string="Blocking sales due to lack of stock" />
-                        <span
-                            class="fa fa-lg fa-building-o"
-                            title="Values set here are company-specific."
-                            groups="base.group_multi_company"
-                        />
-						<div class="text-muted">
-							Avoid selling more product than you have in stock or planned
-						</div>
-						<div class="content-group">
-							<div class="mt-2">
-                                <label
-                                    for="sale_line_field_block"
-                                    string="Field to compare against the quantity demanded"
-                                    class="w-100"
-                                />
-                                <field
-                                    name="sale_line_field_block"
-                                    options="{'no_create': True, 'no_open': True}"
-                                    class="w-75"
-                                />
-                            </div>
-                            <div class="mt-1">
-                                <label
-                                    for="sale_line_block_allowed_groups"
-                                    string="Groups allowed to bypass the block"
-                                    class="w-100"
-                                />
-                                <field
-                                    name="sale_line_block_allowed_groups"
-                                    widget="many2many_tags"
-                                    options="{'no_create': True, 'no_open': True}"
-                                    class="w-100"
-                                />
-							</div>
-						</div>
-					</div>
-				</div>
+            <xpath expr="//setting[@id='no_edit_order']" position="after">
+                <setting
+                    id="sale_line_field_block"
+                    string="Blocking sales due to lack of stock"
+                    help="Avoid selling more product than you have in stock or planned"
+                    company_dependent="1"
+                >
+                    <div class="content-group">
+                        <div class="mt-2">
+                            <label
+                                for="sale_line_field_block"
+                                string="Field to compare against the quantity demanded"
+                                class="w-100"
+                            />
+                            <field
+                                name="sale_line_field_block"
+                                options="{'no_create': True, 'no_open': True}"
+                                class="w-75"
+                            />
+                        </div>
+                        <div class="mt-1">
+                            <label
+                                for="sale_line_block_allowed_groups"
+                                string="Groups allowed to bypass the block"
+                                class="w-100"
+                            />
+                            <field
+                                name="sale_line_block_allowed_groups"
+                                widget="many2many_tags"
+                                options="{'no_create': True, 'no_open': True}"
+                                class="w-100"
+                            />
+                        </div>
+                    </div>
+                </setting>
             </xpath>
         </field>
     </record>
diff --git a/sale_block_no_stock/wizard/sale_order_block_wizard.py b/sale_block_no_stock/wizard/sale_order_block_wizard.py
diff --git a/sale_block_no_stock/wizard/sale_order_block_wizard_views.xml b/sale_block_no_stock/wizard/sale_order_block_wizard_views.xml
